[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema

2019-12-12 Thread Zoltan Haindrich (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995431#comment-16995431
 ] 

Zoltan Haindrich commented on HIVE-22632:
-

+1

> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
>  Issue Type: Improvement
>  Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could 
> be avoided.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema

2019-12-12 Thread Vineet Garg (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995380#comment-16995380
 ] 

Vineet Garg commented on HIVE-22632:


[~jcamachorodriguez] [~kgyrtkirk] Can you take a look please?

> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
>  Issue Type: Improvement
>  Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could 
> be avoided.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema

2019-12-12 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994799#comment-16994799
 ] 

Hive QA commented on HIVE-22632:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988649/HIVE-22632.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17772 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19899/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19899/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19899/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12988649 - PreCommit-HIVE-Build

> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
>  Issue Type: Improvement
>  Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could 
> be avoided.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22632) Improve estimateRowSizeFromSchema

2019-12-12 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994761#comment-16994761
 ] 

Hive QA commented on HIVE-22632:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
31s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19899/dev-support/hive-personality.sh
 |
| git revision | master / 41b51fc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19899/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Improve estimateRowSizeFromSchema
> -
>
> Key: HIVE-22632
> URL: https://issues.apache.org/jira/browse/HIVE-22632
> Project: Hive
>  Issue Type: Improvement
>  Components: Statistics
>Reporter: Vineet Garg
>Assignee: Vineet Garg
>Priority: Major
> Attachments: HIVE-22632.1.patch
>
>
> estimateRowSizeFromSchema un-necessarily iterate and do look-up. This could 
> be avoided.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)