[jira] [Commented] (HIVE-25011) Concurrency: Do not acquire locks for EXPLAIN
[
https://issues.apache.org/jira/browse/HIVE-25011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418133#comment-17418133
]
Denys Kuzmenko commented on HIVE-25011:
---
hi [~gopalv], sorry, I missed your reply. I have created PR with your fix +
added the test. Please check:
https://github.com/apache/hive/pull/2660
> Concurrency: Do not acquire locks for EXPLAIN
> -
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
>Affects Versions: 4.0.0
>Reporter: Gopal Vijayaraghavan
>Assignee: Gopal Vijayaraghavan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-25011.1.patch, HIVE-25011.2.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-25011) Concurrency: Do not acquire locks for EXPLAIN
[
https://issues.apache.org/jira/browse/HIVE-25011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17321292#comment-17321292
]
Gopal Vijayaraghavan commented on HIVE-25011:
-
I tried making a simple test yesterday, but since I leave the locks in the
query-plan, but only skip it in the Driver codepath, this is a bit odd.
{code}
txnMgr.acquireLocks(driver.getPlan(), ctx, ...);
{code}
That will grab locks, because the locks are in the plan - but they were not
acquired during exec.
> Concurrency: Do not acquire locks for EXPLAIN
> -
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
>Affects Versions: 4.0.0
>Reporter: Gopal Vijayaraghavan
>Assignee: Gopal Vijayaraghavan
>Priority: Major
> Attachments: HIVE-25011.1.patch, HIVE-25011.2.patch
>
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-25011) Concurrency: Do not acquire locks for EXPLAIN
[
https://issues.apache.org/jira/browse/HIVE-25011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320786#comment-17320786
]
Denys Kuzmenko commented on HIVE-25011:
---
[~gopalv], could you please create a simple test for this scenario under
TestDbTxnManager2. You can find many similar tests there.
> Concurrency: Do not acquire locks for EXPLAIN
> -
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
>Affects Versions: 4.0.0
>Reporter: Gopal Vijayaraghavan
>Assignee: Gopal Vijayaraghavan
>Priority: Major
> Attachments: HIVE-25011.1.patch, HIVE-25011.2.patch
>
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-25011) Concurrency: Do not acquire locks for EXPLAIN
[
https://issues.apache.org/jira/browse/HIVE-25011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320702#comment-17320702
]
Peter Vary commented on HIVE-25011:
---
CC: [~dkuzmenko]
> Concurrency: Do not acquire locks for EXPLAIN
> -
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
>Affects Versions: 4.0.0
>Reporter: Gopal Vijayaraghavan
>Assignee: Gopal Vijayaraghavan
>Priority: Major
> Attachments: HIVE-25011.1.patch, HIVE-25011.2.patch
>
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-25011) Concurrency: Do not acquire locks for EXPLAIN
[
https://issues.apache.org/jira/browse/HIVE-25011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17320533#comment-17320533
]
Gopal Vijayaraghavan commented on HIVE-25011:
-
{code}
/**
* Find whether we should execute the current query due to explain
* @return true if the query needs to be executed, false if not
*/
public boolean isExplainSkipExecution() {
return (explainConfig != null && explainConfig.getAnalyze() !=
AnalyzeState.RUNNING);
}
{code}
Looks like the comment is actually wrong on the "return true"
> Concurrency: Do not acquire locks for EXPLAIN
> -
>
> Key: HIVE-25011
> URL: https://issues.apache.org/jira/browse/HIVE-25011
> Project: Hive
> Issue Type: Improvement
> Components: Locking, Transactions
>Affects Versions: 4.0.0
>Reporter: Gopal Vijayaraghavan
>Assignee: Gopal Vijayaraghavan
>Priority: Major
> Attachments: HIVE-25011.1.patch
>
>
> {code}
> EXPLAIN UPDATE ...
> {code}
> should not be in conflict with another active ongoing UPDATE operation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
