[
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14382112#comment-14382112
]
Sergio Peña commented on HIVE-8817:
---
Looks good.
+1
Create unit test where we insert
[
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380623#comment-14380623
]
Hive QA commented on HIVE-8817:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375246#comment-14375246
]
Ferdinand Xu commented on HIVE-8817:
Thanks [~spena] for your review.
[~szehon], do you
[
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371539#comment-14371539
]
Sergio Peña commented on HIVE-8817:
---
Thanks [~Ferd]
The test passes now. It was a
[
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370071#comment-14370071
]
Sergio Peña commented on HIVE-8817:
---
[~Ferd] - Could you post the patch on a review