[jira] [Updated] (HIVE-10444) HIVE-10223 breaks hadoop-1 build
[ https://issues.apache.org/jira/browse/HIVE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HIVE-10444: - Attachment: HIVE-10444.addendum.3.patch [~prasanth_j], thank you for the commit! bq. Build is still failing even with this patch [~xuefuz], that one is a new problem introduced by HIVE-10151 just today after the pre-commit run for this patch. I'm attaching an addendum patch to fix that. If it's better to file a new jira to track the new patch, let me know, and I'll do that. HIVE-10223 breaks hadoop-1 build Key: HIVE-10444 URL: https://issues.apache.org/jira/browse/HIVE-10444 Project: Hive Issue Type: Bug Affects Versions: 1.2.0 Reporter: Prasanth Jayachandran Assignee: Chris Nauroth Fix For: 1.2.0, 1.3.0 Attachments: HIVE-10444.1.patch, HIVE-10444.2.patch, HIVE-10444.addendum.3.patch FileStatus.isFile() and FileStatus.isDirectory() methods added in HIVE-10223 are not present in hadoop 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-10444) HIVE-10223 breaks hadoop-1 build
[ https://issues.apache.org/jira/browse/HIVE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HIVE-10444: - Assignee: Chris Nauroth (was: Gunther Hagleitner) Sorry for the HIVE-10223 breakage. I'll pick this up. [~prasanth_j], thank you for filing the bug report. HIVE-10223 breaks hadoop-1 build Key: HIVE-10444 URL: https://issues.apache.org/jira/browse/HIVE-10444 Project: Hive Issue Type: Bug Affects Versions: 1.2.0 Reporter: Prasanth Jayachandran Assignee: Chris Nauroth FileStatus.isFile() and FileStatus.isDirectory() methods added in HIVE-10223 are not present in hadoop 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-10444) HIVE-10223 breaks hadoop-1 build
[
https://issues.apache.org/jira/browse/HIVE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HIVE-10444:
-
Attachment: HIVE-10444.1.patch
I also found one occurrence of the same problem that was not introduced by
HIVE-10223. Instead, it was introduced by HIVE-10066.
I think the simplest thing to do is to revert to using {{FileStatus#isDir}},
which is present in Hadoop 1.2.1. It's deprecated in 2.x in favor of
{{FileStatus#isDirectory}}, but it's still usable. I'm attaching a patch.
I verified a build locally for both {{-Phadoop-1}} and {{-Phadoop-2}}.
HIVE-10223 breaks hadoop-1 build
Key: HIVE-10444
URL: https://issues.apache.org/jira/browse/HIVE-10444
Project: Hive
Issue Type: Bug
Affects Versions: 1.2.0
Reporter: Prasanth Jayachandran
Assignee: Chris Nauroth
Attachments: HIVE-10444.1.patch
FileStatus.isFile() and FileStatus.isDirectory() methods added in HIVE-10223
are not present in hadoop 1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HIVE-10444) HIVE-10223 breaks hadoop-1 build
[ https://issues.apache.org/jira/browse/HIVE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HIVE-10444: - Attachment: HIVE-10444.2.patch [~apivovarov], thank you for your review. I'm attaching patch v2. Here it is in Review Board: https://reviews.apache.org/r/33715/ Patch v1 basically just restored the logic to pre-HIVE-10223 state. You're right that there was a redundant check and an unreachable block though. There is no reason to maintain it this way now, so I made the correction in patch v2. HIVE-10223 breaks hadoop-1 build Key: HIVE-10444 URL: https://issues.apache.org/jira/browse/HIVE-10444 Project: Hive Issue Type: Bug Affects Versions: 1.2.0 Reporter: Prasanth Jayachandran Assignee: Chris Nauroth Attachments: HIVE-10444.1.patch, HIVE-10444.2.patch FileStatus.isFile() and FileStatus.isDirectory() methods added in HIVE-10223 are not present in hadoop 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-10444) HIVE-10223 breaks hadoop-1 build
[ https://issues.apache.org/jira/browse/HIVE-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasanth Jayachandran updated HIVE-10444: - Assignee: Gunther Hagleitner HIVE-10223 breaks hadoop-1 build Key: HIVE-10444 URL: https://issues.apache.org/jira/browse/HIVE-10444 Project: Hive Issue Type: Bug Affects Versions: 1.2.0 Reporter: Prasanth Jayachandran Assignee: Gunther Hagleitner FileStatus.isFile() and FileStatus.isDirectory() methods added in HIVE-10223 are not present in hadoop 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
