[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-15442: -- Labels: pull-request-available (was: ) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.0 > > Attachments: HIVE-15442.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Xu updated HIVE-15442: Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) Pushed to master. Thanks Saijin. > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > Fix For: 3.0.0 > > Attachments: HIVE-15442.1.patch > > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Status: Patch Available (was: Open) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > Attachments: HIVE-15442.1.patch > > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Attachment: HIVE-15442.1.patch > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > Attachments: HIVE-15442.1.patch > > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Status: Open (was: Patch Available) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Description: Driver.java has a redundancy code about "explain output", i think the if statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a repeat judge with the above statement. was: Driver.java has a redundancy code,i think the third if statement could be remved. if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { String explainOutput = getExplainOutput(sem, plan, tree.dump()); if (explainOutput != null) { if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { LOG.info("EXPLAIN output for queryid " + queryId + " : " + explainOutput); } if (conf.isWebUiQueryInfoCacheEnabled()) { queryDisplay.setExplainPlan(explainOutput); } } } > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Attachment: (was: HIVE-15442.patch) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > > Driver.java has a redundancy code about "explain output", i think the if > statement " if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT))" has a > repeat judge with the above statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Saijin Huang updated HIVE-15442: Affects Version/s: (was: 2.1.1) 3.0.0 > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Saijin Huang >Assignee: Saijin Huang >Priority: Minor > Attachments: HIVE-15442.patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Status: Patch Available (was: Open) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > Attachments: HIVE-15442.patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Status: Open (was: Patch Available) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > Attachments: HIVE-15442.patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Attachment: HIVE-15442.patch > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > Attachments: HIVE-15442.patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Attachment: (was: patch) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Status: Patch Available (was: Open) > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > Attachments: patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15442) Driver.java has a redundancy code
[ https://issues.apache.org/jira/browse/HIVE-15442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gold huang updated HIVE-15442: -- Attachment: patch > Driver.java has a redundancy code > -- > > Key: HIVE-15442 > URL: https://issues.apache.org/jira/browse/HIVE-15442 > Project: Hive > Issue Type: Bug >Affects Versions: 2.1.1 >Reporter: Gold huang >Assignee: Gold huang >Priority: Minor > Attachments: patch > > > Driver.java has a redundancy code,i think the third if statement could be > remved. > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > String explainOutput = getExplainOutput(sem, plan, tree.dump()); > if (explainOutput != null) { > if (conf.getBoolVar(ConfVars.HIVE_LOG_EXPLAIN_OUTPUT)) { > LOG.info("EXPLAIN output for queryid " + queryId + " : " + > explainOutput); > } > if (conf.isWebUiQueryInfoCacheEnabled()) { > queryDisplay.setExplainPlan(explainOutput); > } > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)