[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[ https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=442522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442522 ] ASF GitHub Bot logged work on HIVE-22234: - Author: ASF GitHub Bot Created on: 08/Jun/20 00:25 Start Date: 08/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #788: URL: https://github.com/apache/hive/pull/788#issuecomment-640302865 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442522) Time Spent: 50m (was: 40m) > Hive replication fails with table already exist error when replicating from > old version of hive. > > > Key: HIVE-22234 > URL: https://issues.apache.org/jira/browse/HIVE-22234 > Project: Hive > Issue Type: Bug >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22234.01.patch, HIVE-22234.02.patch, > HIVE-22234.03.patch, HIVE-22234.04.patch > > Time Spent: 50m > Remaining Estimate: 0h > > HIve replication from old version where HIVE-22046 is not patched will not > have engine column set in the table column stats. This causes "ERROR: null > value in column "ENGINE" violates not-null constraint" error during create > table while updating the column stats. As the column stats are updated after > the create table txn is committed, the next retry by HMS client throws table > already exist error. Need to update the ENGINE column to default value while > importing the table if the column value is not set. The column stat and > create table in same txn can be done as part of separate Jira. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[ https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=442524=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442524 ] ASF GitHub Bot logged work on HIVE-22234: - Author: ASF GitHub Bot Created on: 08/Jun/20 00:25 Start Date: 08/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #788: URL: https://github.com/apache/hive/pull/788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442524) Time Spent: 1h (was: 50m) > Hive replication fails with table already exist error when replicating from > old version of hive. > > > Key: HIVE-22234 > URL: https://issues.apache.org/jira/browse/HIVE-22234 > Project: Hive > Issue Type: Bug >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22234.01.patch, HIVE-22234.02.patch, > HIVE-22234.03.patch, HIVE-22234.04.patch > > Time Spent: 1h > Remaining Estimate: 0h > > HIve replication from old version where HIVE-22046 is not patched will not > have engine column set in the table column stats. This causes "ERROR: null > value in column "ENGINE" violates not-null constraint" error during create > table while updating the column stats. As the column stats are updated after > the create table txn is committed, the next retry by HMS client throws table > already exist error. Need to update the ENGINE column to default value while > importing the table if the column value is not set. The column stat and > create table in same txn can be done as part of separate Jira. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[
https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=318475=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318475
]
ASF GitHub Bot logged work on HIVE-22234:
-
Author: ASF GitHub Bot
Created on: 25/Sep/19 17:33
Start Date: 25/Sep/19 17:33
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #788: HIVE-22234 :
Hive replication fails with table already exist error when replicating from old
version of hive.
URL: https://github.com/apache/hive/pull/788#discussion_r328249792
##
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##
@@ -592,7 +592,7 @@ struct ColumnStatistics {
2: required list statsObj,
3: optional bool isStatsCompliant, // Are the stats isolation-level-compliant
with the
// the calling query?
-4: required string engine
+4: optional string engine
Review comment:
ok got it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318475)
Time Spent: 40m (was: 0.5h)
> Hive replication fails with table already exist error when replicating from
> old version of hive.
>
>
> Key: HIVE-22234
> URL: https://issues.apache.org/jira/browse/HIVE-22234
> Project: Hive
> Issue Type: Bug
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22234.01.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> HIve replication from old version where HIVE-22046 is not patched will not
> have engine column set in the table column stats. This causes "ERROR: null
> value in column "ENGINE" violates not-null constraint" error during create
> table while updating the column stats. As the column stats are updated after
> the create table txn is committed, the next retry by HMS client throws table
> already exist error. Need to update the ENGINE column to default value while
> importing the table if the column value is not set. The column stat and
> create table in same txn can be done as part of separate Jira.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[
https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=318169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318169
]
ASF GitHub Bot logged work on HIVE-22234:
-
Author: ASF GitHub Bot
Created on: 25/Sep/19 09:28
Start Date: 25/Sep/19 09:28
Worklog Time Spent: 10m
Work Description: maheshk114 commented on pull request #788: HIVE-22234 :
Hive replication fails with table already exist error when replicating from old
version of hive.
URL: https://github.com/apache/hive/pull/788#discussion_r328020701
##
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##
@@ -592,7 +592,7 @@ struct ColumnStatistics {
2: required list statsObj,
3: optional bool isStatsCompliant, // Are the stats isolation-level-compliant
with the
// the calling query?
-4: required string engine
+4: optional string engine
Review comment:
in older dumps ..it is not set ..so if we keep it required ..it will fail
during deserialization while reading the old dump files ...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318169)
Time Spent: 0.5h (was: 20m)
> Hive replication fails with table already exist error when replicating from
> old version of hive.
>
>
> Key: HIVE-22234
> URL: https://issues.apache.org/jira/browse/HIVE-22234
> Project: Hive
> Issue Type: Bug
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22234.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIve replication from old version where HIVE-22046 is not patched will not
> have engine column set in the table column stats. This causes "ERROR: null
> value in column "ENGINE" violates not-null constraint" error during create
> table while updating the column stats. As the column stats are updated after
> the create table txn is committed, the next retry by HMS client throws table
> already exist error. Need to update the ENGINE column to default value while
> importing the table if the column value is not set. The column stat and
> create table in same txn can be done as part of separate Jira.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[
https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=318164=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318164
]
ASF GitHub Bot logged work on HIVE-22234:
-
Author: ASF GitHub Bot
Created on: 25/Sep/19 09:19
Start Date: 25/Sep/19 09:19
Worklog Time Spent: 10m
Work Description: sankarh commented on pull request #788: HIVE-22234 :
Hive replication fails with table already exist error when replicating from old
version of hive.
URL: https://github.com/apache/hive/pull/788#discussion_r328016580
##
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##
@@ -592,7 +592,7 @@ struct ColumnStatistics {
2: required list statsObj,
3: optional bool isStatsCompliant, // Are the stats isolation-level-compliant
with the
// the calling query?
-4: required string engine
+4: optional string engine
Review comment:
Why don't we keep it required and set the default engine (Hive) if metadata
doesn't have it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 318164)
Time Spent: 20m (was: 10m)
> Hive replication fails with table already exist error when replicating from
> old version of hive.
>
>
> Key: HIVE-22234
> URL: https://issues.apache.org/jira/browse/HIVE-22234
> Project: Hive
> Issue Type: Bug
>Reporter: mahesh kumar behera
>Assignee: mahesh kumar behera
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22234.01.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> HIve replication from old version where HIVE-22046 is not patched will not
> have engine column set in the table column stats. This causes "ERROR: null
> value in column "ENGINE" violates not-null constraint" error during create
> table while updating the column stats. As the column stats are updated after
> the create table txn is committed, the next retry by HMS client throws table
> already exist error. Need to update the ENGINE column to default value while
> importing the table if the column value is not set. The column stat and
> create table in same txn can be done as part of separate Jira.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22234) Hive replication fails with table already exist error when replicating from old version of hive.
[ https://issues.apache.org/jira/browse/HIVE-22234?focusedWorklogId=318124=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318124 ] ASF GitHub Bot logged work on HIVE-22234: - Author: ASF GitHub Bot Created on: 25/Sep/19 08:06 Start Date: 25/Sep/19 08:06 Worklog Time Spent: 10m Work Description: maheshk114 commented on pull request #788: HIVE-22234 : Hive replication fails with table already exist error when replicating from old version of hive. URL: https://github.com/apache/hive/pull/788 … This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 318124) Remaining Estimate: 0h Time Spent: 10m > Hive replication fails with table already exist error when replicating from > old version of hive. > > > Key: HIVE-22234 > URL: https://issues.apache.org/jira/browse/HIVE-22234 > Project: Hive > Issue Type: Bug >Reporter: mahesh kumar behera >Assignee: mahesh kumar behera >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22234.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIve replication from old version where HIVE-22046 is not patched will not > have engine column set in the table column stats. This causes "ERROR: null > value in column "ENGINE" violates not-null constraint" error during create > table while updating the column stats. As the column stats are updated after > the create table txn is committed, the next retry by HMS client throws table > already exist error. Need to update the ENGINE column to default value while > importing the table if the column value is not set. The column stat and > create table in same txn can be done as part of separate Jira. -- This message was sent by Atlassian Jira (v8.3.4#803005)
