[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[ https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=504388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504388 ] ASF GitHub Bot logged work on HIVE-24032: - Author: ASF GitHub Bot Created on: 24/Oct/20 00:58 Start Date: 24/Oct/20 00:58 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1396: URL: https://github.com/apache/hive/pull/1396#issuecomment-715647392 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 504388) Time Spent: 1.5h (was: 1h 20m) > Remove hadoop shims dependency and use FileSystem Api directly from > standalone metastore > > > Key: HIVE-24032 > URL: https://issues.apache.org/jira/browse/HIVE-24032 > Project: Hive > Issue Type: Task >Reporter: Aasha Medhi >Assignee: Aasha Medhi >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24032.01.patch, HIVE-24032.02.patch, > HIVE-24032.03.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Remove hadoop shims dependency from standalone metastore. > Rename hive.repl.data.copy.lazy hive conf to > hive.repl.run.data.copy.tasks.on.target -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[ https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=473626=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-473626 ] ASF GitHub Bot logged work on HIVE-24032: - Author: ASF GitHub Bot Created on: 23/Aug/20 08:34 Start Date: 23/Aug/20 08:34 Worklog Time Spent: 10m Work Description: pvary commented on pull request #1396: URL: https://github.com/apache/hive/pull/1396#issuecomment-678746263 Why is this a good thing? AFAIK we introduced the Shims to be able to abstract out Hadoop dependencies and being able to work with different versions of Hadoop altogether. Removing shims will again fix as to a specific Hadoop version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 473626) Time Spent: 1h 20m (was: 1h 10m) > Remove hadoop shims dependency and use FileSystem Api directly from > standalone metastore > > > Key: HIVE-24032 > URL: https://issues.apache.org/jira/browse/HIVE-24032 > Project: Hive > Issue Type: Task >Reporter: Aasha Medhi >Assignee: Aasha Medhi >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24032.01.patch, HIVE-24032.02.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470547=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470547
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 14/Aug/20 03:10
Start Date: 14/Aug/20 03:10
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470385260
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
+ return false;
+}
+return (EncryptionFileUtils.getEncryptionZoneForPath(fullPath, conf) !=
null);
+ }
+
+ public static EncryptionZone getEncryptionZoneForPath(Path path,
Configuration conf) throws IOException {
+URI uri = path.getFileSystem(conf).getUri();
+if ("hdfs".equals(uri.getScheme())) {
+ HdfsAdmin hdfsAdmin = new HdfsAdmin(uri, conf);
+ if (path.getFileSystem(conf).exists(path)) {
+return hdfsAdmin.getEncryptionZoneForPath(path);
+ } else if (!path.getParent().equals(path)) {
Review comment:
This is an exit condition. When path is the root, then path.getParent
should be equal to path and exit the recursion. These utils are picked from
hadoop code Hadoop23shims.java.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 470547)
Time Spent: 1h 10m (was: 1h)
> Remove hadoop shims dependency and use FileSystem Api directly from
> standalone metastore
>
>
> Key: HIVE-24032
> URL: https://issues.apache.org/jira/browse/HIVE-24032
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24032.01.patch
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470536=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470536
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 14/Aug/20 02:26
Start Date: 14/Aug/20 02:26
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470374769
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
Review comment:
If the scheme itself is not hdfs, we needn't make a call to
getEncryptionZoneForPath.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 470536)
Time Spent: 1h (was: 50m)
> Remove hadoop shims dependency and use FileSystem Api directly from
> standalone metastore
>
>
> Key: HIVE-24032
> URL: https://issues.apache.org/jira/browse/HIVE-24032
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24032.01.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470535=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470535
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 14/Aug/20 02:24
Start Date: 14/Aug/20 02:24
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470374769
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
Review comment:
If the scheme itself is not hdfs, we needn't make a call to
getEncryptionZoneForPath. This will save a file system call and will be faster.
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
+ return false;
+}
+return (EncryptionFileUtils.getEncryptionZoneForPath(fullPath, conf) !=
null);
Review comment:
Its a static method and hence used with the class name
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 470535)
Time Spent: 50m (was: 40m)
> Remove hadoop shims dependency and use FileSystem Api directly from
> standalone metastore
>
>
> Key: HIVE-24032
> URL: https://issues.apache.org/jira/browse/HIVE-24032
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470534
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 14/Aug/20 02:20
Start Date: 14/Aug/20 02:20
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470373805
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
+ return false;
+}
+return (EncryptionFileUtils.getEncryptionZoneForPath(fullPath, conf) !=
null);
+ }
+
+ public static EncryptionZone getEncryptionZoneForPath(Path path,
Configuration conf) throws IOException {
+URI uri = path.getFileSystem(conf).getUri();
+if ("hdfs".equals(uri.getScheme())) {
+ HdfsAdmin hdfsAdmin = new HdfsAdmin(uri, conf);
+ if (path.getFileSystem(conf).exists(path)) {
+return hdfsAdmin.getEncryptionZoneForPath(path);
+ } else if (!path.getParent().equals(path)) {
+return getEncryptionZoneForPath(path.getParent(), conf);
+ } else {
+return null;
+ }
+}
+return null;
+ }
+
+ public static void createEncryptionZone(Path path, String keyName,
Configuration conf) throws IOException {
Review comment:
Better to keep it as part of same utility class. Tests can also use this
from utility. Its not a test code, its a utility method
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 470534)
Time Spent: 40m (was: 0.5h)
> Remove hadoop shims dependency and use FileSystem Api directly from
> standalone metastore
>
>
> Key: HIVE-24032
> URL: https://issues.apache.org/jira/browse/HIVE-24032
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24032.01.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470533=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470533
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 14/Aug/20 02:19
Start Date: 14/Aug/20 02:19
Worklog Time Spent: 10m
Work Description: aasha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470373619
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
+ return false;
+}
+return (EncryptionFileUtils.getEncryptionZoneForPath(fullPath, conf) !=
null);
Review comment:
Its a static method
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 470533)
Time Spent: 0.5h (was: 20m)
> Remove hadoop shims dependency and use FileSystem Api directly from
> standalone metastore
>
>
> Key: HIVE-24032
> URL: https://issues.apache.org/jira/browse/HIVE-24032
> Project: Hive
> Issue Type: Task
>Reporter: Aasha Medhi
>Assignee: Aasha Medhi
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-24032.01.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[
https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=470429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-470429
]
ASF GitHub Bot logged work on HIVE-24032:
-
Author: ASF GitHub Bot
Created on: 13/Aug/20 21:00
Start Date: 13/Aug/20 21:00
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #1396:
URL: https://github.com/apache/hive/pull/1396#discussion_r470230243
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
Review comment:
Add a private constructor to avoid any accidental object creation
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
Review comment:
nit: Can we rename it to EncryptionZoneUtils
##
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/EncryptionFileUtils.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.metastore.utils;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdfs.client.HdfsAdmin;
+import org.apache.hadoop.hdfs.protocol.EncryptionZone;
+
+import java.io.IOException;
+import java.net.URI;
+
+public class EncryptionFileUtils {
+
+ public static boolean isPathEncrypted(Path path, Configuration conf) throws
IOException {
+Path fullPath;
+if (path.isAbsolute()) {
+ fullPath = path;
+} else {
+ fullPath = path.getFileSystem(conf).makeQualified(path);
+}
+if(!"hdfs".equalsIgnoreCase(path.toUri().getScheme())) {
+ return
[jira] [Work logged] (HIVE-24032) Remove hadoop shims dependency and use FileSystem Api directly from standalone metastore
[ https://issues.apache.org/jira/browse/HIVE-24032?focusedWorklogId=469713=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-469713 ] ASF GitHub Bot logged work on HIVE-24032: - Author: ASF GitHub Bot Created on: 12/Aug/20 13:52 Start Date: 12/Aug/20 13:52 Worklog Time Spent: 10m Work Description: aasha opened a new pull request #1396: URL: https://github.com/apache/hive/pull/1396 …rectly from standalone metastore ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 469713) Remaining Estimate: 0h Time Spent: 10m > Remove hadoop shims dependency and use FileSystem Api directly from > standalone metastore > > > Key: HIVE-24032 > URL: https://issues.apache.org/jira/browse/HIVE-24032 > Project: Hive > Issue Type: Task >Reporter: Aasha Medhi >Assignee: Aasha Medhi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
