[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=524783=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524783 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 16/Dec/20 00:52 Start Date: 16/Dec/20 00:52 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #1563: URL: https://github.com/apache/hive/pull/1563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 524783) Time Spent: 1h 20m (was: 1h 10m) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=521967=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521967 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Dec/20 00:49 Start Date: 09/Dec/20 00:49 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1563: URL: https://github.com/apache/hive/pull/1563#issuecomment-741342691 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 521967) Time Spent: 1h 10m (was: 1h) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=498473=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498473 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Oct/20 14:10 Start Date: 09/Oct/20 14:10 Worklog Time Spent: 10m Work Description: pkumarsinha commented on a change in pull request #1563: URL: https://github.com/apache/hive/pull/1563#discussion_r502202414 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestAtlasDumpTask.java ## @@ -96,4 +105,13 @@ public void testAtlasDumpMetrics() throws Exception { Assert.assertTrue(eventDetailsCaptor .getAllValues().get(1).toString().contains("{\"dbName\":\"srcDB\",\"dumpEndTime\"")); } + + @Test + public void testAtlasRestClientBuilder() throws SemanticException, IOException { +mockStatic(UserGroupInformation.class); + when(UserGroupInformation.getLoginUser()).thenReturn(mock(UserGroupInformation.class)); +AtlasRestClientBuilder atlasRestCleintBuilder = new AtlasRestClientBuilder("http://localhost:31000;); +AtlasRestClient atlasClient = atlasRestCleintBuilder.getClient(conf); +Assert.assertTrue(atlasClient != null); Review comment: HiveConf is mocked, so hive in test is not present(so false). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 498473) Time Spent: 1h (was: 50m) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=498364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498364 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Oct/20 14:01 Start Date: 09/Oct/20 14:01 Worklog Time Spent: 10m Work Description: aasha commented on a change in pull request #1563: URL: https://github.com/apache/hive/pull/1563#discussion_r502163365 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestAtlasDumpTask.java ## @@ -96,4 +105,13 @@ public void testAtlasDumpMetrics() throws Exception { Assert.assertTrue(eventDetailsCaptor .getAllValues().get(1).toString().contains("{\"dbName\":\"srcDB\",\"dumpEndTime\"")); } + + @Test + public void testAtlasRestClientBuilder() throws SemanticException, IOException { +mockStatic(UserGroupInformation.class); + when(UserGroupInformation.getLoginUser()).thenReturn(mock(UserGroupInformation.class)); +AtlasRestClientBuilder atlasRestCleintBuilder = new AtlasRestClientBuilder("http://localhost:31000;); +AtlasRestClient atlasClient = atlasRestCleintBuilder.getClient(conf); +Assert.assertTrue(atlasClient != null); Review comment: hive in test repl is set to true. It will return a No Op Client which will never be null. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 498364) Time Spent: 50m (was: 40m) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=498050=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498050 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Oct/20 13:31 Start Date: 09/Oct/20 13:31 Worklog Time Spent: 10m Work Description: pkumarsinha opened a new pull request #1563: URL: https://github.com/apache/hive/pull/1563 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 498050) Time Spent: 40m (was: 0.5h) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=497768=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497768 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Oct/20 05:50 Start Date: 09/Oct/20 05:50 Worklog Time Spent: 10m Work Description: pkumarsinha commented on a change in pull request #1563: URL: https://github.com/apache/hive/pull/1563#discussion_r502202414 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestAtlasDumpTask.java ## @@ -96,4 +105,13 @@ public void testAtlasDumpMetrics() throws Exception { Assert.assertTrue(eventDetailsCaptor .getAllValues().get(1).toString().contains("{\"dbName\":\"srcDB\",\"dumpEndTime\"")); } + + @Test + public void testAtlasRestClientBuilder() throws SemanticException, IOException { +mockStatic(UserGroupInformation.class); + when(UserGroupInformation.getLoginUser()).thenReturn(mock(UserGroupInformation.class)); +AtlasRestClientBuilder atlasRestCleintBuilder = new AtlasRestClientBuilder("http://localhost:31000;); +AtlasRestClient atlasClient = atlasRestCleintBuilder.getClient(conf); +Assert.assertTrue(atlasClient != null); Review comment: HiveConf is mocked, so hive in test is not present(so false). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 497768) Time Spent: 0.5h (was: 20m) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Labels: pull-request-available > Attachments: HIVE-24244.01.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=497732=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497732 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 09/Oct/20 03:22 Start Date: 09/Oct/20 03:22 Worklog Time Spent: 10m Work Description: aasha commented on a change in pull request #1563: URL: https://github.com/apache/hive/pull/1563#discussion_r502163365 ## File path: ql/src/test/org/apache/hadoop/hive/ql/exec/repl/TestAtlasDumpTask.java ## @@ -96,4 +105,13 @@ public void testAtlasDumpMetrics() throws Exception { Assert.assertTrue(eventDetailsCaptor .getAllValues().get(1).toString().contains("{\"dbName\":\"srcDB\",\"dumpEndTime\"")); } + + @Test + public void testAtlasRestClientBuilder() throws SemanticException, IOException { +mockStatic(UserGroupInformation.class); + when(UserGroupInformation.getLoginUser()).thenReturn(mock(UserGroupInformation.class)); +AtlasRestClientBuilder atlasRestCleintBuilder = new AtlasRestClientBuilder("http://localhost:31000;); +AtlasRestClient atlasClient = atlasRestCleintBuilder.getClient(conf); +Assert.assertTrue(atlasClient != null); Review comment: hive in test repl is set to true. It will return a No Op Client which will never be null. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 497732) Time Spent: 20m (was: 10m) > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Attachments: HIVE-24244.01.patch > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24244) NPE during Atlas metadata replication
[ https://issues.apache.org/jira/browse/HIVE-24244?focusedWorklogId=497561=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497561 ] ASF GitHub Bot logged work on HIVE-24244: - Author: ASF GitHub Bot Created on: 08/Oct/20 20:15 Start Date: 08/Oct/20 20:15 Worklog Time Spent: 10m Work Description: pkumarsinha opened a new pull request #1563: URL: https://github.com/apache/hive/pull/1563 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 497561) Remaining Estimate: 0h Time Spent: 10m > NPE during Atlas metadata replication > - > > Key: HIVE-24244 > URL: https://issues.apache.org/jira/browse/HIVE-24244 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Pravin Sinha >Assignee: Pravin Sinha >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)