[jira] [Work logged] (HIVE-25009) Compaction worker and initiator version check can cause NPE if the COMPACTION_QUEUE is empty

2021-04-19 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-25009?focusedWorklogId=584925=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584925
 ]

ASF GitHub Bot logged work on HIVE-25009:
-

Author: ASF GitHub Bot
Created on: 19/Apr/21 07:04
Start Date: 19/Apr/21 07:04
Worklog Time Spent: 10m 
  Work Description: deniskuzZ merged pull request #2175:
URL: https://github.com/apache/hive/pull/2175


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 584925)
Time Spent: 40m  (was: 0.5h)

> Compaction worker and initiator version check can cause NPE if the 
> COMPACTION_QUEUE is empty
> 
>
> Key: HIVE-25009
> URL: https://issues.apache.org/jira/browse/HIVE-25009
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0
>Reporter: Antal Sinkovits
>Assignee: Antal Sinkovits
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-25009) Compaction worker and initiator version check can cause NPE if the COMPACTION_QUEUE is empty

2021-04-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-25009?focusedWorklogId=582284=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582284
 ]

ASF GitHub Bot logged work on HIVE-25009:
-

Author: ASF GitHub Bot
Created on: 14/Apr/21 08:01
Start Date: 14/Apr/21 08:01
Worklog Time Spent: 10m 
  Work Description: asinkovits commented on a change in pull request #2175:
URL: https://github.com/apache/hive/pull/2175#discussion_r613025078



##
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##
@@ -390,7 +390,7 @@ protected Boolean findNextCompactionAndExecute(boolean 
computeStats) {
 }
   }
   ci = 
CompactionInfo.optionalCompactionInfoStructToInfo(msc.findNextCompact(workerName,
 runtimeVersion));
-  if ((runtimeVersion != null || ci.initiatorVersion != null) && 
!runtimeVersion.equals(ci.initiatorVersion)) {
+  if (ci != null && (runtimeVersion != null || ci.initiatorVersion != 
null) && !runtimeVersion.equals(ci.initiatorVersion)) {

Review comment:
   Sure, done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 582284)
Time Spent: 0.5h  (was: 20m)

> Compaction worker and initiator version check can cause NPE if the 
> COMPACTION_QUEUE is empty
> 
>
> Key: HIVE-25009
> URL: https://issues.apache.org/jira/browse/HIVE-25009
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0
>Reporter: Antal Sinkovits
>Assignee: Antal Sinkovits
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-25009) Compaction worker and initiator version check can cause NPE if the COMPACTION_QUEUE is empty

2021-04-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-25009?focusedWorklogId=582276=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582276
 ]

ASF GitHub Bot logged work on HIVE-25009:
-

Author: ASF GitHub Bot
Created on: 14/Apr/21 07:32
Start Date: 14/Apr/21 07:32
Worklog Time Spent: 10m 
  Work Description: deniskuzZ commented on a change in pull request #2175:
URL: https://github.com/apache/hive/pull/2175#discussion_r613005967



##
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##
@@ -390,7 +390,7 @@ protected Boolean findNextCompactionAndExecute(boolean 
computeStats) {
 }
   }
   ci = 
CompactionInfo.optionalCompactionInfoStructToInfo(msc.findNextCompact(workerName,
 runtimeVersion));
-  if ((runtimeVersion != null || ci.initiatorVersion != null) && 
!runtimeVersion.equals(ci.initiatorVersion)) {
+  if (ci != null && (runtimeVersion != null || ci.initiatorVersion != 
null) && !runtimeVersion.equals(ci.initiatorVersion)) {

Review comment:
   Hi Anti, I placed by mistake version check above the ci null check part, 
could you please move it below the null check:
   if (ci == null) {
   return false;
   }




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 582276)
Time Spent: 20m  (was: 10m)

> Compaction worker and initiator version check can cause NPE if the 
> COMPACTION_QUEUE is empty
> 
>
> Key: HIVE-25009
> URL: https://issues.apache.org/jira/browse/HIVE-25009
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0
>Reporter: Antal Sinkovits
>Assignee: Antal Sinkovits
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-25009) Compaction worker and initiator version check can cause NPE if the COMPACTION_QUEUE is empty

2021-04-13 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-25009?focusedWorklogId=581988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-581988
 ]

ASF GitHub Bot logged work on HIVE-25009:
-

Author: ASF GitHub Bot
Created on: 13/Apr/21 19:12
Start Date: 13/Apr/21 19:12
Worklog Time Spent: 10m 
  Work Description: asinkovits opened a new pull request #2175:
URL: https://github.com/apache/hive/pull/2175


   …PE if the COMPACTION_QUEUE is empty
   
   
   
   ### What changes were proposed in this pull request?
   
   Null check
   
   ### Why are the changes needed?
   
   Version check can cause NPE if the queue is empty.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Manual tests were conducted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 581988)
Remaining Estimate: 0h
Time Spent: 10m

> Compaction worker and initiator version check can cause NPE if the 
> COMPACTION_QUEUE is empty
> 
>
> Key: HIVE-25009
> URL: https://issues.apache.org/jira/browse/HIVE-25009
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Affects Versions: 4.0.0
>Reporter: Antal Sinkovits
>Assignee: Antal Sinkovits
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)