[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread amaya382
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 LGTM Notice: We also need revise `import-packages.spark` in [HIVEMALL-65]. @wangyum Can you do it? (or postpone to other PR) --- If your project is set up for it, you can reply to

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 [![Coverage Status](https://coveralls.io/builds/10119873/badge)](https://coveralls.io/builds/10119873) Coverage increased (+0.3%) to 36.112% when pulling

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 [![Coverage Status](https://coveralls.io/builds/10119873/badge)](https://coveralls.io/builds/10119873) Coverage increased (+0.3%) to 36.112% when pulling

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu , @myui I have sent an email to `d...@hivemall.incubator.apache.org`. have you received it ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu You can use Reflections. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 OK, `hivemall.smile.regression.RandomForestRegressionUDTF` create 2 functions. `define-all.spark` also add them?

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 I'm not sure whether these functions should add to `define-all.spark`: https://github.com/apache/incubator-hivemall/blob/master/resources/ddl/define-all.hive#L467-L483 --- If your

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread amaya382
Github user amaya382 commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 @maropu Sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] incubator-hivemall issue #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/44 [![Coverage Status](https://coveralls.io/builds/10115642/badge)](https://coveralls.io/builds/10115642) Coverage remained the same at 35.814% when pulling

[GitHub] incubator-hivemall pull request #44: [HIVEMALL-65] Update define-all.spark

2017-02-12 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/incubator-hivemall/pull/44 [HIVEMALL-65] Update define-all.spark ## What changes were proposed in this pull request? Make define-all.spark keep correspondence with define-all.hive. ## What type of