Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135693139
--- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java ---
@@ -18,118 +18,387 @@
*/
package hivemall.evaluation;
-im
Github user nzw0301 commented on the issue:
https://github.com/apache/incubator-hivemall/pull/107
But I found another issue for f1score and fmeasure.
Both function cannot work on `EMR v5.8.0`
```sql
hive> select f1score(array(1), array(1));
FAILED: IllegalArgum
Github user nzw0301 commented on the issue:
https://github.com/apache/incubator-hivemall/pull/107
I tested @takuti's query. The buggy code (previous code) returns `1.0`.
On the other hand, the fixed code return correct value`0.5`.
---
If your project is set up for it, you can rep
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/110
[](https://coveralls.io/builds/13016205)
Coverage increased (+0.5%) to 41.301% when pulling
**e230581d26c2a79
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135514455
--- Diff: core/src/main/java/hivemall/evaluation/F1ScoreUDAF.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user takuti commented on the issue:
https://github.com/apache/incubator-hivemall/pull/107
Importantly, in case that the number of mappers is 1, fixing the bug in
`merge()` does not change the output value; you might see the same result
`0.42483920860540153` even if the bug exis
Github user nzw0301 commented on the issue:
https://github.com/apache/incubator-hivemall/pull/107
I will check whether the return value is the same tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user coveralls commented on the issue:
https://github.com/apache/incubator-hivemall/pull/105
[](https://coveralls.io/builds/13013516)
Coverage decreased (-0.6%) to 40.215% when pulling
**dba8bf64e3a29ba
Github user nzw0301 commented on the issue:
https://github.com/apache/incubator-hivemall/pull/107
@takuti Thank you for comments!
I run query above, I get the same result on movielens-1M.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nzw0301 commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135471771
--- Diff: docs/gitbook/eval/binary_classification_measures.md ---
@@ -0,0 +1,261 @@
+
+
+
+
+# Binary problems
+
+Bina
Github user nzw0301 commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135464601
--- Diff: core/src/test/java/hivemall/evaluation/FMeasureUDAFTest.java ---
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Found
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/110#discussion_r135462565
--- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java ---
@@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/110#discussion_r135459734
--- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java ---
@@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/110#discussion_r135458769
--- Diff: core/src/main/java/hivemall/utils/lang/StringUtils.java ---
@@ -172,12 +172,17 @@ public static void clear(@Nonnull final StringBuilder
bu
GitHub user nzw0301 opened a pull request:
https://github.com/apache/incubator-hivemall/pull/111
[WIP][HIVEMALL-17] Support SLIM
## What changes were proposed in this pull request?
Add new UDTF: `train_slim`
## What type of PR is it?
Improvement
##
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135453504
--- Diff: core/src/main/java/hivemall/evaluation/F1ScoreUDAF.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135447663
--- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java ---
@@ -18,118 +18,387 @@
*/
package hivemall.evaluation;
-
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135450159
--- Diff: core/src/test/java/hivemall/evaluation/FMeasureUDAFTest.java ---
@@ -0,0 +1,393 @@
+/*
+ * Licensed to the Apache Software Founda
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135450892
--- Diff: docs/gitbook/eval/binary_classification_measures.md ---
@@ -0,0 +1,261 @@
+
+
+
+
+# Binary problems
+
+Binar
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135449892
--- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java ---
@@ -18,118 +18,387 @@
*/
package hivemall.evaluation;
-
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135454567
--- Diff: docs/gitbook/eval/binary_classification_measures.md ---
@@ -0,0 +1,261 @@
+
+
+
+
+# Binary problems
+
+Binar
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/107#discussion_r135449941
--- Diff: core/src/main/java/hivemall/evaluation/FMeasureUDAF.java ---
@@ -18,118 +18,387 @@
*/
package hivemall.evaluation;
-
22 matches
Mail list logo
