[GitHub] incubator-hivemall issue #111: [HIVEMALL-17] Support SLIM

2017-09-13 Thread nzw0301
Github user nzw0301 commented on the issue: https://github.com/apache/incubator-hivemall/pull/111 @myui done. ---

[GitHub] incubator-hivemall issue #111: [HIVEMALL-17] Support SLIM

2017-09-13 Thread nzw0301
Github user nzw0301 commented on the issue: https://github.com/apache/incubator-hivemall/pull/111 @myui ok, please give me a time. ---

[GitHub] incubator-hivemall issue #107: [HIVEMALL-132] Generalize f1score UDAF to sup...

2017-09-13 Thread nzw0301
Github user nzw0301 commented on the issue: https://github.com/apache/incubator-hivemall/pull/107 Thank you for your review and support @takuti @myui ---

[GitHub] incubator-hivemall issue #111: [HIVEMALL-17] Support SLIM

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/111 @nzw0301 could you rebase with the master branch? ---

[jira] [Closed] (HIVEMALL-132) Generalize f1score UDAF to support any Beta value

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-132. --- Resolution: Fixed Assignee: Makoto Yui > Generalize f1score UDAF to support any Beta value > -

[GitHub] incubator-hivemall issue #107: [HIVEMALL-132] Generalize f1score UDAF to sup...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/107 @nzw0301 LGTM 👍 Merged. Well done! (thank you for your review @takuti ) ---

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/107 ---

[GitHub] incubator-hivemall issue #107: [HIVEMALL-132] Generalize f1score UDAF to sup...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/107 @nzw0301 I'll fix and merge it. No need to update this PR. ---

[GitHub] incubator-hivemall pull request #107: [HIVEMALL-132] Generalize f1score UDAF...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/107#discussion_r138613348 --- Diff: docs/gitbook/eval/auc.md --- @@ -100,7 +100,7 @@ Note that `floor(prob / 0.2)` means that the rows are distributed to 5 bins for

[jira] [Closed] (HIVEMALL-142) Implement SingularizeUDF for English singular-ization

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-142. --- Resolution: Fixed > Implement SingularizeUDF for English singular-ization >

[GitHub] incubator-hivemall pull request #110: [HIVEMALL-142] Implement SingularizeUD...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/110 ---

[GitHub] incubator-hivemall issue #110: [HIVEMALL-142] Implement SingularizeUDF

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/110 👍 Merged. Thanks! ---

[GitHub] incubator-hivemall issue #114: [HIVEMALL-138-2] refactored to_ordered_map & ...

2017-09-13 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/114 [![Coverage Status](https://coveralls.io/builds/13251185/badge)](https://coveralls.io/builds/13251185) Coverage increased (+0.3%) to 40.536% when pulling **df39bd5c8254db0

[jira] [Closed] (HIVEMALL-140) Rename precision UDAF because it is reserved keyword of Hive

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-140. --- Resolution: Fixed > Rename precision UDAF because it is reserved keyword of Hive > -

[GitHub] incubator-hivemall pull request #109: [HIVEMALL-140] Rename PrecisionUDAF an...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/109 ---

[GitHub] incubator-hivemall issue #109: [HIVEMALL-140] Rename PrecisionUDAF and Recal...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/109 👍 Merged! Thanks. ---

[jira] [Closed] (HIVEMALL-136) Support train_classifier and train_regressor for Spark

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-136. --- Resolution: Fixed Assignee: Takeshi Yamamuro > Support train_classifier and train_regressor fo

[GitHub] incubator-hivemall pull request #113: [HIVEMALL-136][SPARK] Support train_cl...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/113 ---

[GitHub] incubator-hivemall issue #113: [HIVEMALL-136][SPARK] Support train_classifie...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/113 👍 Merged! ---

[jira] [Closed] (HIVEMALL-133) Support spark-v2.2 in the hivemalls-spark module

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-133. --- Resolution: Fixed Assignee: Takeshi Yamamuro > Support spark-v2.2 in the hivemalls-spark modul

[GitHub] incubator-hivemall issue #112: [HIVEMALL-133][SPARK] Support spark-v2.2 in t...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/112 👍 Merged! ---

[GitHub] incubator-hivemall pull request #112: [HIVEMALL-133][SPARK] Support spark-v2...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/112 ---

[jira] [Closed] (HIVEMALL-138) Implement to_top_k_ordered_map

2017-09-13 Thread Makoto Yui (JIRA)
[ https://issues.apache.org/jira/browse/HIVEMALL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Makoto Yui closed HIVEMALL-138. --- Resolution: Fixed > Implement to_top_k_ordered_map > -- > >

[GitHub] incubator-hivemall issue #108: [HIVEMALL-138] `to_ordered_map` & `to_ordered...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/108 Merged. Thanks! ---

[GitHub] incubator-hivemall issue #114: [HIVEMALL-138-2] refactored to_ordered_map & ...

2017-09-13 Thread myui
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/114 @takuti reverted some changes by me and merged. ---

[GitHub] incubator-hivemall pull request #114: [HIVEMALL-138-2] refactored to_ordered...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/114 ---

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-hivemall/pull/108 ---

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/108#discussion_r138026120 --- Diff: core/src/main/java/hivemall/tools/list/UDAFToOrderedList.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/108#discussion_r138024907 --- Diff: core/src/main/java/hivemall/tools/list/UDAFToOrderedList.java --- @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/108#discussion_r138024379 --- Diff: core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java --- @@ -54,19 +68,35 @@ public GenericUDAFEvaluator getEvaluator(GenericUDAFPa

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/108#discussion_r138585976 --- Diff: core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java --- @@ -92,4 +122,172 @@ public void reset(@SuppressWarnings("deprecation") Ag

[GitHub] incubator-hivemall pull request #108: [HIVEMALL-138] `to_ordered_map` & `to_...

2017-09-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/108#discussion_r138586028 --- Diff: core/src/main/java/hivemall/tools/map/UDAFToOrderedMap.java --- @@ -92,4 +122,172 @@ public void reset(@SuppressWarnings("deprecation") Ag