[GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...

[myui]

Github user myui commented on a diff in the pull request:

https://github.com/apache/incubator-hivemall/pull/146#discussion_r182315386
  
--- Diff: core/src/main/java/hivemall/smile/tools/TreeExportUDF.java ---
@@ -141,17 +141,17 @@ public String getDisplayString(String[] children) {
 }
 
 public enum OutputType {
-javascript, graphvis;
+javascript, graphviz;
 
 @Nonnull
 public static OutputType resolve(@Nonnull String name) throws 
UDFArgumentException {
 if ("js".equalsIgnoreCase(name) || 
"javascript".equalsIgnoreCase(name)) {
 return javascript;
-} else if ("dot".equalsIgnoreCase(name) || 
"graphvis".equalsIgnoreCase(name)) {
-return graphvis;
+} else if ("dot".equalsIgnoreCase(name) || 
"graphviz".equalsIgnoreCase(name)) {
--- End diff --

`if("dot".equalsIgnoreCase(name) || "graphviz".equalsIgnoreCase(name) || 
"graphvis".equalsIgnoreCase(name))`


---

[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

[myui]

Github user myui commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
Sure. 


---

[GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...

[myui]

Github user myui commented on a diff in the pull request:

https://github.com/apache/incubator-hivemall/pull/146#discussion_r182308352
  
--- Diff: core/src/main/java/hivemall/smile/tools/TreeExportUDF.java ---
@@ -141,17 +141,17 @@ public String getDisplayString(String[] children) {
 }
 
 public enum OutputType {
-javascript, graphvis;
+javascript, graphviz;
 
 @Nonnull
 public static OutputType resolve(@Nonnull String name) throws 
UDFArgumentException {
 if ("js".equalsIgnoreCase(name) || 
"javascript".equalsIgnoreCase(name)) {
 return javascript;
-} else if ("dot".equalsIgnoreCase(name) || 
"graphvis".equalsIgnoreCase(name)) {
-return graphvis;
+} else if ("dot".equalsIgnoreCase(name) || 
"graphviz".equalsIgnoreCase(name)) {
--- End diff --

better to have `"graphvis".equalsIgnoreCase(name)` for backward 
compatibility.


---

[GitHub] incubator-hivemall pull request #146: [HIVEMALL-192] Fix typos: graphvis -> ...

[takuti]

GitHub user takuti opened a pull request:

https://github.com/apache/incubator-hivemall/pull/146

[HIVEMALL-192] Fix typos: graphvis -> graphviz

## What changes were proposed in this pull request?

Fix crucial typos.

## What type of PR is it?

Improvement

## What is the Jira issue?

https://issues.apache.org/jira/browse/HIVEMALL-192

## Checklist

- [x] Did you apply source code formatter, i.e., `mvn formatter:format`, 
for your commit?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/takuti/incubator-hivemall HIVEMALL-192

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hivemall/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #146


commit 0fb943df9fcc45295ac35c7ab35978e43dbfd4e3
Author: Takuya Kitazawa 
Date:   2018-04-18T04:40:26Z

Fix typos: graphvis -> graphviz




---

[GitHub] incubator-hivemall issue #145: [HIVEMALL-191] Add Kryo serialization test to...

[takuti]

Github user takuti commented on the issue:

https://github.com/apache/incubator-hivemall/pull/145
  
Added serialization test case to all existing GenericUDF/UDTF tests. 
Vanilla UDF and UDAF tests are not changed.

@myui Could you review?


---