[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233324312 --- Diff: spark/spark-2.3/src/test/scala/org/apache/spark/sql/hive/XGBoostSuite.scala --- @@ -77,6 +77,7 @@ final class XGBoostSuite extends

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233288446 --- Diff: spark/spark-2.3/src/main/scala/org/apache/spark/sql/hive/HivemallOps.scala --- @@ -1935,18 +1935,6 @@ object HivemallOps { )

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233288186 --- Diff: spark/pom.xml --- @@ -52,6 +52,12 @@ hivemall-core ${project.version}

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233287740 --- Diff: spark/spark-2.3/src/main/scala/org/apache/spark/sql/hive/HivemallOps.scala --- @@ -1935,18 +1935,6 @@ object HivemallOps { )

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread myui
Github user myui commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233287092 --- Diff: spark/spark-2.3/src/test/scala/org/apache/spark/sql/hive/XGBoostSuite.scala --- @@ -77,6 +77,7 @@ final class XGBoostSuite extends

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233262624 --- Diff: spark/spark-2.3/src/test/scala/org/apache/spark/sql/hive/XGBoostSuite.scala --- @@ -77,6 +77,7 @@ final class XGBoostSuite extends

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233262036 --- Diff: spark/spark-2.3/src/main/scala/org/apache/spark/sql/hive/HivemallOps.scala --- @@ -1935,18 +1935,6 @@ object HivemallOps { )

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/incubator-hivemall/pull/171#discussion_r233261637 --- Diff: spark/pom.xml --- @@ -52,6 +52,12 @@ hivemall-core ${project.version}

[GitHub] incubator-hivemall pull request #171: [SPARK][HOTFIX][WIP] Fix existing test...

2018-11-13 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/incubator-hivemall/pull/171 [SPARK][HOTFIX][WIP] Fix existing test failures in spark-2.3 ## What changes were proposed in this pull request? This pr is to fix the test failures for spark-2.3. ## How was