Github user amaya382 closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/80
---
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r118157439
--- Diff: Makefile ---
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117690004
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
Github user amaya382 commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117666401
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665985
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-#
Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665868
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
Github user amaya382 commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665318
--- Diff: xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java ---
@@ -54,15 +55,47 @@ private static boolean hasResource(String path) {
Github user amaya382 commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117665209
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117657316
--- Diff: xgboost/src/main/java/hivemall/xgboost/NativeLibLoader.java ---
@@ -54,15 +55,47 @@ private static boolean hasResource(String path) {
Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/80#discussion_r117657090
--- Diff: bin/build_xgboost.sh ---
@@ -1,87 +0,0 @@
-#!/bin/bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
GitHub user amaya382 opened a pull request:
https://github.com/apache/incubator-hivemall/pull/80
[WIP][HIVEMALL-99] Cross-compilation of XGBoost using Docker
## What changes were proposed in this pull request?
Cross compiling xgboost using dockcross
## What type of
11 matches
Mail list logo
