Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125930040
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +270,35 @@ public void checkTargetValue(double target) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125849451
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +274,33 @@ public void checkTargetValue(double target) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125847385
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +270,35 @@ public void checkTargetValue(double target) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125845977
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +274,33 @@ public void checkTargetValue(double target) throws
Github user maropu commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125845972
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -326,7 +320,7 @@ public void close() throws HiveException {
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125842906
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +274,33 @@ public void checkTargetValue(double target) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125843584
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -269,44 +274,33 @@ public void checkTargetValue(double target) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/95#discussion_r125842738
--- Diff: xgboost/src/main/java/hivemall/xgboost/XGBoostUDTF.java ---
@@ -326,7 +320,7 @@ public void close() throws HiveException {