Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127503646
--- Diff: core/src/main/java/hivemall/utils/io/IOUtils.java ---
@@ -129,6 +131,29 @@ public static int readInt(final InputStream in) throws
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127502672
--- Diff: core/src/main/java/hivemall/utils/io/IOUtils.java ---
@@ -129,6 +131,29 @@ public static int readInt(final InputStream in) throws
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127405819
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127400022
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127399732
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127398164
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127376244
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127376160
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127379925
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127215023
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127153439
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127153097
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127152887
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127132018
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127135811
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127134755
--- Diff: core/src/main/java/hivemall/utils/io/LimitedInputStream.java ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127132855
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127132865
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,86 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127128427
--- Diff: core/src/main/java/hivemall/utils/io/BoundedInputStream.java ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127122389
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127122181
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127121613
--- Diff: core/src/main/java/hivemall/utils/io/BoundedInputStream.java ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127117125
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -215,7 +215,7 @@ private static UserDictionary userDictionary(@Nullable
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r127012955
--- Diff: core/src/main/java/hivemall/utils/io/BoundedInputStream.java ---
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126868321
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126868602
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126860711
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126858366
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126858262
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126852235
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126846757
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126846871
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126846200
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126839049
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -44,47 +53,52 @@
import
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126839586
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126841323
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126841692
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126839282
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -170,6 +192,100 @@ private static CharArraySet stopWords(@Nonnull final
Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126841175
--- Diff: core/src/main/java/hivemall/utils/io/HttpUtils.java ---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126635120
--- Diff: nlp/src/test/java/hivemall/nlp/tokenizer/KuromojiUDFTest.java ---
@@ -192,6 +241,126 @@ public void prepare(int arg) throws HiveException
Github user takuti commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/97#discussion_r126622639
--- Diff: nlp/src/main/java/hivemall/nlp/tokenizer/KuromojiUDF.java ---
@@ -239,6 +239,16 @@ private static UserDictionary userDictionary(@Nullable
GitHub user takuti opened a pull request:
https://github.com/apache/incubator-hivemall/pull/97
[HIVEMALL-130] Support user-defined dictionary for `tokenize_ja`
## What changes were proposed in this pull request?
- Add a new argument to `tokenize_ja` which enables users to
43 matches
Mail list logo
