jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313221838
##
File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java
##
@@ -105,6 +105,16 @@ public
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313221766
##
File path:
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
##
@@ -125,13 +132,26 @@
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313221698
##
File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
##
@@ -19,15 +19,44 @@
package
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313221613
##
File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java
##
@@ -19,15 +19,44 @@
package
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313220700
##
File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java
##
@@ -134,13 +135,13 @@ public
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313220319
##
File path:
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
##
@@ -125,13 +132,26 @@
jun-he commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313220240
##
File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java
##
@@ -105,6 +105,16 @@ public
xabriel opened a new pull request #372: Allow read split behavior overrides
URL: https://github.com/apache/incubator-iceberg/pull/372
Iceberg exposes the following read path properties as of today:
`read.split.target-size`
`read.split.planning-lookback`
xabriel opened a new pull request #371: Fix reading of old .metadata.json.gz
files
URL: https://github.com/apache/incubator-iceberg/pull/371
Reading of iceberg tables with metadata files like `v1.metadata.json.gz`
broke after #258.
Example stack trace:
```
rdblue commented on issue #356: Add LICENSE and NOTICE to publication artifacts
URL: https://github.com/apache/incubator-iceberg/pull/356#issuecomment-520580982
Thanks, @cwsteinbach! I'll try it out.
This is an automated
cwsteinbach commented on issue #356: Add LICENSE and NOTICE to publication
artifacts
URL: https://github.com/apache/incubator-iceberg/pull/356#issuecomment-520578847
@rdblue looks like someone created a Gradle wrapper for Apache RAT (release
audit tool):
rdblue commented on issue #366: Concurrent appends to the same table using
HiveCatalog lead to deadlock in the Metastore
URL:
https://github.com/apache/incubator-iceberg/issues/366#issuecomment-520567171
I'm not sure this is a deadlock. It might be that the concurrent appends
keep
rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313093437
##
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##
@@ -89,11 +91,11 @@
rdblue commented on a change in pull request #357: Add in and not in predicates
URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313093251
##
File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java
##
@@ -134,13 +135,13 @@ public
rdblue commented on issue #279: Transforming timestamp to date should produce
date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-520563552
@manishmalhotrawork, only the `day` transform should return a date. Years,
months, and hours should continue returning
manishmalhotrawork commented on issue #279: Transforming timestamp to date
should produce date
URL:
https://github.com/apache/incubator-iceberg/issues/279#issuecomment-520561870
@rdblue if Im not missing, in this case
`org.apache.iceberg.transforms.Timestamps` will implement
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313089366
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -63,32 +69,39
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313089097
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -270,6
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313087471
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -270,6
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313087581
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -270,6
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313085518
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -153,6
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313085232
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -63,32 +69,39
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313085232
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -63,32 +69,39
rdblue commented on a change in pull request #365: test cases for
parquetMetrics with multiple rowgroup
URL: https://github.com/apache/incubator-iceberg/pull/365#discussion_r313085232
##
File path: core/src/test/java/org/apache/iceberg/TestMetrics.java
##
@@ -63,32 +69,39
rdblue closed pull request #75: Add startsWith predicate
URL: https://github.com/apache/incubator-iceberg/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
rdblue commented on issue #75: Add startsWith predicate
URL: https://github.com/apache/incubator-iceberg/pull/75#issuecomment-520552879
Merged as part of #327. Thanks for working on this, @renato2099!
This is an automated
sujithjay commented on a change in pull request #327: Introduce startsWith
Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#discussion_r313074893
##
File path:
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java
##
@@ -120,6 +124,9
rdblue closed issue #58: Add LICENSE and NOTICE to binary artifacts
URL: https://github.com/apache/incubator-iceberg/issues/58
This is an automated message from the Apache Git Service.
To respond to the message, please log
rdblue merged pull request #356: Add LICENSE and NOTICE to publication artifacts
URL: https://github.com/apache/incubator-iceberg/pull/356
This is an automated message from the Apache Git Service.
To respond to the message,
rdblue commented on issue #356: Add LICENSE and NOTICE to publication artifacts
URL: https://github.com/apache/incubator-iceberg/pull/356#issuecomment-520534773
I'm going to go ahead and merge this. If more reviews find anything, I can
open follow-up issues.
Thanks for reviewing,
rdblue merged pull request #369: Return full stats for added files from Snapshot
URL: https://github.com/apache/incubator-iceberg/pull/369
This is an automated message from the Apache Git Service.
To respond to the message,
rdblue commented on issue #327: Introduce startsWith Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#issuecomment-520534201
@sujithjay, I just found 2 minor issues and I'll merge this after those are
fixed. Thanks for pushing this feature through!
rdblue commented on a change in pull request #327: Introduce startsWith
Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#discussion_r313056266
##
File path: api/src/test/java/org/apache/iceberg/transforms/TestStartsWith.java
##
@@ -0,0 +1,99 @@
+/*
+ *
moulimukherjee commented on issue #327: Introduce startsWith Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#issuecomment-520529929
Changes look good to me
This is an automated message from the Apache
aokolnychyi commented on issue #351: Extend Iceberg with a way to overwrite
files for eager updates/deletes
URL: https://github.com/apache/incubator-iceberg/pull/351#issuecomment-520398959
@rdblue @johnclara ready for another review round
aokolnychyi commented on issue #369: Return full stats for added files from
Snapshot
URL: https://github.com/apache/incubator-iceberg/pull/369#issuecomment-520397771
This change will also enable more fine-grained conflict resolution in #351
sujithjay commented on issue #327: Introduce startsWith Predicate
URL: https://github.com/apache/incubator-iceberg/pull/327#issuecomment-520333989
@rdblue, @moulimukherjee I have updated the PR. Please review.
This is an
37 matches
Mail list logo
