[GitHub] [incubator-iceberg] aokolnychyi commented on issue #398: Push down StringStartsWith in Spark IcebergSource

2019-08-21 Thread GitBox
aokolnychyi commented on issue #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#issuecomment-523698632 @sujithjay @rdblue @moulimukherjee I would appreciate your input on this.

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

2019-08-21 Thread GitBox
aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r316453652 ## File path: api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource

2019-08-21 Thread GitBox
aokolnychyi commented on a change in pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398#discussion_r316452823 ## File path:

[GitHub] [incubator-iceberg] aokolnychyi opened a new pull request #398: Push down StringStartsWith in Spark IcebergSource

2019-08-21 Thread GitBox
aokolnychyi opened a new pull request #398: Push down StringStartsWith in Spark IcebergSource URL: https://github.com/apache/incubator-iceberg/pull/398 This PR adds support for pushdown of `StringStartsWith` predicates in Spark and resolves #397.

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #380: Rename some implementations for consistency

2019-08-21 Thread GitBox
aokolnychyi commented on issue #380: Rename some implementations for consistency URL: https://github.com/apache/incubator-iceberg/pull/380#issuecomment-523687886 Sounds good to me! This is an automated message from the Apache

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-21 Thread GitBox
aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-523686687 I'll follow up with a PR then

[GitHub] [incubator-iceberg] rdblue commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-21 Thread GitBox
rdblue commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-523686330 Sounds like a blocker to me.

[GitHub] [incubator-iceberg] rdblue commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-21 Thread GitBox
rdblue commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-523686279 Yeah, definitely. Good catch.

[GitHub] [incubator-iceberg] aokolnychyi edited a comment on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-21 Thread GitBox
aokolnychyi edited a comment on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-523684134 @rdblue @rdsr what do you guys think about having some time between check

[GitHub] [incubator-iceberg] aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore

2019-08-21 Thread GitBox
aokolnychyi commented on issue #366: Concurrent appends to the same table using HiveCatalog lead to deadlock in the Metastore URL: https://github.com/apache/incubator-iceberg/issues/366#issuecomment-523684134 @rdblue @rdsr what do you guys think about adding a timeout between check lock

[GitHub] [incubator-iceberg] rdblue commented on issue #380: Rename some implementations for consistency

2019-08-21 Thread GitBox
rdblue commented on issue #380: Rename some implementations for consistency URL: https://github.com/apache/incubator-iceberg/pull/380#issuecomment-523660836 If you don't mind, I'd like to get some of the other PRs that touch these files in first, since this could cause conflicts and it

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-21 Thread GitBox
rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r316267556 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-21 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r316228984 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog

2019-08-21 Thread GitBox
aokolnychyi commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r316210566 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java