Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX merged PR #585: URL: https://github.com/apache/iceberg-python/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on PR #585: URL: https://github.com/apache/iceberg-python/pull/585#issuecomment-2042016912 @Fokko Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

Fokko commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1555301526 ## mkdocs/docs/configuration.md: ## @@ -232,6 +232,18 @@ catalog: s3.secret-access-key: password ``` +In case of Hive 2.x: + +```yaml +catalog: + default:

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

Fokko commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1555301526 ## mkdocs/docs/configuration.md: ## @@ -232,6 +232,18 @@ catalog: s3.secret-access-key: password ``` +In case of Hive 2.x: + +```yaml +catalog: + default:

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

Fokko commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1555048186 ## pyiceberg/catalog/hive.py: ## @@ -199,6 +184,7 @@ def _annotate_namespace(database: HiveDatabase, properties: Properties) -> HiveD DateType: "date",

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554855296 ## pyiceberg/catalog/hive.py: ## @@ -199,6 +184,7 @@ def _annotate_namespace(database: HiveDatabase, properties: Properties) -> HiveD DateType: "date",

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

Fokko commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554715441 ## pyiceberg/catalog/hive.py: ## @@ -199,6 +184,7 @@ def _annotate_namespace(database: HiveDatabase, properties: Properties) -> HiveD DateType: "date",

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554526443 ## pyiceberg/catalog/hive.py: ## @@ -103,22 +104,6 @@ import pyarrow as pa -# Replace by visitor -hive_types = { Review Comment: This is not used so I

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554526443 ## pyiceberg/catalog/hive.py: ## @@ -103,22 +104,6 @@ import pyarrow as pa -# Replace by visitor -hive_types = { Review Comment: This is not used so I

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554526443 ## pyiceberg/catalog/hive.py: ## @@ -103,22 +104,6 @@ import pyarrow as pa -# Replace by visitor -hive_types = { Review Comment: This is not used so I

Re: [PR] [Bug Fix] Allow HiveCatalog to create table with TimestamptzType [iceberg-python]

HonahX commented on code in PR #585: URL: https://github.com/apache/iceberg-python/pull/585#discussion_r1554524560 ## pyiceberg/catalog/hive.py: ## @@ -199,6 +184,7 @@ def _annotate_namespace(database: HiveDatabase, properties: Properties) -> HiveD DateType: "date",