Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

liurenjie1024 merged PR #317: URL: https://github.com/apache/iceberg-rust/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#issuecomment-2041050879 @liurenjie1024 I've added a test as well now for build_accessors :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

liurenjie1024 commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554560769 ## crates/iceberg/src/spec/schema.rs: ## @@ -137,9 +142,55 @@ impl SchemaBuilder { name_to_id, lowercase_name_to_id, id_

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554542369 ## crates/iceberg/src/spec/schema.rs: ## @@ -137,9 +142,55 @@ impl SchemaBuilder { name_to_id, lowercase_name_to_id, id_to_name, +

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554540831 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554540767 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

liurenjie1024 commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554520971 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554425354 ## crates/iceberg/src/spec/schema.rs: ## @@ -137,9 +142,55 @@ impl SchemaBuilder { name_to_id, lowercase_name_to_id, id_to_name, +

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554175122 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554176015 ## crates/iceberg/src/spec/schema.rs: ## @@ -137,9 +142,55 @@ impl SchemaBuilder { name_to_id, lowercase_name_to_id, id_to_name, +

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554174651 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554171392 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554163204 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1554161905 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

marvinlanhenke commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1553285045 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

liurenjie1024 commented on code in PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#discussion_r1553151792 ## crates/iceberg/src/expr/accessor.rs: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agr

Re: [PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd commented on PR #317: URL: https://github.com/apache/iceberg-rust/pull/317#issuecomment-2038350682 PTAL @liurenjie1024 and @marvinlanhenke - extracted from https://github.com/apache/iceberg-rust/pull/241 and added tests -- This is an automated message from the Apache Git Service. To r

[PR] Add Struct Accessors to BoundReferences [iceberg-rust]

sdd opened a new pull request, #317: URL: https://github.com/apache/iceberg-rust/pull/317 First PR to come out of breaking up https://github.com/apache/iceberg-rust/pull/241. Adds `StructAccessor`, which is added to `BoundReference` as a means of retrieving a field's value from a (po