Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-04-05 Thread via GitHub
nastra merged PR #9952: URL: https://github.com/apache/iceberg/pull/9952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-04-05 Thread via GitHub
nastra commented on PR #9952: URL: https://github.com/apache/iceberg/pull/9952#issuecomment-2040195604 thanks for the review @amogh-jahagirdar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-04-05 Thread via GitHub
amogh-jahagirdar commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1553791769 ## core/src/main/java/org/apache/iceberg/rest/responses/ConfigResponseParser.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-03-14 Thread via GitHub
nastra commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1524575987 ## core/src/main/java/org/apache/iceberg/util/JsonUtil.java: ## @@ -206,6 +207,25 @@ public static Map getStringMap(String property, JsonNode node) { return builde

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-03-14 Thread via GitHub
nastra commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1524575323 ## core/src/main/java/org/apache/iceberg/rest/responses/ConfigResponseParser.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-03-14 Thread via GitHub
nastra commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1524572981 ## core/src/main/java/org/apache/iceberg/rest/responses/ConfigResponseParser.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-03-14 Thread via GitHub
nastra commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1524566946 ## core/src/main/java/org/apache/iceberg/rest/responses/ConfigResponseParser.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Core: Add explicit JSON parser for ConfigResponse [iceberg]

2024-03-14 Thread via GitHub
nk1506 commented on code in PR #9952: URL: https://github.com/apache/iceberg/pull/9952#discussion_r1524402880 ## core/src/main/java/org/apache/iceberg/rest/responses/ConfigResponseParser.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one