Re: [PR] Spark: Hive-View Integration Tests [iceberg]

2024-04-05 Thread via GitHub
nk1506 commented on code in PR #10088: URL: https://github.com/apache/iceberg/pull/10088#discussion_r1553075946 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1421,38 +1442,38 @@ public void showViews() throws

Re: [PR] Spark: Hive-View Integration Tests [iceberg]

2024-04-05 Thread via GitHub
nk1506 commented on code in PR #10088: URL: https://github.com/apache/iceberg/pull/10088#discussion_r1553073692 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1341,10 +1355,17 @@ public void

Re: [PR] Spark: Hive-View Integration Tests [iceberg]

2024-04-05 Thread via GitHub
nk1506 commented on code in PR #10088: URL: https://github.com/apache/iceberg/pull/10088#discussion_r1553073213 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -1318,8 +1324,16 @@ public void

Re: [PR] Spark: Hive-View Integration Tests [iceberg]

2024-04-05 Thread via GitHub
nk1506 commented on code in PR #10088: URL: https://github.com/apache/iceberg/pull/10088#discussion_r1553071451 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -900,7 +906,7 @@ public void dropV1View() { String v1View

Re: [PR] Spark: Hive-View Integration Tests [iceberg]

2024-04-05 Thread via GitHub
nk1506 commented on code in PR #10088: URL: https://github.com/apache/iceberg/pull/10088#discussion_r1553067799 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -62,6 +64,9 @@ public class TestViews extends