Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2332507514 ## src/iceberg/arrow_array_reader.h: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#issuecomment-3269517939 Close this PR in favor of https://github.com/apache/iceberg-cpp/pull/214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac closed pull request #200: feat: Introduce ArrowArrayReader factory on FileScanTask URL: https://github.com/apache/iceberg-cpp/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2320579815 ## src/iceberg/table_scan.cc: ## @@ -45,6 +43,21 @@ int32_t FileScanTask::files_count() const { return 1; } int64_t FileScanTask::estimated_row_count() const { retu

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

zeroshade commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2320224671 ## src/iceberg/arrow_array_reader.h: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreemen

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2313130243 ## test/file_scan_task_test.cc: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. Se

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2315587583 ## src/iceberg/table_scan.h: ## @@ -185,4 +169,40 @@ class ICEBERG_EXPORT DataTableScan : public TableScan { Result>> PlanFiles() const override; }; +/// \brief

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2315589964 ## test/CMakeLists.txt: ## @@ -122,5 +122,6 @@ if(ICEBERG_BUILD_BUNDLE) SOURCES parquet_data_test.cc parque

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2315581021 ## test/parquet_test.cc: ## @@ -28,7 +28,7 @@ #include #include "iceberg/arrow/arrow_fs_file_io_internal.h" -#include "iceberg/parquet/parquet_reader.h" +#include

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

wgtmac commented on PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#issuecomment-3244656361 > @wgtmac I've updated the code to address the feedback from the review. Thanks! Have you pushed your changes? I don't see any change since last review. -- This is an automated

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

HeartLinked commented on PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#issuecomment-3243643676 @wgtmac I've updated the code to address the feedback from the review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

HeartLinked commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2309613724 ## src/iceberg/arrow_array_reader.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreem

Re: [PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

mapleFU commented on code in PR #200: URL: https://github.com/apache/iceberg-cpp/pull/200#discussion_r2309473889 ## src/iceberg/arrow_array_reader.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements

[PR] feat: Introduce ArrowArrayReader factory on FileScanTask [iceberg-cpp]

HeartLinked opened a new pull request, #200: URL: https://github.com/apache/iceberg-cpp/pull/200 - Introduced `ArrowArrayReader` Interface: Added a new abstract interface, `ArrowArrayReader`, to represent a stream of Arrow data. This provides a unified interface for all file format readers.