[GitHub] [incubator-iceberg] moulimukherjee commented on issue #470: WIP: Not throw exception if table is not found

moulimukherjee commented on issue #470: WIP: Not throw exception if table is not found URL: https://github.com/apache/incubator-iceberg/pull/470#issuecomment-530572102 I see a test failing, so am guessing the behaviour's expected. How should the `doRefresh` behave then?

[GitHub] [incubator-iceberg] bsannicolas opened a new pull request #469: Add key_metadata to DataTableScan SCAN_COLUMNS

bsannicolas opened a new pull request #469: Add key_metadata to DataTableScan SCAN_COLUMNS URL: https://github.com/apache/incubator-iceberg/pull/469 This ensures the key_metadata field is populated when manifest files are read. Otherwise the EncryptionManager will receive an empty

[GitHub] [incubator-iceberg] xabriel commented on a change in pull request #432: Allow writers to control size of files generated

xabriel commented on a change in pull request #432: Allow writers to control size of files generated URL: https://github.com/apache/incubator-iceberg/pull/432#discussion_r323429579 ## File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java ## @@ -303,66

[GitHub] [incubator-iceberg] moulimukherjee opened a new pull request #470: WIP: Not throw exception if table is not found

moulimukherjee opened a new pull request #470: WIP: Not throw exception if table is not found URL: https://github.com/apache/incubator-iceberg/pull/470 The call stack from create table looks like the following ```at

[GitHub] [incubator-iceberg] wangmiao1981 commented on a change in pull request #462: Added V1 Vectorized Reader

wangmiao1981 commented on a change in pull request #462: Added V1 Vectorized Reader URL: https://github.com/apache/incubator-iceberg/pull/462#discussion_r323475022 ## File path: gradle/wrapper/gradle-wrapper.properties ## @@ -1,22 +1,21 @@ # -# Licensed to the Apache

[GitHub] [incubator-iceberg] bsannicolas commented on issue #451: Encryption not working

bsannicolas commented on issue #451: Encryption not working URL: https://github.com/apache/incubator-iceberg/issues/451#issuecomment-530580614 @rdblue https://github.com/apache/incubator-iceberg/pull/469 This is an automated

[GitHub] [incubator-iceberg] rdblue commented on issue #461: Add a unit test for testing import as hive table for importSparkTable

rdblue commented on issue #461: Add a unit test for testing import as hive table for importSparkTable URL: https://github.com/apache/incubator-iceberg/pull/461#issuecomment-530614319 @aokolnychyi, do you want to merge this?

[GitHub] [incubator-iceberg] rdblue commented on issue #465: Make the static factory methods of the MappedField and MappedFields c…

rdblue commented on issue #465: Make the static factory methods of the MappedField and MappedFields c… URL: https://github.com/apache/incubator-iceberg/pull/465#issuecomment-530614557 +1 Thanks for adding this, @puneetzaroo!

[GitHub] [incubator-iceberg] rdblue merged pull request #465: Make the static factory methods of the MappedField and MappedFields c…

rdblue merged pull request #465: Make the static factory methods of the MappedField and MappedFields c… URL: https://github.com/apache/incubator-iceberg/pull/465 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-iceberg] rdblue merged pull request #469: Add key_metadata to DataTableScan SCAN_COLUMNS

rdblue merged pull request #469: Add key_metadata to DataTableScan SCAN_COLUMNS URL: https://github.com/apache/incubator-iceberg/pull/469 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iceberg] rdblue closed issue #451: Encryption not working

rdblue closed issue #451: Encryption not working URL: https://github.com/apache/incubator-iceberg/issues/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-iceberg] rdblue commented on issue #451: Encryption not working

rdblue commented on issue #451: Encryption not working URL: https://github.com/apache/incubator-iceberg/issues/451#issuecomment-530616373 Fixed by #469. Thanks, @bsannicolas! This is an automated message from the Apache Git

[GitHub] [incubator-iceberg] rdblue commented on issue #469: Add key_metadata to DataTableScan SCAN_COLUMNS

rdblue commented on issue #469: Add key_metadata to DataTableScan SCAN_COLUMNS URL: https://github.com/apache/incubator-iceberg/pull/469#issuecomment-530616309 +1 Thanks for fixing this, @bsannicolas! This is an

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #468: Enable build without .git directory

rdblue commented on a change in pull request #468: Enable build without .git directory URL: https://github.com/apache/incubator-iceberg/pull/468#discussion_r323514194 ## File path: build.gradle ## @@ -458,3 +458,22 @@ project(':iceberg-spark-runtime') { } } +String

[GitHub] [incubator-iceberg] Parth-Brahmbhatt opened a new issue #471: Create table as select operations fails with current transaction implementation.

Parth-Brahmbhatt opened a new issue #471: Create table as select operations fails with current transaction implementation. URL: https://github.com/apache/incubator-iceberg/issues/471 Currently if we try to create a table and append files to it in the same transaction with HiveCatalog it

[GitHub] [incubator-iceberg] rdblue commented on issue #472: Bugfix in BaseTransaction to allow create and append in the same tran…

rdblue commented on issue #472: Bugfix in BaseTransaction to allow create and append in the same tran… URL: https://github.com/apache/incubator-iceberg/pull/472#issuecomment-530616679 Looks good to me. @aokolnychyi, can you review this as well?

[GitHub] [incubator-iceberg] Parth-Brahmbhatt opened a new pull request #472: Bugfix in BaseTransaction to allow create and append in the same tran…

Parth-Brahmbhatt opened a new pull request #472: Bugfix in BaseTransaction to allow create and append in the same tran… URL: https://github.com/apache/incubator-iceberg/pull/472 …saction. This resolves [Issue-441](https://github.com/apache/incubator-iceberg/issues/471)

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #468: Enable build without .git directory

rdblue commented on a change in pull request #468: Enable build without .git directory URL: https://github.com/apache/incubator-iceberg/pull/468#discussion_r323514029 ## File path: build.gradle ## @@ -458,3 +458,22 @@ project(':iceberg-spark-runtime') { } } +String

[GitHub] [incubator-iceberg] waterlx commented on a change in pull request #447: Update doc to state that day partition transform produces data type

waterlx commented on a change in pull request #447: Update doc to state that day partition transform produces data type URL: https://github.com/apache/incubator-iceberg/pull/447#discussion_r323520066 ## File path: site/docs/spec.md ## @@ -139,7 +139,7 @@ Partition specs

[GitHub] [incubator-iceberg] rdsr commented on issue #227: ORC column map fix

rdsr commented on issue #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#issuecomment-530422464 @edgarRd . I plan to go through the PR this week. Thanks! This is an automated message from the