[GitHub] [incubator-iceberg] waterlx closed issue #479: Conversions#fromPartitionString() does not support DateType

2019-09-18 Thread GitBox
waterlx closed issue #479: Conversions#fromPartitionString() does not support DateType URL: https://github.com/apache/incubator-iceberg/issues/479 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] waterlx commented on issue #479: Conversions#fromPartitionString() does not support DateType

2019-09-18 Thread GitBox
waterlx commented on issue #479: Conversions#fromPartitionString() does not support DateType URL: https://github.com/apache/incubator-iceberg/issues/479#issuecomment-532543324 > @waterlx is it the same as [this issue](https://github.com/apache/incubator-iceberg/issues/428)?

[GitHub] [incubator-iceberg] waterlx edited a comment on issue #479: Conversions#fromPartitionString() does not support DateType

2019-09-18 Thread GitBox
waterlx edited a comment on issue #479: Conversions#fromPartitionString() does not support DateType URL: https://github.com/apache/incubator-iceberg/issues/479#issuecomment-532543324 > @waterlx is it the same as [this issue](https://github.com/apache/incubator-iceberg/issues/428)?

[GitHub] [incubator-iceberg] waterlx commented on issue #483: Conversions#fromPartitionString() could not convert String of timestamp-like format to Integer

2019-09-18 Thread GitBox
waterlx commented on issue #483: Conversions#fromPartitionString() could not convert String of timestamp-like format to Integer URL: https://github.com/apache/incubator-iceberg/issues/483#issuecomment-532560192 @aokolnychyi @rdblue does it make any sense to you?

[GitHub] [incubator-iceberg] waterlx opened a new issue #483: Conversions#fromPartitionString() could not convert String of date-like type to Integer

2019-09-18 Thread GitBox
waterlx opened a new issue #483: Conversions#fromPartitionString() could not convert String of date-like type to Integer URL: https://github.com/apache/incubator-iceberg/issues/483 Suppose that I have a partition spec using day transform, like: ```scala val partitionSpec =

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325781215 ## File path: site/docs/spec.md ## @@ -489,7 +489,7 @@ Lists must use the [3-level

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325778497 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java ## @@ -56,13 +57,16 @@ this.config = config;

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325788874 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325783707 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325779811 ## File path: orc/src/main/java/org/apache/iceberg/orc/OrcIterable.java ## @@ -56,13 +57,16 @@ this.config = config;

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325782736 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325800082 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325796388 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325798219 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #227: ORC column map fix

2019-09-18 Thread GitBox
rdsr commented on a change in pull request #227: ORC column map fix URL: https://github.com/apache/incubator-iceberg/pull/227#discussion_r325784282 ## File path: orc/src/main/java/org/apache/iceberg/orc/ORCSchemaUtil.java ## @@ -0,0 +1,412 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iceberg] rdblue commented on issue #483: Conversions#fromPartitionString() could not convert String of timestamp-like format to Integer

2019-09-18 Thread GitBox
rdblue commented on issue #483: Conversions#fromPartitionString() could not convert String of timestamp-like format to Integer URL: https://github.com/apache/incubator-iceberg/issues/483#issuecomment-532773879 @waterlx, `withPartitionPath` is only public to support importing existing

[GitHub] [incubator-iceberg] sujithjay commented on issue #485: Refactor AssertHelpers and TestHelpers to Reduce Code Duplication

2019-09-18 Thread GitBox
sujithjay commented on issue #485: Refactor AssertHelpers and TestHelpers to Reduce Code Duplication URL: https://github.com/apache/incubator-iceberg/pull/485#issuecomment-532885445 Tests fail on CI, they but seem unrelated to the changes. FWIW, the tests pass on my machine. ```

[GitHub] [incubator-iceberg] sujithjay edited a comment on issue #485: Refactor AssertHelpers and TestHelpers to Reduce Code Duplication

2019-09-18 Thread GitBox
sujithjay edited a comment on issue #485: Refactor AssertHelpers and TestHelpers to Reduce Code Duplication URL: https://github.com/apache/incubator-iceberg/pull/485#issuecomment-532885445 Tests fail on CI, but they seem unrelated to the changes. FWIW, the tests pass on my machine.

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #468: Enable build without .git directory

2019-09-18 Thread GitBox
rdblue commented on a change in pull request #468: Enable build without .git directory URL: https://github.com/apache/incubator-iceberg/pull/468#discussion_r325873864 ## File path: build.gradle ## @@ -458,3 +458,22 @@ project(':iceberg-spark-runtime') { } } +String

[GitHub] [incubator-iceberg] jerryshao edited a comment on issue #430: Support bucket table for Iceberg

2019-09-18 Thread GitBox
jerryshao edited a comment on issue #430: Support bucket table for Iceberg URL: https://github.com/apache/incubator-iceberg/issues/430#issuecomment-532943540 I'm roughly dividing this issue into 3 ongoing PRs: 1. Add Bucket Spec support in Iceberg API and metadata. 2. Support

[GitHub] [incubator-iceberg] jerryshao commented on issue #430: Support bucket table for Iceberg

2019-09-18 Thread GitBox
jerryshao commented on issue #430: Support bucket table for Iceberg URL: https://github.com/apache/incubator-iceberg/issues/430#issuecomment-532943540 I'm roughly dividing this issue into 3 ongoing PRs: 1. Add Bucket Spec support in Iceberg API and metadata. 2. Support bucketing