[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-10 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r246999702 ## File path:

[GitHub] mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name

2019-01-10 Thread GitBox
mccheah commented on a change in pull request #73: Allow data output streams to be generated via custom mechanisms when given partitioning and file name URL: https://github.com/apache/incubator-iceberg/pull/73#discussion_r246999840 ## File path:

[GitHub] rdblue commented on issue #72: Fix filtering manifests in unpartitioned tables.

2019-01-10 Thread GitBox
rdblue commented on issue #72: Fix filtering manifests in unpartitioned tables. URL: https://github.com/apache/incubator-iceberg/pull/72#issuecomment-453297507 @aokolnychyi, this is a fix for the issue you pointed out. Could you please review? Thank you!

[GitHub] rdblue opened a new pull request #70: Allow schema updates in transactions.

2019-01-10 Thread GitBox
rdblue opened a new pull request #70: Allow schema updates in transactions. URL: https://github.com/apache/incubator-iceberg/pull/70 This is safe because schema updates can always read older data. If a transaction includes a write followed by a schema update, the new schema can read

[GitHub] rdblue opened a new pull request #71: Allow passing the unpartitioned spec to DataFiles.builder.

2019-01-10 Thread GitBox
rdblue opened a new pull request #71: Allow passing the unpartitioned spec to DataFiles.builder. URL: https://github.com/apache/incubator-iceberg/pull/71 This makes converting tables with SparkTableUtil easier. This is an

[GitHub] rdblue opened a new pull request #72: Fix filtering manifests in unpartitioned tables.

2019-01-10 Thread GitBox
rdblue opened a new pull request #72: Fix filtering manifests in unpartitioned tables. URL: https://github.com/apache/incubator-iceberg/pull/72 FilteredManifest only ran filters if there was a row filter AND a partition filter, but it should run filteres if there is a row filter OR a