rdblue commented on issue #142: Update Tasks to retry at least once, log
timeouts.
URL: https://github.com/apache/incubator-iceberg/pull/142#issuecomment-479580563
Thanks for reviewing, @xiao-chen and @rdsr!
This is an
rdblue merged pull request #142: Update Tasks to retry at least once, log
timeouts.
URL: https://github.com/apache/incubator-iceberg/pull/142
This is an automated message from the Apache Git Service.
To respond to the
rdblue commented on a change in pull request #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147#discussion_r271847788
##
File path: api/src/main/java/org/apache/iceberg/types/Type.java
##
@@ -112,10 +114,11
rdblue commented on issue #143: Applies the Baseline plugin for iceberg-api
only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-479556902
I think from the discussion here that there is consensus for these changes.
There are still some open issues around IDE
rdblue merged pull request #143: Applies the Baseline plugin for iceberg-api
only.
URL: https://github.com/apache/incubator-iceberg/pull/143
This is an automated message from the Apache Git Service.
To respond to the
rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272000252
##
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##
@@ -53,8 +54,18 @@
rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272015504
##
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##
@@ -119,17 +119,19 @@
rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272002686
##
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##
@@ -53,8 +54,18 @@
rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272002686
##
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##
@@ -53,8 +54,18 @@
rdsr commented on a change in pull request #148: Turn urls into links in
community.md
URL: https://github.com/apache/incubator-iceberg/pull/148#discussion_r272206979
##
File path: site/docs/community.md
##
@@ -36,13 +36,14 @@ Issues are tracked in GitHub:
###
rdsr commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272015504
##
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##
@@ -119,17 +119,19 @@
rdblue commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272253665
##
File path: core/src/main/java/org/apache/iceberg/ManifestGroup.java
##
@@ -119,17 +119,19 @@
rdblue merged pull request #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147
This is an automated message from the Apache Git Service.
To respond to the
rdblue commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272257093
##
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##
@@ -53,8 +54,18 @@
rdblue commented on a change in pull request #150: Close open manifests during
scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#discussion_r272259289
##
File path: api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
##
@@ -53,8 +54,18 @@
rdblue commented on issue #150: Close open manifests during scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150#issuecomment-479965518
@rdsr, the approach here is for usability. `CloseableIterable` can be used
in a try-with-resources block because it keeps track of
rdblue commented on issue #108: Use the current schema in all partition specs
in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108#issuecomment-479968471
Merged. Thanks for reviewing, @fbocse, @rdsr, and @jzhuge!
rdblue merged pull request #108: Use the current schema in all partition specs
in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108
This is an automated message from the Apache Git Service.
To respond
rdblue commented on issue #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147#issuecomment-479967934
Merged. Thanks for contributing this, @lys0716!
This is an
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271094529
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##
@@ -454,15 +459,32
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271094659
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java
##
@@ -24,6 +24,35 @@
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271095142
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##
@@ -443,8 +448,8 @@
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271096547
##
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestOrcScan.java
##
@@ -0,0 +1,126
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r271097014
##
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestOrcScan.java
##
@@ -0,0 +1,126
rdblue commented on issue #139: ORC support integration for Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#issuecomment-478795482
@edgarRd, thanks for working on this! Overall, I think it looks like a great
start toward ORC support, but I'd like to add ORC support
rdsr commented on issue #134: Adding Drop and Rename APIs to Tables interface.
URL: https://github.com/apache/incubator-iceberg/pull/134#issuecomment-480124578
+1 for the Catalog API.
This could help support implementing [some part of] HMS api and could help
provide an Iceberg Catalog
rdblue commented on issue #134: Adding Drop and Rename APIs to Tables interface.
URL: https://github.com/apache/incubator-iceberg/pull/134#issuecomment-480086875
I'm not sure if it is a good idea to add these or not. The `Tables` API was
never properly thought through and I think it shows
rdblue commented on a change in pull request #148: Turn urls into links in
community.md
URL: https://github.com/apache/incubator-iceberg/pull/148#discussion_r272390725
##
File path: site/docs/community.md
##
@@ -36,13 +36,14 @@ Issues are tracked in GitHub:
###
rdblue merged pull request #149: Add override annotation for test classes
URL: https://github.com/apache/incubator-iceberg/pull/149
This is an automated message from the Apache Git Service.
To respond to the message, please
rdblue commented on issue #149: Add override annotation for test classes
URL: https://github.com/apache/incubator-iceberg/pull/149#issuecomment-480085485
Merged. Thanks @jzhuge!
This is an automated message from the Apache
dbtsai edited a comment on issue #136: Collect lower/upper bounds for nested
struct fields in ParquetMetrics
URL: https://github.com/apache/incubator-iceberg/pull/136#issuecomment-480154720
FYI, @prodeezy I restart the work of
https://github.com/apache/spark/pull/22573 and I will try to
dbtsai commented on issue #136: Collect lower/upper bounds for nested struct
fields in ParquetMetrics
URL: https://github.com/apache/incubator-iceberg/pull/136#issuecomment-480154720
FYI, @prodeezy I restart the work of
https://github.com/apache/spark/pull/22573
jzhuge commented on a change in pull request #148: Turn urls into links in
community.md
URL: https://github.com/apache/incubator-iceberg/pull/148#discussion_r272462659
##
File path: site/docs/community.md
##
@@ -36,13 +36,14 @@ Issues are tracked in GitHub:
###
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272658713
##
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272661035
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272661196
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272660868
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272658906
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272659615
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272656864
##
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272659688
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272659801
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue merged pull request #148: Turn urls into links in community.md
URL: https://github.com/apache/incubator-iceberg/pull/148
This is an automated message from the Apache Git Service.
To respond to the message, please log
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272661519
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue merged pull request #150: Close open manifests during scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/150
This is an automated message from the Apache Git Service.
To respond to the message,
edgarRd commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r272768900
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Reader.java
##
@@ -454,15 +459,32
edgarRd commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r272768964
##
File path: spark/src/main/java/org/apache/iceberg/spark/source/Writer.java
##
@@ -24,6 +24,35 @@
edgarRd commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r272768781
##
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestOrcScan.java
##
@@ -0,0 +1,126
jzhuge commented on a change in pull request #148: Turn urls into links in
community.md
URL: https://github.com/apache/incubator-iceberg/pull/148#discussion_r272288276
##
File path: site/docs/community.md
##
@@ -36,13 +36,14 @@ Issues are tracked in GitHub:
###
xiao-chen commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272313082
##
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##
jzhuge commented on a change in pull request #148: Turn urls into links in
community.md
URL: https://github.com/apache/incubator-iceberg/pull/148#discussion_r272287516
##
File path: site/docs/community.md
##
@@ -36,13 +36,14 @@ Issues are tracked in GitHub:
###
jzhuge opened a new pull request #148: Turn urls into links in community.md
URL: https://github.com/apache/incubator-iceberg/pull/148
This is an automated message from the Apache Git Service.
To respond to the message,
lys0716 closed pull request #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147
This is an automated message from the Apache Git Service.
To respond to the
lys0716 opened a new pull request #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147
Add override annotations for HadoopTableOperations
Signed-off-by: Yishuang Lu
jzhuge edited a comment on issue #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147#issuecomment-478210417
Nice find!
Running IntelliJ inspection `Missing \@Override annotation` revealed 35 such
errors in 11 production
jzhuge commented on issue #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147#issuecomment-478210417
Running IntelliJ inspection `Missing \@Override annotation` revealed 35 such
errors in 11 production files and 10 test files,
aokolnychyi commented on issue #146: Fix binary partition values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146#issuecomment-477557723
@rdblue could you, please, give an example when you experienced this issue?
Will it be easy to add a test for it?
aokolnychyi commented on a change in pull request #135: Use big-endian byte
order for UUIDs in Conversions
URL: https://github.com/apache/incubator-iceberg/pull/135#discussion_r269941987
##
File path: api/src/main/java/org/apache/iceberg/types/Conversions.java
##
@@
aokolnychyi commented on issue #114: Modify PackingIterator to return the
biggest bin
URL:
https://github.com/apache/incubator-iceberg/issues/114#issuecomment-477549471
@rominparekh sorry, I was away for a few days. Thanks for working on this!
aokolnychyi closed issue #114: Modify PackingIterator to return the biggest bin
URL: https://github.com/apache/incubator-iceberg/issues/114
This is an automated message from the Apache Git Service.
To respond to the message,
aokolnychyi commented on a change in pull request #143: Applies the Baseline
plugin for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r269898109
##
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##
@@ -313,8
rdblue commented on issue #146: Fix binary partition values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146#issuecomment-477655965
I do need to add a test for this. It should be fairly easy. Any binary value
used in an identity partition field will hit this when ready
lys0716 opened a new pull request #147: Add override annotations for
HadoopTableOperations
URL: https://github.com/apache/incubator-iceberg/pull/147
Add override annotations for HadoopTableOperations
Signed-off-by: Yishuang Lu
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270934222
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270934222
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270934756
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
edgarRd commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270978665
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270990264
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
edgarRd commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270978665
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
rdblue commented on a change in pull request #139: ORC support integration for
Spark 2.4.0
URL: https://github.com/apache/incubator-iceberg/pull/139#discussion_r270993148
##
File path:
spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcReader.java
##
@@ -0,0
rdblue commented on issue #141: Add case insensitive support to Parquet.
URL: https://github.com/apache/incubator-iceberg/pull/141#issuecomment-480631648
@xabriel, can you take another look? I've fixed the problem you found and
validated there are tests that actually exercise case
rdblue commented on issue #146: Fix binary partition values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146#issuecomment-480631734
@aokolnychyi, I've updated this with a test to verify all Spark data types
can be used as partition fields. Could you take another look to
aokolnychyi commented on a change in pull request #146: Fix binary partition
values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146#discussion_r272908128
##
File path:
spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java
##
@@
xiao-chen commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272885777
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
xiao-chen commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272885580
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
xiao-chen commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r272886448
##
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##
xiao-chen commented on issue #144: Delete temporary metadata file when rename
fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#issuecomment-480682747
Thank you for the detailed review, @rdblue !
Addressed all comments except 1 (listing directly), commented above.
aokolnychyi commented on issue #105: Basic Benchmarks for Iceberg Spark Data
Source
URL: https://github.com/apache/incubator-iceberg/pull/105#issuecomment-480856258
Thanks for your feedback, @danielcweeks!
I think one of the most important questions is how we want to use such
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r273128073
##
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r273128286
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on a change in pull request #144: Delete temporary metadata
file when rename fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#discussion_r273129600
##
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java
##
@@
rdblue commented on issue #144: Delete temporary metadata file when rename
fails.
URL: https://github.com/apache/incubator-iceberg/pull/144#issuecomment-480900588
Thanks @xiao-chen! This is almost ready. Just a couple of minor changes and
I'll merge it.
rdblue merged pull request #146: Fix binary partition values in Spark.
URL: https://github.com/apache/incubator-iceberg/pull/146
This is an automated message from the Apache Git Service.
To respond to the message, please log
prodeezy commented on a change in pull request #123: Add support for struct
field based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#discussion_r268752271
##
File path:
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
##
@@
rdblue commented on a change in pull request #108: Use the current schema in
all partition specs in scan planning.
URL: https://github.com/apache/incubator-iceberg/pull/108#discussion_r268796538
##
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##
@@
rdblue commented on issue #123: Add support for struct field based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#issuecomment-476326143
@prodeezy, `IcebergGenerics` is a way to read a table directly and will use
`Evaluator` to filter records. Just make sure that
rdblue commented on a change in pull request #123: Add support for struct field
based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#discussion_r268751705
##
File path:
api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
##
@@
mccheah commented on issue #143: Applies the Baseline plugin for iceberg-api
only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476370423
> Looks like Baseline will indeed give us ./gradlew idea and ./gradlew
eclipse to import the guidelines to IDEs:
mccheah edited a comment on issue #143: Applies the Baseline plugin for
iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476370423
> Looks like Baseline will indeed give us ./gradlew idea and ./gradlew
eclipse to import the guidelines to IDEs:
rdblue commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268809698
##
File path: api/src/test/java/org/apache/iceberg/transforms/TestProjection.java
##
@@
rdblue commented on issue #143: Applies the Baseline plugin for iceberg-api
only.
URL: https://github.com/apache/incubator-iceberg/pull/143#issuecomment-476340278
Overall, the commit looks good to me. Everyone else okay with it?
Should we also have a `STYLE.md` file somewhere that
xabriel commented on issue #83: Make Iceberg support case insensitivity
URL:
https://github.com/apache/incubator-iceberg/issues/83#issuecomment-476364310
There's another issue with `Filterable`s described in #145 .
This is
prodeezy commented on issue #123: Add support for struct field based filtering
URL: https://github.com/apache/incubator-iceberg/pull/123#issuecomment-476980781
@rdblue Thanks for taking a detailed look! I think i'v addressed the review
comments and added pending tests.
aokolnychyi commented on issue #105: Basic Benchmarks for Iceberg Spark Data
Source
URL: https://github.com/apache/incubator-iceberg/pull/105#issuecomment-464885490
@rdblue @mccheah @danielcweeks Initially, I created these benchmarks to
answer a few questions I had. Let's see if they make
rdblue merged pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
rdblue commented on a change in pull request #85: Encryption APIs for Iceberg.
URL: https://github.com/apache/incubator-iceberg/pull/85#discussion_r257834213
##
File path: api/src/main/java/com/netflix/iceberg/DataFile.java
##
@@ -19,6 +19,7 @@
package
rdblue opened a new pull request #106: Deep copy maps and lists in
GenericDataFile.
URL: https://github.com/apache/incubator-iceberg/pull/106
GenericDataFile.copy should copy maps and lists. Because containers are
reused while reading, not copying inner lists and maps causes instances in
rdblue commented on a change in pull request #75: Add startsWith predicate
URL: https://github.com/apache/incubator-iceberg/pull/75#discussion_r257840052
##
File path: api/src/main/java/com/netflix/iceberg/transforms/Bucket.java
##
@@ -114,6 +114,9 @@ public String
aokolnychyi commented on a change in pull request #111: Split files when
planning scan tasks
URL: https://github.com/apache/incubator-iceberg/pull/111#discussion_r259981082
##
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##
@@ -231,4 +234,69 @@
aokolnychyi commented on a change in pull request #111: Split files when
planning scan tasks
URL: https://github.com/apache/incubator-iceberg/pull/111#discussion_r259980347
##
File path: core/src/main/java/com/netflix/iceberg/BaseTableScan.java
##
@@ -208,8 +211,8 @@
201 - 300 of 84672 matches
Mail list logo
