[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #1046: ISSUE-189: Add support for union record type

2020-05-26 Thread GitBox
rdsr commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r430588847 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -526,25 +526,25 @@ public static StructType of(List fields) {

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #1046: ISSUE-189: Add support for union record type

2020-05-21 Thread GitBox
rdsr commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428681937 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -641,6 +650,13 @@ public int hashCode() { } return

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #1046: ISSUE-189: Add support for union record type

2020-05-21 Thread GitBox
rdsr commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428681937 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -641,6 +650,13 @@ public int hashCode() { } return

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #1046: ISSUE-189: Add support for union record type

2020-05-21 Thread GitBox
rdsr commented on a change in pull request #1046: URL: https://github.com/apache/incubator-iceberg/pull/1046#discussion_r428681937 ## File path: api/src/main/java/org/apache/iceberg/types/Types.java ## @@ -641,6 +650,13 @@ public int hashCode() { } return