rdblue commented on issue #93: [MINOR] Throw an exception early if there is no dict available instead of handling dictionary-encoded pages for absent dict URL: https://github.com/apache/incubator-iceberg/pull/93#issuecomment-534786457 Looks good to me. If `dict` returned null, further uses would fail with a null pointer exception. So this should be safe.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
