[GitHub] [incubator-iceberg] yujiantao commented on a change in pull request #743: [spark-3] Bump Apache spark to 3.0.0-preview2

2020-02-02 Thread GitBox 
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache 
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897701
 
 

 ##
 File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestForwardCompatibility.java
 ##
 @@ -125,7 +126,7 @@ public void testSparkWriteFailsUnknownTransform() throws 
IOException {
   }
 
   @Test
-  public void testSparkStreamingWriteFailsUnknownTransform() throws 
IOException {
+  public void testSparkStreamingWriteFailsUnknownTransform() throws 
IOException, TimeoutException {
 
 Review comment:
   Ok.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

[GitHub] [incubator-iceberg] yujiantao commented on a change in pull request #743: [spark-3] Bump Apache spark to 3.0.0-preview2

2020-02-02 Thread GitBox 
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache 
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897760
 
 

 ##
 File path: spark/src/test/java/org/apache/iceberg/spark/source/TestTables.java
 ##
 @@ -37,7 +37,7 @@
 import org.apache.iceberg.io.InputFile;
 import org.apache.iceberg.io.LocationProvider;
 import org.apache.iceberg.io.OutputFile;
-import parquet.Preconditions;
+import org.apache.parquet.Preconditions;
 
 Review comment:
   Yes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

[GitHub] [incubator-iceberg] yujiantao commented on a change in pull request #743: [spark-3] Bump Apache spark to 3.0.0-preview2

2020-02-02 Thread GitBox 
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache 
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373897701
 
 

 ##
 File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestForwardCompatibility.java
 ##
 @@ -125,7 +126,7 @@ public void testSparkWriteFailsUnknownTransform() throws 
IOException {
   }
 
   @Test
-  public void testSparkStreamingWriteFailsUnknownTransform() throws 
IOException {
+  public void testSparkStreamingWriteFailsUnknownTransform() throws 
IOException, TimeoutException {
 
 Review comment:
   Ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

[GitHub] [incubator-iceberg] yujiantao commented on a change in pull request #743: [spark-3] Bump Apache spark to 3.0.0-preview2

2020-02-02 Thread GitBox 
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache 
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373827428
 
 

 ##
 File path: 
spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchWrite.java
 ##
 @@ -493,6 +494,9 @@ protected void setCurrentKey(PartitionKey currentKey) {
 public void write(InternalRow row) throws IOException {
   writeInternal(row);
 }
+
+@Override
+public void close() {}
 
 Review comment:
   I will add this comment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

[GitHub] [incubator-iceberg] yujiantao commented on a change in pull request #743: [spark-3] Bump Apache spark to 3.0.0-preview2

2020-02-02 Thread GitBox 
yujiantao commented on a change in pull request #743: [spark-3] Bump Apache 
spark to 3.0.0-preview2
URL: https://github.com/apache/incubator-iceberg/pull/743#discussion_r373827417
 
 

 ##
 File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreaming.java
 ##
 @@ -79,7 +80,7 @@ public static void stopSpark() {
   }
 
   @Test
-  public void testStreamingWriteAppendMode() throws IOException {
+  public void testStreamingWriteAppendMode() throws IOException, 
TimeoutException {
 
 Review comment:
   Yes, throwing "Exception" is better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org