[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-29 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-458456989 It seems the config params that were moved to `metastore-site.xml` are needed only for Hive ACID tables. If that's the case, we can simply remo

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-19 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-455763677 Actually, we need to revert this change. I was too quick with my analysis. I missed the point that the config passed to `ObjectStore$setC

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454875861 I'll give it a try and let you know This is an automated message from the Apac

[GitHub] aokolnychyi commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
aokolnychyi commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454865665 @Parth-Brahmbhatt @rdblue could you take a look at this change? Please, correct me if I missed something during my analysis. -