[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-28 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-458350747 I don't know why tests are still passing, but I'm reluctant to change anything back unless it is a problem.

[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454874604 We can follow up with a PR to get rid of script runner if that works. For now, let's get this fix committed. Thanks @aokolnychyi!

[GitHub] rdblue commented on issue #79: Fix propagation of Hive configs

2019-01-16 Thread GitBox
rdblue commented on issue #79: Fix propagation of Hive configs URL: https://github.com/apache/incubator-iceberg/pull/79#issuecomment-454869104 @Parth-Brahmbhatt, regarding `datanucleus.schema.autoCreateAll`, can we change how the test is structured so that we don't have to load the DB