[ https://issues.apache.org/jira/browse/IGNITE-12892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248845#comment-17248845 ]
shivakumar edited comment on IGNITE-12892 at 12/14/20, 9:46 AM: ---------------------------------------------------------------- Is this code change part of 2.9.1 release ? As per my testing looks like this code change solves the blocking issue reported here [http://apache-ignite-users.70518.x6.nabble.com/Could-not-clear-historyMap-due-to-WAL-reservation-on-cp-td34779.html] [http://apache-ignite-users.70518.x6.nabble.com/connecting-to-visor-shell-permanently-stops-unwanted-WAL-clean-up-td34737.html] If it is not part of 2.9.1 then is it possible to backport to 2.9.0 easily ? Or it has dependency on other code changes? was (Author: shm): Is this code change part of 2.9.1 release ? As pery testing looks like this code change solves the blocking issue reported here [http://apache-ignite-users.70518.x6.nabble.com/Could-not-clear-historyMap-due-to-WAL-reservation-on-cp-td34779.html] [http://apache-ignite-users.70518.x6.nabble.com/connecting-to-visor-shell-permanently-stops-unwanted-WAL-clean-up-td34737.html] > Clarify WAL archive size configuration > -------------------------------------- > > Key: IGNITE-12892 > URL: https://issues.apache.org/jira/browse/IGNITE-12892 > Project: Ignite > Issue Type: Sub-task > Reporter: Semyon Danilov > Assignee: Semyon Danilov > Priority: Major > Fix For: 2.10 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Actual maximum size of WAL archive that can be reserved for historical > rebalance is calculated as minimum of three properties: > # DataStorageConfiguration#walHistSize (units: number of checkpoints) > # DataStorageConfiguration#maxWalArchiveSize (units: bytes) > # IgniteSystemProperties#IGNITE_PDS_MAX_CHECKPOINT_MEMORY_HISTORY_SIZE > (units: number of checkpoints) > The logic is a little unclear, so I propose following changes: > # Stop using walHistSize at all (it's already deprecated) for WAL truncation > # Use IGNITE_PDS_MAX_CHECKPOINT_MEMORY_HISTORY_SIZE only in case WAL archive > is managed externally (so we limit the quantity of checkpoints stored in > memory, but don't remove WAL files) > # Use -1 for maxWalArchiveSize (instead of Long.MAX_VALUE) to disable WAL > truncation -- This message was sent by Atlassian Jira (v8.3.4#803005)