[ 
https://issues.apache.org/jira/browse/IGNITE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012526#comment-16012526
 ] 

Semen Boikov edited comment on IGNITE-4496 at 5/16/17 3:01 PM:
---------------------------------------------------------------

Hi Alexandr,

When I do diff with master it shows that there are lots of files where there 
are no changes except line separators, can you fix this? (e.g. 
AffinityKey.java).

Also diff shows empty files added: GridCacheSwapEntryImpl.java, 
OdbcQueryExecuteRequest.java.

GridCacheStoreManagerAdapter: why key is not sensitive here:
{noformat}
                log.debug(S.toString("Loaded value from store",
                    "key", key, false,
                    "val", val, true));
{noformat}

Thanks


was (Author: sboikov):
Hi Alexandr,

When I do diff master it shows that lots of files where there are no changes 
except line separators, can you fix this? (e.g. AffinityKey.java).

Also diff shows empty files added: GridCacheSwapEntryImpl.java, 
OdbcQueryExecuteRequest.java.

GridCacheStoreManagerAdapter: why key is not sensitive here:
{noformat}
                log.debug(S.toString("Loaded value from store",
                    "key", key, false,
                    "val", val, true));
{noformat}

Thanks

> Review all logging for sensitive data leak
> ------------------------------------------
>
>                 Key: IGNITE-4496
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4496
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexandr Kuramshin
>            Assignee: Alexandr Kuramshin
>
> While sensitive logging option added and toString() methods fixed, not all 
> logging was checked for sensitive data leak



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to