[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994916#comment-16994916
]
Alexey Goncharuk commented on IGNITE-12412:
---
Done, the visa is acquired on a separate
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994915#comment-16994915
]
Ignite TC Bot commented on IGNITE-12412:
{panel:title=Branch: [pull/7098/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991821#comment-16991821
]
Ivan Rakov commented on IGNITE-12412:
-
[~agoncharuk] Looks good.
Please split your patch into two
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991671#comment-16991671
]
Andrey N. Gura commented on IGNITE-12412:
-
[~agoncharuk] Thanks! LGTM.
> Incomplete check for
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16991611#comment-16991611
]
Alexey Goncharuk commented on IGNITE-12412:
---
[~agura] fixed (I changed the suggestion for
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987804#comment-16987804
]
Andrey N. Gura commented on IGNITE-12412:
-
@[~agoncharuk] I left a few comments to the PR.
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987683#comment-16987683
]
Alexey Goncharuk commented on IGNITE-12412:
---
[~agura], please take a look as well.
>
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987098#comment-16987098
]
Ignite TC Bot commented on IGNITE-12412:
{panel:title=Branch: [pull/7098/head] Base: [master] :
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986887#comment-16986887
]
Alexey Goncharuk commented on IGNITE-12412:
---
[~akalashnikov] [~irakov] folks, I appreciate if
[
https://issues.apache.org/jira/browse/IGNITE-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986209#comment-16986209
]
Alexey Goncharuk commented on IGNITE-12412:
---
The test alongside with a small refactoring
10 matches
Mail list logo