[ 
https://issues.apache.org/jira/browse/IGNITE-21841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835694#comment-17835694
 ] 

Roman Puchkovskiy commented on IGNITE-21841:
--------------------------------------------

The patch looks good to me

> The FilePageStoreManager constructor should not throw an exception
> ------------------------------------------------------------------
>
>                 Key: IGNITE-21841
>                 URL: https://issues.apache.org/jira/browse/IGNITE-21841
>             Project: Ignite
>          Issue Type: Improvement
>          Components: persistence
>    Affects Versions: 3.0.0-beta2
>            Reporter: Andrey Novikov
>            Assignee: Andrey Novikov
>            Priority: Major
>              Labels: ignite-3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current implementation of FilePageStoreManager is throw an exception from 
> constructor, which is not recommended.
> Let's create FilePageStoreFactory from the outside and pass it to the 
> constructor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to