[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547888#comment-16547888
]
ASF GitHub Bot commented on IGNITE-2313:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533578#comment-16533578
]
Ryabov Dmitrii commented on IGNITE-2313:
[~agoncharuk], I made improvement suggested by Anton
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527498#comment-16527498
]
ASF GitHub Bot commented on IGNITE-2313:
GitHub user SomeFire opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527361#comment-16527361
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire],
What about to make some patch to
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526526#comment-16526526
]
Ryabov Dmitrii commented on IGNITE-2313:
[~agoncharuk], it throws exception only inside
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526494#comment-16526494
]
Alexey Goncharuk commented on IGNITE-2313:
--
[~SomeFire], apparently, the change does not work -
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523866#comment-16523866
]
Dmitriy Pavlov commented on IGNITE-2313:
[~SomeFire], thank you :) Looking forward to your new
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523798#comment-16523798
]
Ryabov Dmitrii commented on IGNITE-2313:
[~dpavlov], thank you.
> Need to add a mode to fail
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523755#comment-16523755
]
ASF GitHub Bot commented on IGNITE-2313:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523647#comment-16523647
]
Anton Vinogradov commented on IGNITE-2313:
--
[~dpavlov],
No, because this code created to
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523645#comment-16523645
]
Ryabov Dmitrii commented on IGNITE-2313:
[~dpavlov], I think we don't need it, because in 3.0 we
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523626#comment-16523626
]
Dmitriy Pavlov commented on IGNITE-2313:
[~SomeFire], ok, why we need method allow() and we
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523619#comment-16523619
]
Ryabov Dmitrii commented on IGNITE-2313:
[~dpavlov], yes, you are right. Most of users will
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523604#comment-16523604
]
Dmitriy Pavlov commented on IGNITE-2313:
[~agoncharuk], [~SomeFire], I've checked code and it is
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523553#comment-16523553
]
Dmitriy Pavlov commented on IGNITE-2313:
I've checked tests, only one failure is suspicious,
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523515#comment-16523515
]
Alexey Goncharuk commented on IGNITE-2313:
--
Looks good to me, will merge shortly
> Need to add
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515601#comment-16515601
]
Ryabov Dmitrii commented on IGNITE-2313:
I changed defaults to allow atomic operations, but in
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511263#comment-16511263
]
Alexey Goncharuk commented on IGNITE-2313:
--
[~SomeFire], unfortunately, the fix did not make in
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503291#comment-16503291
]
Ryabov Dmitrii commented on IGNITE-2313:
[~agoncharuk], yes, this subject was discussed in
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503262#comment-16503262
]
Alexey Goncharuk commented on IGNITE-2313:
--
[~SomeFire], in this implementation this is a
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500099#comment-16500099
]
Ryabov Dmitrii commented on IGNITE-2313:
[~dpavlov], any suggestions?
> Need to add a mode to
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483699#comment-16483699
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire]
Looks good to me,
but we have to pass
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457616#comment-16457616
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire],
Thanks, I'll check changes
> Need to
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454771#comment-16454771
]
Ryabov Dmitrii commented on IGNITE-2313:
Hello, Igniters!
I have updated PR and refreshed tests.
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205526#comment-16205526
]
Ryabov Dmitrii commented on IGNITE-2313:
[~avinogradov], [~sboikov], I've done with tests. PR is
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118179#comment-16118179
]
Ryabov Dmitrii commented on IGNITE-2313:
Yes, some tests fails because of my changes (but I can't
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108657#comment-16108657
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire],
Please check that failures not
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108600#comment-16108600
]
Ryabov Dmitrii commented on IGNITE-2313:
Thx for review, [~sboikov]. I added test to basic suite,
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085744#comment-16085744
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire],
Looks good to me.
[~sboikov],
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085236#comment-16085236
]
Ryabov Dmitrii commented on IGNITE-2313:
[~avinogradov], I fixed metod which compare proxies,
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080368#comment-16080368
]
Anton Vinogradov commented on IGNITE-2313:
--
[~SomeFire],
I've checked fixes, looks good.
Let's
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080011#comment-16080011
]
Vladimir Ozerov commented on IGNITE-2313:
-
Definitely not blocker.
> Need to add a mode to fail
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031500#comment-16031500
]
Anton Vinogradov commented on IGNITE-2313:
--
I thinks we should restrict any operations including
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014015#comment-16014015
]
Ryabov Dmitrii commented on IGNITE-2313:
[~amashenkov], done.
[~yzhdanov], can you make a final
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012459#comment-16012459
]
Andrew Mashenkov commented on IGNITE-2313:
--
[~SomeFire], looks good, but still there are some
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962689#comment-15962689
]
Ryabov Dmitrii commented on IGNITE-2313:
[~amashenkov], I made fixes.
> Need to add a mode to
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950501#comment-15950501
]
ASF GitHub Bot commented on IGNITE-2313:
GitHub user SomeFire opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074767#comment-15074767
]
Yakov Zhdanov commented on IGNITE-2313:
---
I don't think so
> Need to add a mode to fail atomic
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074087#comment-15074087
]
Dmitriy Setrakyan commented on IGNITE-2313:
---
Sounds good. Is there a need for a config flag
[
https://issues.apache.org/jira/browse/IGNITE-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073860#comment-15073860
]
Yakov Zhdanov commented on IGNITE-2313:
---
I would introduce something like
40 matches
Mail list logo