[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-12 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162864#comment-16162864 ] Semen Boikov commented on IGNITE-5648: -- Looks ok to me. Thanks > DDL: NOT NULL constraint support

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-12 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162634#comment-16162634 ] Sergey Kalashnikov commented on IGNITE-5648: [~sboikov], [~vozerov], Points 1, 2 - fixed.

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-08 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158726#comment-16158726 ] Semen Boikov commented on IGNITE-5648: -- [~skalashnikov], - I think handling for invoke in atomic

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-08 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158675#comment-16158675 ] Vladimir Ozerov commented on IGNITE-5648: - [~skalashnikov], I am ok with the fix then.

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-08 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158623#comment-16158623 ] Sergey Kalashnikov commented on IGNITE-5648: [~vozerov], Thanks for your comments. I have

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-08 Thread Vladimir Ozerov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158501#comment-16158501 ] Vladimir Ozerov commented on IGNITE-5648: - [~skalashnikov], my comments: 1) I made several minor

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-07 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157119#comment-16157119 ] Sergey Kalashnikov commented on IGNITE-5648: Refreshed PR from master, added support for 'not

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-05 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153520#comment-16153520 ] Sergey Kalashnikov commented on IGNITE-5648: [~vozerov], [~sboikov], may I ask you to look at

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-09-05 Thread Sergey Kalashnikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153518#comment-16153518 ] Sergey Kalashnikov commented on IGNITE-5648: Fixed comments 1-3. As for p4. I think it is not

[jira] [Commented] (IGNITE-5648) DDL: NOT NULL constraint support for CREATE TABLE operator

2017-08-31 Thread Semen Boikov (JIRA)
[ https://issues.apache.org/jira/browse/IGNITE-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148795#comment-16148795 ] Semen Boikov commented on IGNITE-5648: -- Hi Sergey, I did review, in general looks good, I have some