[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602582#comment-16602582
]
ASF GitHub Bot commented on IGNITE-8286:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598765#comment-16598765
]
Alexey Goncharuk commented on IGNITE-8286:
--
[~roman_s], please move the ticket to Patch
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598756#comment-16598756
]
Ilya Lantukh commented on IGNITE-8286:
--
[~agoncharuk], I think we can merge it into master and
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598094#comment-16598094
]
Roman Shtykh commented on IGNITE-8286:
--
Hi [~ilantukh]
Thanks for getting back to the issue, and
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597347#comment-16597347
]
Ilya Lantukh commented on IGNITE-8286:
--
[~roman_s], thanks!
There is still one minor issue - new
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596062#comment-16596062
]
Alexey Goncharuk commented on IGNITE-8286:
--
[~ilantukh] can you review the changes made by
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524621#comment-16524621
]
Roman Shtykh commented on IGNITE-8286:
--
Hi [~ilantukh], thank you for the review! Please see the
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506964#comment-16506964
]
Ilya Lantukh commented on IGNITE-8286:
--
Hi [~roman_s], I've reviewed your changes here:
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503205#comment-16503205
]
Dmitriy Pavlov commented on IGNITE-8286:
Hi [~ilantukh], could you please take a look?
>
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456368#comment-16456368
]
Roman Shtykh commented on IGNITE-8286:
--
[~agoncharuk] Thank you for the feedback. Updated to throw
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454227#comment-16454227
]
Alexey Goncharuk commented on IGNITE-8286:
--
[~roman_s], I think that instead of returning an
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453820#comment-16453820
]
Vladimir Ozerov commented on IGNITE-8286:
-
[~dpavlov] out of my scope.
> ScanQuery ignore
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16453516#comment-16453516
]
Roman Shtykh commented on IGNITE-8286:
--
[~sboikov] can I ask for your review please? I found you
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445969#comment-16445969
]
Roman Shtykh commented on IGNITE-8286:
--
Attached TC test results.
> ScanQuery ignore setLocal with
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445648#comment-16445648
]
Dmitriy Pavlov commented on IGNITE-8286:
[~vozerov] could you please take a look?
> ScanQuery
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443494#comment-16443494
]
ASF GitHub Bot commented on IGNITE-8286:
GitHub user shroman opened a pull request:
[
https://issues.apache.org/jira/browse/IGNITE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442201#comment-16442201
]
Roman Shtykh commented on IGNITE-8286:
--
Looks like
{code:java}
if (nodes.isEmpty() && part ==
17 matches
Mail list logo