[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596301#comment-16596301
]
Pavel Tupitsyn commented on IGNITE-9301:
Oh, I'm late to the party, thanks everyone for handling
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591609#comment-16591609
]
ASF GitHub Bot commented on IGNITE-9301:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591562#comment-16591562
]
Ilya Kasnacheev commented on IGNITE-9301:
-
Looks good to me now. I'm slightly worried about
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590296#comment-16590296
]
Dmitriy Pavlov commented on IGNITE-9301:
[~ilyak] feature was added in the separate ticket
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590277#comment-16590277
]
Ilya Kasnacheev commented on IGNITE-9301:
-
[~alexzaitzev] My take, if you add a feature .Net,
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587966#comment-16587966
]
Aleksei Zaitsev commented on IGNITE-9301:
-
[~ilyak] I've looked on other commits, where similar
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585804#comment-16585804
]
Ilya Kasnacheev commented on IGNITE-9301:
-
Hello!
Can you write a test for this feature, taking
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585761#comment-16585761
]
Dmitriy Pavlov commented on IGNITE-9301:
I've checked tests and code. Patch looks good to me.
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585226#comment-16585226
]
Vyacheslav Daradur commented on IGNITE-9301:
The solution looks good to me.
Also, tests
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585051#comment-16585051
]
Vyacheslav Daradur commented on IGNITE-9301:
Started tests build:
[
https://issues.apache.org/jira/browse/IGNITE-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584962#comment-16584962
]
ASF GitHub Bot commented on IGNITE-9301:
GitHub user alexzaitzev opened a pull request:
11 matches
Mail list logo