[jira] [Comment Edited] (IGNITE-10762) migrate test suites from Junit 3 to 4
[
https://issues.apache.org/jira/browse/IGNITE-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726519#comment-16726519
]
Oleg Ignatenko edited comment on IGNITE-10762 at 12/22/18 10:58 PM:
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
-- possibly this can further split by "extracting" to separate sub-task
suites that involve {{IgniteTestSuite}} API
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
was (Author: oignatenko):
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
> migrate test suites from Junit 3 to 4
> -
>
> Key: IGNITE-10762
> URL: https://issues.apache.org/jira/browse/IGNITE-10762
> Project: Ignite
> Issue Type: Task
>Affects Versions: 2.8
>Reporter: Ivan Pavlukhin
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain, technical_debt
> Fix For: 2.8
>
>
> It seems that {{@Ignore}} annotation is processed incorrectly when a test in
> Junit 4 style is included into Junit 3 test suite (wrapped into
> {{JUnit4TestAdapter}}). Actually such test is skipped silently when it is
> called during a suite execution. So, for full a blown usage of {{@Ignore}}
> test suites must be migrated to Junit 4 as well. Expected behavior here is
> reporting that a particular test method was ignored after tests execution.
> Ignored tests should be visible in CI.
> Apparently such unexpected behavior of {{@Ignore}} can be caused by
> {{JUnit4TestAdapter}} as it explicitly filters test method marked with this
> annotation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10774) migrate test suites that are fixed lists of test classes from Junit 3 to 4
[ https://issues.apache.org/jira/browse/IGNITE-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727573#comment-16727573 ] ASF GitHub Bot commented on IGNITE-10774: - GitHub user oignatenko opened a pull request: https://github.com/apache/ignite/pull/5732 IGNITE-10774 migrate test suites that are fixed lists of test classes from Junit 3 to 4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10774 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5732.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5732 commit ff4699bebf2571cbd648cbf8bccf1e957c7547e5 Author: Oleg Ignatenko Date: 2018-12-02T23:35:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - added @Test -- verified with diffs overview commit a72e24ea010fd7333b7425c349e3de1373aed0fc Author: Oleg Ignatenko Date: 2018-12-03T00:24:34Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eeeba1cc2f9d9dc02065c19c7c1079008bf73e00 Author: Oleg Ignatenko Date: 2018-12-03T00:26:13Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9304b5f31ef712708be7d04b68a963d8bf4b050d Author: Oleg Ignatenko Date: 2018-12-03T00:29:51Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 7eaf7a0252fb347f19d192859c410c3c29f7c4b6 Author: Oleg Ignatenko Date: 2018-12-03T00:39:54Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit eaee42ebf611c1617993177d6466e81399c3ebdc Author: Oleg Ignatenko Date: 2018-12-03T00:48:56Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 62738a3820d4057a9c34ad8b2c6e85959ebfc67e Author: Oleg Ignatenko Date: 2018-12-03T00:57:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit afb495f9e97e6e15b0c4c29f6d57dd2bbd569f1c Author: Oleg Ignatenko Date: 2018-12-03T08:39:38Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3b56b742b52a516a4244d2a07635a99d9abeba18 Author: Oleg Ignatenko Date: 2018-12-03T09:06:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3835772a72a99882f9d6cd2557001c9db94ed416 Author: Oleg Ignatenko Date: 2018-12-03T09:31:45Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ac6be2c4e07748f34da5d83ce3e9f20786ead2fc Author: Oleg Ignatenko Date: 2018-12-03T10:46:59Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 9f663a9c857f76fcb0e56c194cc2d6ec10f6888b Author: Oleg Ignatenko Date: 2018-12-03T11:13:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit e2eae3201a88c3d9800b9964ce9ca4096ed3d85f Author: Oleg Ignatenko Date: 2018-12-03T11:31:35Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit f9ccc80de28fb2fc64c96d695f5f906a8cd9a946 Author: Oleg Ignatenko Date: 2018-12-03T12:40:21Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 3eadd0abf6f58a0a3d8fe8464bb08879d412bca1 Author: Oleg Ignatenko Date: 2018-12-03T13:33:00Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 28d9f854993cb99867803cfe0126cf723e071cc5 Author: Oleg Ignatenko Date: 2018-12-03T13:54:52Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit ed54719377f694d0111740c0bbd92dcf5294e6c6 Author: Oleg Ignatenko Date: 2018-12-03T14:10:26Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit fb97a8c23881d1d1c50423dcea6ac519a36c195a Author: Oleg Ignatenko Date: 2018-12-03T14:26:19Z IGNITE-10175 migrate core module tests from Junit 3 to 4 - wip - migrating -- verified with diffs overview commit 063f7ae0164924a775b4235ebd0f704017bc2c73 Author: Oleg Ignatenko Date: 2018-12-03T14:45:00Z IGNITE-10175 migrate core module
[jira] [Commented] (IGNITE-9165) FindBugs: Methods may fail to close stream in core module
[
https://issues.apache.org/jira/browse/IGNITE-9165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727506#comment-16727506
]
Ignite TC Bot commented on IGNITE-9165:
---
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2615378buildTypeId=IgniteTests24Java8_RunAll]
> FindBugs: Methods may fail to close stream in core module
> -
>
> Key: IGNITE-9165
> URL: https://issues.apache.org/jira/browse/IGNITE-9165
> Project: Ignite
> Issue Type: Bug
> Components: binary
>Affects Versions: 2.6
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
> Labels: newbie
> Fix For: 2.8
>
> Attachments:
> findbugs-result-apache-ignite[ignite-core]_2018_08_02_12_38_02.html
>
>
> The method creates an IO stream object, does not assign it to any fields,
> pass it to other methods that might close it, or return it, and does not
> appear to close the stream on all paths out of the method. This may result
> in a file descriptor leak.
> Example:
>
> {code:java}
> // GridCacheAbstractLoadTest#GridCacheAbstractLoadTest()
> try {
> props.load(new FileReader(GridTestUtils.resolveIgnitePath(
> "modules/tests/config/cache-load.properties")));
> }
> catch (IOException e) {
> throw new RuntimeException(e);
> }{code}
>
> One of possible solutions:
> {code:java}
> try (Reader reader = new FileReader(GridTestUtils.resolveIgnitePath(
> "modules/tests/config/cache-load.properties"))) {
> props.load(reader);
> }
> catch (IOException e) {
> throw new RuntimeException(e);
> }{code}
> List of classes in "core" module:
>
> +org.apache.ignite.internal:+
> * *BinaryContext*#classesInPackage(String)
> * *GridClientJdkMarshaller*#marshal(Object, int)
> *
> *IgniteExplicitImplicitDeploymentSelfTest*$GridDeploymentResourceTestJob#execute()
> * *OptimizedObjectStreamSelfTest*#testReadLine()
> * *PageIdDistributionTest*#_testRealHistory()
> * *HttpIgniteUpdatesChecker*#getUpdates(boolean)
> * *IpcSharedMemoryNativeLoaderSelfTest*#readStreams(Process)
> +org.apache.ignite:+
> * *GridCacheAbstractLoadTest*#GridCacheAbstractLoadTest()
> * *GridTestUtils*.sslContext()
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10779) PagesWriteThrottleSmokeTest.testThrottle is flaky
[
https://issues.apache.org/jira/browse/IGNITE-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727492#comment-16727492
]
Ignite TC Bot commented on IGNITE-10779:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2614152buildTypeId=IgniteTests24Java8_RunAll]
> PagesWriteThrottleSmokeTest.testThrottle is flaky
> -
>
> Key: IGNITE-10779
> URL: https://issues.apache.org/jira/browse/IGNITE-10779
> Project: Ignite
> Issue Type: Task
>Reporter: Nikolai Kulagin
>Assignee: Nikolai Kulagin
>Priority: Minor
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.8
>
>
> Sometimes, at poor checkpoint write speed, put rate degrated to zero for at
> least 10 seconds with write throttling enabled. Success rate on TC = 87%.
> [Test
> details|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8=2808794487465215609=testDetails]
> {code:java}
> junit.framework.AssertionFailedError: Put rate degraded to zero for at least
> 10 seconds
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at
> org.apache.ignite.internal.processors.cache.persistence.pagemem.PagesWriteThrottleSmokeTest.testThrottle(PagesWriteThrottleSmokeTest.java:217)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2209)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:144)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2124)
> at java.lang.Thread.run(Thread.java:748)
> {code}
> Test became flaky after IGNITE-10028.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10130) Add option for disable triggering cache interceptor in case of conflicts.
[
https://issues.apache.org/jira/browse/IGNITE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727419#comment-16727419
]
Ignite TC Bot commented on IGNITE-10130:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2613533buildTypeId=IgniteTests24Java8_RunAll]
> Add option for disable triggering cache interceptor in case of conflicts.
> -
>
> Key: IGNITE-10130
> URL: https://issues.apache.org/jira/browse/IGNITE-10130
> Project: Ignite
> Issue Type: Improvement
> Components: cache
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Interceptor semantic for Dr updates looks broken.
> For now, Ignite call post-update interceptor methods for Dr updates and there
> is no way to disable interceptor calls at all.
> This force user to call onGet before sending entry to remote DR that may be
> inefficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10130) Add option for disable triggering cache interceptor in case of conflicts.
[ https://issues.apache.org/jira/browse/IGNITE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727423#comment-16727423 ] Sergey Antonov commented on IGNITE-10130: - [~agoncharuk] I got TC visa. Could you review my changes again? > Add option for disable triggering cache interceptor in case of conflicts. > - > > Key: IGNITE-10130 > URL: https://issues.apache.org/jira/browse/IGNITE-10130 > Project: Ignite > Issue Type: Improvement > Components: cache >Reporter: Sergey Antonov >Assignee: Sergey Antonov >Priority: Major > Fix For: 2.8 > > > Interceptor semantic for Dr updates looks broken. > For now, Ignite call post-update interceptor methods for Dr updates and there > is no way to disable interceptor calls at all. > This force user to call onGet before sending entry to remote DR that may be > inefficient. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10177) cleanup Junit 3 from the project
[
https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727349#comment-16727349
]
ASF GitHub Bot commented on IGNITE-10177:
-
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/5615
> cleanup Junit 3 from the project
>
>
> Key: IGNITE-10177
> URL: https://issues.apache.org/jira/browse/IGNITE-10177
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.8
>
>
> If needed, refer parent task for more details.
> # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
> # remove dependencies from Junit 3 in Maven (if there are any)
> # migrate tests that were missed at prior steps for various reasons:
> ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass
> which currently conflict with Junit4 execution because of using constructors
> and make them properly use {{@Test}} annotation
> ## find out why
> {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears to
> start running slow / timing out after adding Junit 4 annotations (reproduced
> this on teamcity and locally as was discovered in IGNITE-10175)
> ## find out why {{IgniteTwitterStreamerTest}} runs fine under JUnit 3 but
> starts failing after move to JUnit 4
> ## IgniteCachePartitionedQuerySelfTest,
> IgniteCacheReplicatedQueryP2PDisabledSelfTest, ComputeUtilsTest,
> CacheBasedDatasetBuilderTest, CacheBasedDatasetTest,
> GridPartitionedCacheJtaLookupClassNameSelfTest,
> GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating
> these at IGNITE-10176)
> ## find out why tests in logging suite failed on teamcity (not locally) when
> setup method was annotated {{@Before}}
> ## (!) note part of this work related to
> {{IgniteConfigVariationsAbstractTest}} is expected to be done separately per
> IGNITE-10739
> # in tests suite classes, change {{extends TestSuite}} to either
> {{@RunWith(AllTests.class)}} or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> # remove redundant references to {{JUnit4.class}} if there are any (like in
> {{@RunWith(JUnit4.class)}})
> (i) per discussion with [~EdShangGG] plan to to do this in a separate
> ticket for smoother merges - IGNITE-10758
> Side note if for some reason it turns out critically important to keep test
> suites names (by default Junit 4 will use suite class names instead),
> approach with custom description annotation [described
> here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
> can be used to address that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10130) Add option for disable triggering cache interceptor in case of conflicts.
[
https://issues.apache.org/jira/browse/IGNITE-10130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727345#comment-16727345
]
Ignite TC Bot commented on IGNITE-10130:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC JDBC{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2620950]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2613533buildTypeId=IgniteTests24Java8_RunAll]
> Add option for disable triggering cache interceptor in case of conflicts.
> -
>
> Key: IGNITE-10130
> URL: https://issues.apache.org/jira/browse/IGNITE-10130
> Project: Ignite
> Issue Type: Improvement
> Components: cache
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>
> Interceptor semantic for Dr updates looks broken.
> For now, Ignite call post-update interceptor methods for Dr updates and there
> is no way to disable interceptor calls at all.
> This force user to call onGet before sending entry to remote DR that may be
> inefficient.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (IGNITE-10177) cleanup Junit 3 from the project
[
https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitriy Pavlov updated IGNITE-10177:
Fix Version/s: 2.8
> cleanup Junit 3 from the project
>
>
> Key: IGNITE-10177
> URL: https://issues.apache.org/jira/browse/IGNITE-10177
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
> Fix For: 2.8
>
>
> If needed, refer parent task for more details.
> # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
> # remove dependencies from Junit 3 in Maven (if there are any)
> # migrate tests that were missed at prior steps for various reasons:
> ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass
> which currently conflict with Junit4 execution because of using constructors
> and make them properly use {{@Test}} annotation
> ## find out why
> {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears to
> start running slow / timing out after adding Junit 4 annotations (reproduced
> this on teamcity and locally as was discovered in IGNITE-10175)
> ## find out why {{IgniteTwitterStreamerTest}} runs fine under JUnit 3 but
> starts failing after move to JUnit 4
> ## IgniteCachePartitionedQuerySelfTest,
> IgniteCacheReplicatedQueryP2PDisabledSelfTest, ComputeUtilsTest,
> CacheBasedDatasetBuilderTest, CacheBasedDatasetTest,
> GridPartitionedCacheJtaLookupClassNameSelfTest,
> GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating
> these at IGNITE-10176)
> ## find out why tests in logging suite failed on teamcity (not locally) when
> setup method was annotated {{@Before}}
> ## (!) note part of this work related to
> {{IgniteConfigVariationsAbstractTest}} is expected to be done separately per
> IGNITE-10739
> # in tests suite classes, change {{extends TestSuite}} to either
> {{@RunWith(AllTests.class)}} or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> # remove redundant references to {{JUnit4.class}} if there are any (like in
> {{@RunWith(JUnit4.class)}})
> (i) per discussion with [~EdShangGG] plan to to do this in a separate
> ticket for smoother merges - IGNITE-10758
> Side note if for some reason it turns out critically important to keep test
> suites names (by default Junit 4 will use suite class names instead),
> approach with custom description annotation [described
> here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
> can be used to address that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10177) cleanup Junit 3 from the project
[
https://issues.apache.org/jira/browse/IGNITE-10177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727324#comment-16727324
]
Eduard Shangareev commented on IGNITE-10177:
[~oignatenko], looks good! Thank you for contribution. There are only few steps
to complete moving from JUnit 3 to 4.
> cleanup Junit 3 from the project
>
>
> Key: IGNITE-10177
> URL: https://issues.apache.org/jira/browse/IGNITE-10177
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Oleg Ignatenko
>Assignee: Oleg Ignatenko
>Priority: Major
>
> If needed, refer parent task for more details.
> # remove Junit3-specific parts of API of GridAbstractTest and its subclasses
> # remove dependencies from Junit 3 in Maven (if there are any)
> # migrate tests that were missed at prior steps for various reasons:
> ## untangle design of {{IgnitePdsContinuousRestartTest}} and its subclass
> which currently conflict with Junit4 execution because of using constructors
> and make them properly use {{@Test}} annotation
> ## find out why
> {{WalCompactionTest.testCompressorToleratesEmptyWalSegmentsFsync}} appears to
> start running slow / timing out after adding Junit 4 annotations (reproduced
> this on teamcity and locally as was discovered in IGNITE-10175)
> ## find out why {{IgniteTwitterStreamerTest}} runs fine under JUnit 3 but
> starts failing after move to JUnit 4
> ## IgniteCachePartitionedQuerySelfTest,
> IgniteCacheReplicatedQueryP2PDisabledSelfTest, ComputeUtilsTest,
> CacheBasedDatasetBuilderTest, CacheBasedDatasetTest,
> GridPartitionedCacheJtaLookupClassNameSelfTest,
> GridReplicatedCacheJtaLookupClassNameSelfTest (there were problems migrating
> these at IGNITE-10176)
> ## find out why tests in logging suite failed on teamcity (not locally) when
> setup method was annotated {{@Before}}
> ## (!) note part of this work related to
> {{IgniteConfigVariationsAbstractTest}} is expected to be done separately per
> IGNITE-10739
> # in tests suite classes, change {{extends TestSuite}} to either
> {{@RunWith(AllTests.class)}} or {{@Suite.SuiteClasses}}
> # find and update all Junit3-specific code that {{extends TestCase}}
> # execute junit related inspections of IDE and analyse results
> # remove redundant references to {{JUnit4.class}} if there are any (like in
> {{@RunWith(JUnit4.class)}})
> (i) per discussion with [~EdShangGG] plan to to do this in a separate
> ticket for smoother merges - IGNITE-10758
> Side note if for some reason it turns out critically important to keep test
> suites names (by default Junit 4 will use suite class names instead),
> approach with custom description annotation [described
> here|https://stackoverflow.com/questions/34745080/is-it-possible-to-name-a-test-suite-in-junit-4/34745518]
> can be used to address that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
