[jira] [Created] (IGNITE-12001) SchemaExchangeSelfTest.testServerRestartWithNewTypes is flaky

2019-07-19 Thread Ivan Pavlukhin (JIRA)
Ivan Pavlukhin created IGNITE-12001:
---

 Summary: SchemaExchangeSelfTest.testServerRestartWithNewTypes is 
flaky
 Key: IGNITE-12001
 URL: https://issues.apache.org/jira/browse/IGNITE-12001
 Project: Ignite
  Issue Type: Bug
  Components: sql
Reporter: Ivan Pavlukhin
Assignee: Ivan Pavlukhin


SchemaExchangeSelfTest.testServerRestartWithNewTypes is flaky.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-12000) IgniteSqlQueryMinMaxTest is flaky

2019-07-19 Thread Ivan Pavlukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-12000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889150#comment-16889150
 ] 

Ivan Pavlukhin commented on IGNITE-12000:
-

[TC 
runs|https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BinaryObjectsSimpleMapperQueries?branch=pull%2F6708%2Fhead=overview]
 do not contain failures for the fixed test. Also confirmed by multiple runs 
locally.

> IgniteSqlQueryMinMaxTest is flaky
> -
>
> Key: IGNITE-12000
> URL: https://issues.apache.org/jira/browse/IGNITE-12000
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.7.5
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteSqlQueryMinMaxTest is flaky.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889126#comment-16889126
 ] 

Ignite TC Bot commented on IGNITE-11997:


{panel:title=Branch: [pull/6706/head] Base: [master] : Possible Blockers 
(2)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform C++ (Linux)*{color} [[tests 1 JVM CRASH , Exit Code , 
Failure on metric |https://ci.ignite.apache.org/viewLog.html?buildId=4357090]]
* IgniteCoreTest: CacheTestSuite: TestPutGetStructWithEnumField

{color:#d04437}Platform .NET (Long Running){color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=4356562]]
* exe: ClientConnectionTest.TestIdleTimeout

{panel}
[TeamCity *-- Run :: All* 
Results|https://ci.ignite.apache.org/viewLog.html?buildId=4354867buildTypeId=IgniteTests24Java8_RunAll]

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (IGNITE-7354) H2 Debug Console should be marked as deprecated.

2019-07-19 Thread Ivan Pavlukhin (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Pavlukhin resolved IGNITE-7354.

Resolution: Duplicate

Resolved because duplicates IGNITE-11333

> H2 Debug Console should be marked as deprecated.
> 
>
> Key: IGNITE-7354
> URL: https://issues.apache.org/jira/browse/IGNITE-7354
> Project: Ignite
>  Issue Type: Improvement
>  Components: sql
>Affects Versions: 2.3
>Reporter: Vyacheslav Koptilin
>Priority: Minor
>
> It seems H2 Debug Console is a legacy tool and does not support all 
> capabilities provided by Apache Ignite SQL engine.
> So, it should be marked as deprecated. The documentation page 
> https://apacheignite-net.readme.io/docs/sql-queries#using-h2-debug-console 
> should be updated as well in order to provide more powerful and convenient 
> tools like WebConsole, SQLLine etc.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11248) H2 Debug Console reports NPE when launched

2019-07-19 Thread Ivan Pavlukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889098#comment-16889098
 ] 

Ivan Pavlukhin commented on IGNITE-11248:
-

[~ilyak], can we close the issue as H2 Debug console is not available after 
IGNITE-11333.

> H2 Debug Console reports NPE when launched
> --
>
> Key: IGNITE-11248
> URL: https://issues.apache.org/jira/browse/IGNITE-11248
> Project: Ignite
>  Issue Type: Bug
>  Components: sql
>Affects Versions: 2.7
>Reporter: Ilya Kasnacheev
>Priority: Minor
>
> Reliably happens on invocation of 
> IGNITE_H2_DEBUG_CONSOLE=true bin/ignite.sh
> {code}
> Внутренняя ошибка: "java.lang.NullPointerException"
> General error: "java.lang.NullPointerException"; SQL statement:
> SELECT TABLE_CAT, TABLE_SCHEM, TABLE_NAME, TABLE_TYPE, REMARKS, TYPE_CAT, 
> TYPE_SCHEM, TYPE_NAME, SELF_REFERENCING_COL_NAME, REF_GENERATION, SQL FROM 
> (SELECT SYNONYM_CATALOG TABLE_CAT, SYNONYM_SCHEMA TABLE_SCHEM, SYNONYM_NAME 
> as TABLE_NAME, TYPE_NAME AS TABLE_TYPE, REMARKS, TYPE_NAME TYPE_CAT, 
> TYPE_NAME TYPE_SCHEM, TYPE_NAME AS TYPE_NAME, TYPE_NAME 
> SELF_REFERENCING_COL_NAME, TYPE_NAME REF_GENERATION, NULL AS SQL FROM 
> INFORMATION_SCHEMA.SYNONYMS WHERE SYNONYM_CATALOG LIKE ? ESCAPE ? AND 
> SYNONYM_SCHEMA LIKE ? ESCAPE ? AND SYNONYM_NAME LIKE ? ESCAPE ? AND (true)  
> UNION SELECT TABLE_CATALOG TABLE_CAT, TABLE_SCHEMA TABLE_SCHEM, TABLE_NAME, 
> TABLE_TYPE, REMARKS, TYPE_NAME TYPE_CAT, TYPE_NAME TYPE_SCHEM, TYPE_NAME, 
> TYPE_NAME SELF_REFERENCING_COL_NAME, TYPE_NAME REF_GENERATION, SQL FROM 
> INFORMATION_SCHEMA.TABLES WHERE TABLE_CATALOG LIKE ? ESCAPE ? AND 
> TABLE_SCHEMA LIKE ? ESCAPE ? AND TABLE_NAME LIKE ? ESCAPE ? AND (TABLE_TYPE 
> IN(?, ?, ?, ?, ?, ?, ?)) ) ORDER BY TABLE_TYPE, TABLE_SCHEM, TABLE_NAME 
> [5-197] HY000/5
> {code}
> in browser window that is opened.
> Reportedly, used to work just fine 2.6



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889087#comment-16889087
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

Rerun with deleted test: 
https://ci.ignite.apache.org/viewQueued.html?itemId=4357164

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Assigned] (IGNITE-11996) Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore

2019-07-19 Thread Ivan Pavlukhin (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Pavlukhin reassigned IGNITE-11996:
---

Assignee: (was: Ivan Pavlukhin)

> Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore
> --
>
> Key: IGNITE-11996
> URL: https://issues.apache.org/jira/browse/IGNITE-11996
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.7.5
>Reporter: Ivan Pavlukhin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Assertion error occurs in IgniteCacheOffheapManagerImpl#destroyCacheDataStore 
> in a following code:
> {code}
> boolean removed = partDataStores.remove(p, store);
> assert removed;
> {code}
> It asserts that a partition store must be removed from a map here. But in 
> practice a removal can occur at least in 2 places: node stop and partition 
> eviction. Employed synchronization is not sufficient to guarantee that a 
> removal happens exactly once.
> The issue is reproduced in {{IgniteSqlQueryMinMaxTest}} from time to time.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889060#comment-16889060
 ] 

Pavel Kuznetsov edited comment on IGNITE-11997 at 7/19/19 5:49 PM:
---

Got feedback from [~amashenkov]. According to the IGNITE-3300 this test cannot 
reproduce original issue because topology is stable and assignment is not 
changed.
[~agoncharuk] could you please take a look at the 
{{IgniteCacheQueriesLoadTest1.testQueries}}? We want to remove it at all. 


was (Author: pkouznet):
Got feedback from [~amashenkov]. According to the IGNITE-3300 this test cannot 
reproduce original issue because topology is stable and assignment is not 
changed.
[~agoncharuk] can you please take a look at the 
{{IgniteCacheQueriesLoadTest1.testQueries}}? We want to remove it at all. 

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889060#comment-16889060
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

Got feedback from [~amashenkov]. According to the IGNITE-3300 this test cannot 
reproduce original issue because topology is stable and assignment is not 
changed.
[~agoncharuk] can you please take a look at the 
{{IgniteCacheQueriesLoadTest1.testQueries}}? We want to remove it at all. 

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889043#comment-16889043
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

[~amashenkov] would you please take a look at the patch?

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889042#comment-16889042
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

Now test took 15 seconds: 
https://ci.ignite.apache.org/viewLog.html?buildId=4354867=IgniteTests24Java8_RunAll=testsInfo_IgniteTests24Java8=pull%2F6525%2Fhead

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11073) Add Copy-on-Write machinery to the Checkpoiner

2019-07-19 Thread Ignite TC Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16889032#comment-16889032
 ] 

Ignite TC Bot commented on IGNITE-11073:


{panel:title=Branch: [pull/6554/head] Base: [master] : Possible Blockers 
(114)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}PDS (Indexing){color} [[tests 
5|https://ci.ignite.apache.org/viewLog.html?buildId=4355794]]
* IgnitePdsWithIndexingCoreTestSuite: 
IgnitePdsAtomicCacheRebalancingTest.testTopologyChangesWithConstantLoad
* IgnitePdsWithIndexingCoreTestSuite: 
IgnitePdsTxCacheRebalancingTest.testTopologyChangesWithConstantLoad
* IgnitePdsWithIndexingCoreTestSuite: 
IgniteLogicalRecoveryTest.testRecoveryOnDynamicallyStartedCaches
* IgnitePdsWithIndexingCoreTestSuite: 
IgniteLogicalRecoveryTest.testRecoveryOnJoinToActiveCluster
* IgnitePdsWithIndexingCoreTestSuite: 
IgnitePdsTxCacheRebalancingTest.testTopologyChangesWithConstantLoadExplicitTx

{color:#d04437}MVCC PDS 4{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=4355826]]
* IgnitePdsMvccTestSuite4: 
IgniteClusterActivateDeactivateTestWithPersistenceAndMemoryReuse.testConcurrentJoinAndActivate

{color:#d04437}MVCC Cache 7{color} [[tests 
6|https://ci.ignite.apache.org/viewLog.html?buildId=4355820]]
* IgniteCacheMvccTestSuite7: 
CacheConfigurationSerializationOnDiscoveryTest.testSerializationForCachesConfiguredOnDifferentNodes3[Persistence
 enabled = true]
* IgniteCacheMvccTestSuite7: 
CacheConfigurationSerializationOnDiscoveryTest.testSerializationForCachesConfiguredOnCoordinator[Persistence
 enabled = true]
* IgniteCacheMvccTestSuite7: 
CacheConfigurationSerializationOnDiscoveryTest.testSerializationForCachesConfiguredOnDifferentNodes2[Persistence
 enabled = true]
* IgniteCacheMvccTestSuite7: 
IgnitePdsCacheAssignmentNodeRestartsTest.testAssignmentAfterRestarts
* IgniteCacheMvccTestSuite7: 
CacheConfigurationSerializationOnExchangeTest.testSerializationForDynamicCacheStartedOnCoordinator[Persistence
 enabled = true]
* IgniteCacheMvccTestSuite7: 
CacheConfigurationSerializationOnExchangeTest.testSerializationForDynamicCacheStartedOnClientNode[Persistence
 enabled = true]

{color:#d04437}MVCC PDS 2{color} [[tests 
1|https://ci.ignite.apache.org/viewLog.html?buildId=4355824]]
* IgnitePdsMvccTestSuite2: 
IgnitePdsPartitionFilesDestroyTest.testPartitionFileDestroyCrashRecovery2

{color:#d04437}Queries 1{color} [[tests 
5|https://ci.ignite.apache.org/viewLog.html?buildId=4355806]]
* IgniteBinaryCacheQueryTestSuite: 
BasicIndexMultinodeTest.testAllIndexesWithPersistenceIndexRebuild
* IgniteBinaryCacheQueryTestSuite: 
BasicIndexMultinodeTest.testDynamicIndexesWithPersistenceIndexRebuild
* IgniteBinaryCacheQueryTestSuite: 
BasicIndexMultinodeTest.testNoIndexesWithPersistence
* IgniteBinaryCacheQueryTestSuite: 
BasicIndexMultinodeTest.testAllIndexesWithPersistence
* IgniteBinaryCacheQueryTestSuite: 
BasicIndexMultinodeTest.testDynamicIndexesDropWithPersistence

{color:#d04437}ZooKeeper (Discovery) 4{color} [[tests 
2|https://ci.ignite.apache.org/viewLog.html?buildId=4355809]]
* ZookeeperDiscoverySpiTestSuite4: 
DistributedMetaStoragePersistentTest.testWrongStartOrder1
* ZookeeperDiscoverySpiTestSuite4: 
DistributedMetaStoragePersistentTest.testWrongStartOrder2

{color:#d04437}MVCC Queries{color} [[tests 
6|https://ci.ignite.apache.org/viewLog.html?buildId=4355764]]
* IgniteCacheMvccSqlTestSuite: 
CacheMvccPartitionedSqlCoordinatorFailoverTest.testMultipleCoordinatorsLeft3Persistence
* IgniteCacheMvccSqlTestSuite: 
CacheMvccPartitionedSqlCoordinatorFailoverTest.testMultipleCoordinatorsLeft2Persistence
* IgniteCacheMvccSqlTestSuite: 
CacheMvccPartitionedSqlCoordinatorFailoverTest.testPutAllGetAll_ClientServer_Backups2_RestartCoordinator_SqlDml_Persistence
* IgniteCacheMvccSqlTestSuite: 
CacheMvccReplicatedSqlCoordinatorFailoverTest.testMultipleCoordinatorsLeft3Persistence
* IgniteCacheMvccSqlTestSuite: 
CacheMvccReplicatedSqlCoordinatorFailoverTest.testMultipleCoordinatorsLeft2Persistence
* IgniteCacheMvccSqlTestSuite: 
CacheMvccReplicatedSqlTxQueriesTest.testAccountsTxDmlSql_ClientServer_Backups2_Persistence

{color:#d04437}MVCC Cache{color} [[tests 
7|https://ci.ignite.apache.org/viewLog.html?buildId=4355762]]
* IgniteCacheMvccTestSuite: 
CacheMvccTransactionsTest.testPutAllGetAll_ClientServer_Backups0_Persistence_Scan
* IgniteCacheMvccTestSuite: CacheMvccClusterRestartTest.testRestart2
* IgniteCacheMvccTestSuite: 
CacheMvccPartitionedCoordinatorFailoverTest.testMultipleCoordinatorsLeft2Persistence
* IgniteCacheMvccTestSuite: 
CacheMvccReplicatedCoordinatorFailoverTest.testMultipleCoordinatorsLeft3Persistence
* IgniteCacheMvccTestSuite: 
DataStreamProcessorMvccPersistenceSelfTest.testPartitionedIsolated
* IgniteCacheMvccTestSuite: 
CacheMvccReplicatedCoordinatorFailoverTest.testMultipleCoordinatorsLeft2Persistence
* IgniteCacheMvccTestSuite: 

[jira] [Created] (IGNITE-12000) IgniteSqlQueryMinMaxTest is flaky

2019-07-19 Thread Ivan Pavlukhin (JIRA)
Ivan Pavlukhin created IGNITE-12000:
---

 Summary: IgniteSqlQueryMinMaxTest is flaky
 Key: IGNITE-12000
 URL: https://issues.apache.org/jira/browse/IGNITE-12000
 Project: Ignite
  Issue Type: Bug
  Components: sql
Affects Versions: 2.7.5
Reporter: Ivan Pavlukhin
Assignee: Ivan Pavlukhin


IgniteSqlQueryMinMaxTest is flaky.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (IGNITE-11999) .NET unable to specify JvmDllPath for standalone node

2019-07-19 Thread Alexandr Shapkin (JIRA)
Alexandr Shapkin created IGNITE-11999:
-

 Summary: .NET unable to specify JvmDllPath for standalone node
 Key: IGNITE-11999
 URL: https://issues.apache.org/jira/browse/IGNITE-11999
 Project: Ignite
  Issue Type: Bug
  Components: platforms
Affects Versions: 2.7.5
Reporter: Alexandr Shapkin
Assignee: Alexandr Shapkin
 Fix For: 2.8


We have a -JvmDllPath CLI parameter/Ignite.JvmDllPath xml config for standalone 
nodes, that should take care about JVM dll location configuration.

This parameter won't work since Apache.Ignite.Config.Configurator expects 
another one:

/** Command line argument: Path to JVM dll. */
 private const string CmdJvmDll = "JvmDll";

 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (IGNITE-2262) Add collecting of BinaryConfiguration to Visor collector tasks.

2019-07-19 Thread Alexey Kuznetsov (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Kuznetsov closed IGNITE-2262.


> Add collecting of BinaryConfiguration to Visor collector tasks.
> ---
>
> Key: IGNITE-2262
> URL: https://issues.apache.org/jira/browse/IGNITE-2262
> Project: Ignite
>  Issue Type: Task
>  Components: UI
>Affects Versions: 1.5.0.final
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Trivial
>
> And add display of collected info in Visor console.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (IGNITE-2262) Add collecting of BinaryConfiguration to Visor collector tasks.

2019-07-19 Thread Alexey Kuznetsov (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Kuznetsov resolved IGNITE-2262.
--
Resolution: Won't Fix

Visor CMD will be removed in Ignite 3.0.

> Add collecting of BinaryConfiguration to Visor collector tasks.
> ---
>
> Key: IGNITE-2262
> URL: https://issues.apache.org/jira/browse/IGNITE-2262
> Project: Ignite
>  Issue Type: Task
>  Components: UI
>Affects Versions: 1.5.0.final
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Trivial
>
> And add display of collected info in Visor console.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Closed] (IGNITE-398) Schema Import utility should support binding generating Types metadata for user POJOs

2019-07-19 Thread Alexey Kuznetsov (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Kuznetsov closed IGNITE-398.
---

> Schema Import utility should support binding generating Types metadata for 
> user POJOs
> -
>
> Key: IGNITE-398
> URL: https://issues.apache.org/jira/browse/IGNITE-398
> Project: Ignite
>  Issue Type: Task
>  Components: UI
>Affects Versions: sprint-3
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
>
> We need to add a screen where user will be able to bind tables from database 
> to already existing POJOs and generate only XML type metadata.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Resolved] (IGNITE-398) Schema Import utility should support binding generating Types metadata for user POJOs

2019-07-19 Thread Alexey Kuznetsov (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Kuznetsov resolved IGNITE-398.
-
Resolution: Won't Fix

Schema import utility was discontinued in Ignite 2.0.

> Schema Import utility should support binding generating Types metadata for 
> user POJOs
> -
>
> Key: IGNITE-398
> URL: https://issues.apache.org/jira/browse/IGNITE-398
> Project: Ignite
>  Issue Type: Task
>  Components: UI
>Affects Versions: sprint-3
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
>
> We need to add a screen where user will be able to bind tables from database 
> to already existing POJOs and generate only XML type metadata.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11988) control.sh validate_indexes SQL Index issue add information about group and cache id

2019-07-19 Thread Sergey Chugunov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1632#comment-1632
 ] 

Sergey Chugunov commented on IGNITE-11988:
--

[~ktkale...@gridgain.com], change looks good to me as well, please proceed with 
merging.

Thank you for contribution!

> control.sh validate_indexes SQL Index issue add information about group and 
> cache id
> 
>
> Key: IGNITE-11988
> URL: https://issues.apache.org/jira/browse/IGNITE-11988
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> At the moment we have the following output in case of SQL index problems:
> {noformat}
> SQL Index 
> [cache=com.sbt.processing.replication.dpl.data.ReplicationApplyStateV1Entity_DPL_union-module,
>  idx=_key_PK] ValidateIndexesPartitionResult 
> [consistentId=10.116.241.93:47500, sqlIdxName=_key_PK]
>  IndexValidationIssue [key=678073218895971307, 
> cacheName=com.sbt.processing.replication.dpl.data.ReplicationApplyStateV1Entity_DPL_union-module,
>  idxName=_key_PK], class org.apache.ignite.IgniteCheckedException: Key is 
> present in SQL index, but can't be found in CacheDataTree.
>  IndexValidationIssue [key=2495557143516676100, 
> cacheName=com.sbt.processing.replication.dpl.data.ReplicationApplyStateV1Entity_DPL_union-module,
>  idxName=_key_PK], class org.apache.ignite.IgniteCheckedException: Key is 
> present in SQL index, but can't be found in CacheDataTree.
>  IndexValidationIssue [key=null, 
> cacheName=com.sbt.processing.replication.dpl.data.ReplicationApplyStateV1Entity_DPL_union-module,
>  idxName=_key_PK], class java.lang.AssertionError: itemId=9, directCnt=9, 
> indirectCnt=0, page=000133230112 [3883, 3669, 3456, 3242, 3029, 2815, 
> 2602, 2386, 1747][][free=2101]
>  IndexValidationIssue [key=2760988046554825752, 
> cacheName=com.sbt.processing.replication.dpl.data.ReplicationApplyStateV1Entity_DPL_union-module,
>  idxName=_key_PK], class org.apache.ignite.IgniteCheckedException: Key is 
> present in SQL index, but can't be found in CacheDataTree.
> {noformat}
> We print info about cache name only. 
> Now shoud add group and cache id.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (IGNITE-11961) Provide JMX metrics for PME timings

2019-07-19 Thread Amelchev Nikita (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amelchev Nikita updated IGNITE-11961:
-
Labels:   (was: IEP-35)

> Provide JMX metrics for PME timings
> ---
>
> Key: IGNITE-11961
> URL: https://issues.apache.org/jira/browse/IGNITE-11961
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
> Fix For: 2.8
>
>
> Currently, partition map exchange timings printed to log(IGNITE-10493). It 
> will be useful if we allow external tools to collect and aggregate partition 
> map exchange metrics. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (IGNITE-11961) Provide JMX metrics for PME timings

2019-07-19 Thread Amelchev Nikita (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amelchev Nikita updated IGNITE-11961:
-
Fix Version/s: 2.8

> Provide JMX metrics for PME timings
> ---
>
> Key: IGNITE-11961
> URL: https://issues.apache.org/jira/browse/IGNITE-11961
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
>  Labels: IEP-35
> Fix For: 2.8
>
>
> Currently, partition map exchange timings printed to log(IGNITE-10493). It 
> will be useful if we allow external tools to collect and aggregate partition 
> map exchange metrics. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1600#comment-1600
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

Bot visa is scheduled.

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (IGNITE-11998) Fix DataPageScan for fragmented pages.

2019-07-19 Thread Ivan Bessonov (JIRA)
Ivan Bessonov created IGNITE-11998:
--

 Summary: Fix DataPageScan for fragmented pages.
 Key: IGNITE-11998
 URL: https://issues.apache.org/jira/browse/IGNITE-11998
 Project: Ignite
  Issue Type: Bug
Reporter: Ivan Bessonov
 Fix For: 2.8


Fragmented pages crash JVM when accessed by DataPageScan scanner/query 
optimized scanner. It happens when scanner accesses data in later chunk in 
fragmented entry but treats it like the first one, expecting length of the 
payload, which is absent and replaced with raw entry data.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888799#comment-16888799
 ] 

Pavel Kuznetsov commented on IGNITE-11997:
--

Used "scale factor" tests feature to make dataset smaller in PR check runs. 
Original data set value will be used in nightly builds.

> TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1
> 
>
> Key: IGNITE-11997
> URL: https://issues.apache.org/jira/browse/IGNITE-11997
> Project: Ignite
>  Issue Type: Task
>  Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Pavel Kuznetsov
>Priority: Major
>  Labels: tests
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
> investigate the reasons and fix it if possible.
> org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
> org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
>  2m 52.81s



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11995) control.sh if experimental command disabled - don't show help for experemental commands

2019-07-19 Thread Ivan Bessonov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888797#comment-16888797
 ] 

Ivan Bessonov commented on IGNITE-11995:


[~ktkale...@gridgain.com] looks good, thank you! Please proceed with the merge.

> control.sh if experimental command disabled - don't show help for 
> experemental commands
> ---
>
> Key: IGNITE-11995
> URL: https://issues.apache.org/jira/browse/IGNITE-11995
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If experimental command disabled:
>  * don't show WALCommand help
>  * if user ask for help for particular command - print out warning about 
> experimental commands instead of ignoring user request



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Comment Edited] (IGNITE-11961) Provide JMX metrics for PME timings

2019-07-19 Thread Amelchev Nikita (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16887976#comment-16887976
 ] 

Amelchev Nikita edited comment on IGNITE-11961 at 7/19/19 10:47 AM:


I have implemented new metric - isOperationsBlockedByPme. It checks that 
current PME blocks operations. Together with the getCurrentPmeDuration metric, 
these metrics will show influence of the PME on cluster and user operations.


was (Author: nsamelchev):
I have implemented new metric - isCurrentPmeBlocksOperations. It checks that 
current PME blocks operations. Together with the getCurrentPmeDuration metric, 
these metrics will show influence of the PME on cluster and user operations.

> Provide JMX metrics for PME timings
> ---
>
> Key: IGNITE-11961
> URL: https://issues.apache.org/jira/browse/IGNITE-11961
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
>  Labels: IEP-35
>
> Currently, partition map exchange timings printed to log(IGNITE-10493). It 
> will be useful if we allow external tools to collect and aggregate partition 
> map exchange metrics. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Created] (IGNITE-11997) TESTS: investigate long running tests in IgniteCacheQueriesLoadTest1

2019-07-19 Thread Pavel Kuznetsov (JIRA)
Pavel Kuznetsov created IGNITE-11997:


 Summary: TESTS: investigate long running tests in 
IgniteCacheQueriesLoadTest1
 Key: IGNITE-11997
 URL: https://issues.apache.org/jira/browse/IGNITE-11997
 Project: Ignite
  Issue Type: Task
  Components: sql
Reporter: Pavel Kuznetsov
Assignee: Pavel Kuznetsov


IgniteCacheQueriesLoadTest1.testQueries have long execution. Need to 
investigate the reasons and fix it if possible.

org.apache.ignite.testsuites.IgniteBinaryCacheQueryTestSuite2: 
org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1.testQueries
 2m 52.81s




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11995) control.sh if experimental command disabled - don't show help for experemental commands

2019-07-19 Thread Sergey Antonov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888731#comment-16888731
 ] 

Sergey Antonov commented on IGNITE-11995:
-

[~ktkale...@gridgain.com] Changes looks good for me!

> control.sh if experimental command disabled - don't show help for 
> experemental commands
> ---
>
> Key: IGNITE-11995
> URL: https://issues.apache.org/jira/browse/IGNITE-11995
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Kirill Tkalenko
>Assignee: Kirill Tkalenko
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If experimental command disabled:
>  * don't show WALCommand help
>  * if user ask for help for particular command - print out warning about 
> experimental commands instead of ignoring user request



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Updated] (IGNITE-11996) Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore

2019-07-19 Thread Ivan Pavlukhin (JIRA)


 [ 
https://issues.apache.org/jira/browse/IGNITE-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ivan Pavlukhin updated IGNITE-11996:

Description: 
Assertion error occurs in IgniteCacheOffheapManagerImpl#destroyCacheDataStore 
in a following code:
{code}
boolean removed = partDataStores.remove(p, store);

assert removed;
{code}

It asserts that a partition store must be removed from a map here. But in 
practice a removal can occur at least in 2 places: node stop and partition 
eviction. Employed synchronization is not sufficient to guarantee that a 
removal happens exactly once.

The issue is reproduced in {{IgniteSqlQueryMinMaxTest}} from time to time.

  was:
Assertion error occurs in a following code:
{code}
boolean removed = partDataStores.remove(p, store);

assert removed;
{code}

It asserts that a partition store must be removed from a map here. But in 
practice a removal can occur at least in 2 places: node stop and partition 
eviction. Employed synchronization is not sufficient to guarantee that a 
removal happens exactly once.

The issue is reproduced in {{IgniteSqlQueryMinMaxTest}} from time to time.


> Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore
> --
>
> Key: IGNITE-11996
> URL: https://issues.apache.org/jira/browse/IGNITE-11996
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.7.5
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Assertion error occurs in IgniteCacheOffheapManagerImpl#destroyCacheDataStore 
> in a following code:
> {code}
> boolean removed = partDataStores.remove(p, store);
> assert removed;
> {code}
> It asserts that a partition store must be removed from a map here. But in 
> practice a removal can occur at least in 2 places: node stop and partition 
> eviction. Employed synchronization is not sufficient to guarantee that a 
> removal happens exactly once.
> The issue is reproduced in {{IgniteSqlQueryMinMaxTest}} from time to time.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11734) IgniteCache.replace(k, v, nv) requires classes when element is null

2019-07-19 Thread Stanislav Lukyanov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888683#comment-16888683
 ] 

Stanislav Lukyanov commented on IGNITE-11734:
-

[~v.pyatkov] I came across this issue and the fix, and I believe the test has a 
flaw. If `replace` throws an exception other than `ClassNotFoundException` then 
it will be ignored. Do you agree, or am I missing something?

> IgniteCache.replace(k, v, nv) requires classes when element is null
> ---
>
> Key: IGNITE-11734
> URL: https://issues.apache.org/jira/browse/IGNITE-11734
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Reporter: Vladislav Pyatkov
>Assignee: Vladislav Pyatkov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> For example execute this code:
> {code}
> cache.replace(i, new Entity(), new Entity())
> {code}
> when cache have not a value by the key.
> {noformat}
> Caused by: class org.apache.ignite.binary.BinaryInvalidTypeException: 
> ClientP2P$Entity
>   at 
> org.apache.ignite.internal.binary.BinaryContext.descriptorForTypeId(BinaryContext.java:709)
>   at 
> org.apache.ignite.internal.binary.BinaryReaderExImpl.deserialize0(BinaryReaderExImpl.java:1756)
>   at 
> org.apache.ignite.internal.binary.BinaryReaderExImpl.deserialize(BinaryReaderExImpl.java:1715)
>   at 
> org.apache.ignite.internal.binary.BinaryObjectImpl.deserializeValue(BinaryObjectImpl.java:791)
>   at 
> org.apache.ignite.internal.binary.BinaryObjectImpl.value(BinaryObjectImpl.java:142)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheUtils.value(GridCacheUtils.java:1328)
>   at 
> org.apache.ignite.internal.processors.cache.CacheEntryPredicateContainsValue.apply(CacheEntryPredicateContainsValue.java:70)
>   at 
> org.apache.ignite.internal.processors.cache.CacheEntryPredicateContainsValue.apply(CacheEntryPredicateContainsValue.java:33)
>   at 
> org.apache.ignite.internal.processors.cache.GridCacheContext.isAllLocked(GridCacheContext.java:1322)
>   ... 31 more
> Caused by: java.lang.ClassNotFoundException: ClientP2P$Entity
>   at 
> java.net.URLClassLoader.findClass(URLClassLoader.java:382)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>   at 
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
>   at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>   at java.lang.Class.forName0(Native Method)
>   at java.lang.Class.forName(Class.java:348)
>   at 
> org.apache.ignite.internal.util.IgniteUtils.forName(IgniteUtils.java:8643)
>   at 
> org.apache.ignite.internal.MarshallerContextImpl.getClass(MarshallerContextImpl.java:374)
>   at 
> org.apache.ignite.internal.binary.BinaryContext.descriptorForTypeId(BinaryContext.java:700)
>   ... 39 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11921) [IEP-35] Migrate CacheGroupMetrics

2019-07-19 Thread Anton Vinogradov (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888630#comment-16888630
 ] 

Anton Vinogradov commented on IGNITE-11921:
---

[~NIzhikov], 

Checked the code. 
A don't like 
- explicit type usage at fields and method params. Interface should be used. 
- implementation hiding methods like {noformat}mreg.longMetric(...){noformat} 
(it's not cleat it based on {{AtomicLong}}).

Also, I'm not sure its a good case to use {{AtomicLong}} based counter since 
they may slowdown the system, seems every counter should be replaced with 
{{LongAdder}}.
Do we really need {{AtomicLong}} implementation?

So, my ALGTM for now :) 
Please check the TC before the merge.

> [IEP-35] Migrate CacheGroupMetrics
> --
>
> Key: IGNITE-11921
> URL: https://issues.apache.org/jira/browse/IGNITE-11921
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Nikolay Izhikov
>Assignee: Nikolay Izhikov
>Priority: Major
>  Labels: IEP-35
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> After merging of IGNITE-11848 we should migrate `CacheGroupMetricsMXBean` to 
> the new metric framework.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (IGNITE-11996) Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore

2019-07-19 Thread Ivan Pavlukhin (JIRA)


[ 
https://issues.apache.org/jira/browse/IGNITE-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16888580#comment-16888580
 ] 

Ivan Pavlukhin commented on IGNITE-11996:
-

Linked PR [#6705|https://github.com/apache/ignite/pull/6705] contains a code 
allowing to reproduce the issue easiliy.

> Assertion error in IgniteCacheOffheapManagerImpl#destroyCacheDataStore
> --
>
> Key: IGNITE-11996
> URL: https://issues.apache.org/jira/browse/IGNITE-11996
> Project: Ignite
>  Issue Type: Bug
>  Components: cache
>Affects Versions: 2.7.5
>Reporter: Ivan Pavlukhin
>Assignee: Ivan Pavlukhin
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Assertion error occurs in a following code:
> {code}
> boolean removed = partDataStores.remove(p, store);
> assert removed;
> {code}
> It asserts that a partition store must be removed from a map here. But in 
> practice a removal can occur at least in 2 places: node stop and partition 
> eviction. Employed synchronization is not sufficient to guarantee that a 
> removal happens exactly once.
> The issue is reproduced in {{IgniteSqlQueryMinMaxTest}} from time to time.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)