[jira] [Commented] (IGNITE-12032) Server node prints exception when ODBC driver disconnects
[
https://issues.apache.org/jira/browse/IGNITE-12032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929000#comment-16929000
]
Lev Agafonov commented on IGNITE-12032:
---
[~dmagda], thank you. All this messages are shown on the server node side.
> Server node prints exception when ODBC driver disconnects
> -
>
> Key: IGNITE-12032
> URL: https://issues.apache.org/jira/browse/IGNITE-12032
> Project: Ignite
> Issue Type: Bug
> Components: odbc
>Affects Versions: 2.7.5
>Reporter: Evgenii Zhuravlev
>Assignee: Lev Agafonov
>Priority: Major
> Labels: newbie, usability
> Fix For: 2.8
>
>
> Whenever a process using ODBC clients is finished, it's printing in the
> node logs this exception:
> {code:java}
> *[07:45:19,559][SEVERE][grid-nio-worker-client-listener-1-#30][ClientListenerProcessor]
>
> Failed to process selector key [s
> es=GridSelectorNioSessionImpl [worker=ByteBufferNioClientWorker
> [readBuf=java.nio.HeapByteBuffer[pos=0 lim=8192 cap=8192
> ], super=AbstractNioClientWorker [idx=1, bytesRcvd=0, bytesSent=0,
> bytesRcvd0=0, bytesSent0=0, select=true, super=GridWo
> rker [name=grid-nio-worker-client-listener-1, igniteInstanceName=null,
> finished=false, heartbeatTs=1564289118230, hashCo
> de=1829856117, interrupted=false,
> runner=grid-nio-worker-client-listener-1-#30]]], writeBuf=null,
> readBuf=null, inRecove
> ry=null, outRecovery=null, super=GridNioSessionImpl
> [locAddr=/0:0:0:0:0:0:0:1:10800, rmtAddr=/0:0:0:0:0:0:0:1:63697, cre
> ateTime=1564289116225, closeTime=0, bytesSent=1346, bytesRcvd=588,
> bytesSent0=0, bytesRcvd0=0, sndSchedTime=156428911623
> 5, lastSndTime=1564289116235, lastRcvTime=1564289116235, readsPaused=false,
> filterChain=FilterChain[filters=[GridNioAsyn
> cNotifyFilter, GridNioCodecFilter [parser=ClientListenerBufferedParser,
> directMode=false]], accepted=true, markedForClos
> e=false]]]
> java.io.IOException: An existing connection was forcibly closed by the
> remote host
> at sun.nio.ch.SocketDispatcher.read0(Native Method)
> at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43)
> at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
> at sun.nio.ch.IOUtil.read(IOUtil.java:197)
> at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$ByteBufferNioClientWorker.processRead(GridNioServer.java:11
>
> 04)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNi
>
> oServer.java:2389)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:215
>
> 6)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1797)
>
> at
> org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
> at java.lang.Thread.run(Thread.java:748)*
> {code}
> It's absolutely normal behavior when ODBC client disconnects from the node,
> so, we shouldn't print exception in the log. We should replace it with
> something like INFO message about ODBC client disconnection.
> Thread from user list:
> http://apache-ignite-users.70518.x6.nabble.com/exceptions-in-Ignite-node-when-a-thin-client-process-ends-td28970.html
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-12032) Server node prints exception when ODBC driver disconnects
[
https://issues.apache.org/jira/browse/IGNITE-12032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928886#comment-16928886
]
Denis Magda commented on IGNITE-12032:
--
[~levagafonov], good catch. Just to confirm, do we see these error messages on
the server node side or on the client end (JDBC, ODBC)? I'd like to adjust the
message text a bit.
> Server node prints exception when ODBC driver disconnects
> -
>
> Key: IGNITE-12032
> URL: https://issues.apache.org/jira/browse/IGNITE-12032
> Project: Ignite
> Issue Type: Bug
> Components: odbc
>Affects Versions: 2.7.5
>Reporter: Evgenii Zhuravlev
>Assignee: Lev Agafonov
>Priority: Major
> Labels: newbie, usability
> Fix For: 2.8
>
>
> Whenever a process using ODBC clients is finished, it's printing in the
> node logs this exception:
> {code:java}
> *[07:45:19,559][SEVERE][grid-nio-worker-client-listener-1-#30][ClientListenerProcessor]
>
> Failed to process selector key [s
> es=GridSelectorNioSessionImpl [worker=ByteBufferNioClientWorker
> [readBuf=java.nio.HeapByteBuffer[pos=0 lim=8192 cap=8192
> ], super=AbstractNioClientWorker [idx=1, bytesRcvd=0, bytesSent=0,
> bytesRcvd0=0, bytesSent0=0, select=true, super=GridWo
> rker [name=grid-nio-worker-client-listener-1, igniteInstanceName=null,
> finished=false, heartbeatTs=1564289118230, hashCo
> de=1829856117, interrupted=false,
> runner=grid-nio-worker-client-listener-1-#30]]], writeBuf=null,
> readBuf=null, inRecove
> ry=null, outRecovery=null, super=GridNioSessionImpl
> [locAddr=/0:0:0:0:0:0:0:1:10800, rmtAddr=/0:0:0:0:0:0:0:1:63697, cre
> ateTime=1564289116225, closeTime=0, bytesSent=1346, bytesRcvd=588,
> bytesSent0=0, bytesRcvd0=0, sndSchedTime=156428911623
> 5, lastSndTime=1564289116235, lastRcvTime=1564289116235, readsPaused=false,
> filterChain=FilterChain[filters=[GridNioAsyn
> cNotifyFilter, GridNioCodecFilter [parser=ClientListenerBufferedParser,
> directMode=false]], accepted=true, markedForClos
> e=false]]]
> java.io.IOException: An existing connection was forcibly closed by the
> remote host
> at sun.nio.ch.SocketDispatcher.read0(Native Method)
> at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43)
> at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
> at sun.nio.ch.IOUtil.read(IOUtil.java:197)
> at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$ByteBufferNioClientWorker.processRead(GridNioServer.java:11
>
> 04)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNi
>
> oServer.java:2389)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:215
>
> 6)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1797)
>
> at
> org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
> at java.lang.Thread.run(Thread.java:748)*
> {code}
> It's absolutely normal behavior when ODBC client disconnects from the node,
> so, we shouldn't print exception in the log. We should replace it with
> something like INFO message about ODBC client disconnection.
> Thread from user list:
> http://apache-ignite-users.70518.x6.nabble.com/exceptions-in-Ignite-node-when-a-thin-client-process-ends-td28970.html
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-12139) RPM for 2.7.5 release built from incorrect version
[
https://issues.apache.org/jira/browse/IGNITE-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928884#comment-16928884
]
Denis Magda commented on IGNITE-12139:
--
[~vveider], sure, please go ahead. I think that's the only way we can fix the
issue with the released version.
> RPM for 2.7.5 release built from incorrect version
> --
>
> Key: IGNITE-12139
> URL: https://issues.apache.org/jira/browse/IGNITE-12139
> Project: Ignite
> Issue Type: Bug
> Components: build
>Affects Versions: 2.7.5
>Reporter: Jan Kupec
>Assignee: Dmitriy Pavlov
>Priority: Minor
>
> The {{apache-ignite-2.7.5}} RPM found in the [official RPM
> repository|https://ignite.apache.org/download.cgi#rpm-package] has been built
> from commit *{{c9521338}}*, which is several weeks of development away from
> the head of the {{ignite-2.7.5}} release branch (*{{be4f2a15}}*) and
> apparently contains incompatible changes.
> Is this a result of a human error or an error in the automated build system?
> Can this easily be fixed?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (IGNITE-7197) Premature access to services() causes NullPointerException
[
https://issues.apache.org/jira/browse/IGNITE-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Kasnacheev updated IGNITE-7197:
Fix Version/s: 2.4
> Premature access to services() causes NullPointerException
> --
>
> Key: IGNITE-7197
> URL: https://issues.apache.org/jira/browse/IGNITE-7197
> Project: Ignite
> Issue Type: Bug
> Components: managed services
>Affects Versions: 2.3
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
> Fix For: 2.4
>
>
> {code}
> Caused by: java.lang.NullPointerException
> at
> org.apache.ignite.internal.processors.service.GridServiceProcessor.serviceEntries(GridServiceProcessor.java:1289)
> at
> org.apache.ignite.internal.processors.service.GridServiceProcessor.serviceDescriptors(GridServiceProcessor.java:762)
> at
> org.apache.ignite.internal.IgniteServicesImpl.serviceDescriptors(IgniteServicesImpl.java:203)
> at
> org.apache.ignite.internal.visor.service.VisorServiceTask$VisorServiceJob.run(VisorServiceTask.java:60)
> at
> org.apache.ignite.internal.visor.service.VisorServiceTask$VisorServiceJob.run(VisorServiceTask.java:44)
> at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
> {code}
> Happens with non-Visor jobs and callables, too!
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (IGNITE-9409) yarn IgniteProvider uses an obsolete URL for a version check
[ https://issues.apache.org/jira/browse/IGNITE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kasnacheev updated IGNITE-9409: Fix Version/s: 2.8 > yarn IgniteProvider uses an obsolete URL for a version check > > > Key: IGNITE-9409 > URL: https://issues.apache.org/jira/browse/IGNITE-9409 > Project: Ignite > Issue Type: Bug > Components: yarn >Reporter: Roman Shtykh >Assignee: Ilya Kasnacheev >Priority: Major > Fix For: 2.8 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-12153) Control.sh add test for checking that help and cache help output are not broken.
[ https://issues.apache.org/jira/browse/IGNITE-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928590#comment-16928590 ] Sergey Antonov commented on IGNITE-12153: - [~DmitriyGovorukhin] Could you review my changes too please? > Control.sh add test for checking that help and cache help output are not > broken. > > > Key: IGNITE-12153 > URL: https://issues.apache.org/jira/browse/IGNITE-12153 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Antonov >Assignee: Sergey Antonov >Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > We should store "ideal" outputs in resorces and compare with current. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-9409) yarn IgniteProvider uses an obsolete URL for a version check
[ https://issues.apache.org/jira/browse/IGNITE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928564#comment-16928564 ] Alexey Goncharuk commented on IGNITE-9409: -- [~ilyak] [~shroman] folks, please set fix version when resolving a ticket. > yarn IgniteProvider uses an obsolete URL for a version check > > > Key: IGNITE-9409 > URL: https://issues.apache.org/jira/browse/IGNITE-9409 > Project: Ignite > Issue Type: Bug > Components: yarn >Reporter: Roman Shtykh >Assignee: Ilya Kasnacheev >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928552#comment-16928552 ] Alexey Goncharuk commented on IGNITE-11708: --- [~ivanan.fed] [~Pavlukhin] please set fix versions when resolving tickets. > Unable to run tests in IgniteConfigVariationsAbstractTest subclasses > > > Key: IGNITE-11708 > URL: https://issues.apache.org/jira/browse/IGNITE-11708 > Project: Ignite > Issue Type: Bug >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Attachments: read_through_eviction_self_test.patch, > tx_out_test_fixed.patch > > Time Spent: 4h > Remaining Estimate: 0h > > It seems that test classes that extend from > IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test > annotation. > It is easy to check: if throw exception in any test methods, nothing will > happen. > Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], > maybe it destroys existing test workflow. > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (IGNITE-11708) Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
[ https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Goncharuk updated IGNITE-11708: -- Fix Version/s: 2.8 > Unable to run tests in IgniteConfigVariationsAbstractTest subclasses > > > Key: IGNITE-11708 > URL: https://issues.apache.org/jira/browse/IGNITE-11708 > Project: Ignite > Issue Type: Bug >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Fix For: 2.8 > > Attachments: read_through_eviction_self_test.patch, > tx_out_test_fixed.patch > > Time Spent: 4h > Remaining Estimate: 0h > > It seems that test classes that extend from > IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test > annotation. > It is easy to check: if throw exception in any test methods, nothing will > happen. > Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], > maybe it destroys existing test workflow. > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Reopened] (IGNITE-12002) [TTL] Some expired data remains in memory even with eager TTL enabled
[ https://issues.apache.org/jira/browse/IGNITE-12002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Goncharuk reopened IGNITE-12002: --- > [TTL] Some expired data remains in memory even with eager TTL enabled > - > > Key: IGNITE-12002 > URL: https://issues.apache.org/jira/browse/IGNITE-12002 > Project: Ignite > Issue Type: Bug > Components: cache, general >Affects Versions: 2.7 > Environment: Running on MacOS 10.12.6 > OpenJDK 11 > Ignite v2.7.0 > >Reporter: Philippe Anes >Priority: Major > Fix For: 2.8 > > > Create an ignite client (in client mode false) and put some data (10k > entries/values) to it with very small expiration time (~20s) and TTL enabled. > Each time the thread is running it'll remove all the entries that expired, > but after few attempts this thread is not removing all the expired entries, > some of them are staying in memory and are not removed by this thread > execution. > That means we got some expired data in memory, and it's something we want to > avoid. > Please can you confirm that is a real issue or just misuse/configuration of > my test? > Thanks for your feedback. > > To reproduce: > Git repo: [https://github.com/panes/ignite-sample] > Run MyIgniteLoadRunnerTest.run() to reproduce the issue described on top. > (Global setup: Writing 10k entries of 64octets each with TTL 10s) -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-12153) Control.sh add test for checking that help and cache help output are not broken.
[ https://issues.apache.org/jira/browse/IGNITE-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928520#comment-16928520 ] Denis Chudov commented on IGNITE-12153: --- [~antonovsergey93] looks good to me. > Control.sh add test for checking that help and cache help output are not > broken. > > > Key: IGNITE-12153 > URL: https://issues.apache.org/jira/browse/IGNITE-12153 > Project: Ignite > Issue Type: Bug >Reporter: Sergey Antonov >Assignee: Sergey Antonov >Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > We should store "ideal" outputs in resorces and compare with current. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (IGNITE-12165) Negative time in Transaction time dump
[
https://issues.apache.org/jira/browse/IGNITE-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denis Chudov updated IGNITE-12165:
--
Description:
After implementing ticket IGNITE-12063 we have transaction dumps in the logs.
there are some issues with information in these dumps:
{code:java}
[11:53:36,154][INFO][snapshot-scheduler-restats-#69][GridNearTxLocal]
Transaction time dump [startTime=11:53:36.081, totalTime=65, systemTime=3,
userTime=62, cacheOperationsTime=-41943785508, rollbackTime=41943785512,
tx=GridNearTxLocal [mappings=IgniteTxMappingsImpl [], nearLocallyMapped=false,
colocatedLocallyMapped=false, needCheckBackup=null, hasRemoteLocks=true,
trackTimeout=false, systemTime=3953576, systemStartTime=0, prepareStartTime=0,
prepareTime=0, commitOrRollbackStartTime=0,
commitOrRollbackTime=41943785512318555,
txDumpsThrottling=org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager$TxDumpsThrottling@760d8025,
lb=null, thread=snapshot-scheduler-restats-#69, mappings=IgniteTxMappingsImpl
[], super=GridDhtTxLocalAdapter [nearOnOriginatingNode=false,
nearNodes=KeySetView [], dhtNodes=KeySetView [], explicitLock=false,
super=IgniteTxLocalAdapter [completedBase=null, sndTransformedVals=false,
depEnabled=false, txState=IgniteTxStateImpl [activeCacheIds=[-2100569601],
recovery=false, txMap=HashSet [IgniteTxEntry [key=KeyCacheObjectImpl [part=2,
val=SnapshotScheduleKey [id=_SCHEDULES_], hasValBytes=true],
cacheId=-2100569601, txKey=IgniteTxKey [key=KeyCacheObjectImpl [part=2,
val=SnapshotScheduleKey [id=_SCHEDULES_], hasValBytes=true],
cacheId=-2100569601], val=[op=READ, val=null], prevVal=[op=NOOP, val=null],
oldVal=[op=NOOP, val=null], entryProcessorsCol=null, ttl=-1,
conflictExpireTime=-1, conflictVer=null, explicitVer=null, dhtVer=null,
filters=null, filtersPassed=false, filtersSet=true, entry=GridCacheMapEntry
[key=KeyCacheObjectImpl [part=2, val=SnapshotScheduleKey [id=_SCHEDULES_],
hasValBytes=true], val=null, ver=GridCacheVersion [topVer=0, order=0,
nodeOrder=0], hash=886348002, extras=null, flags=0]GridDistributedCacheEntry
[super=]GridDhtDetachedCacheEntry [super=], prepared=0, locked=true,
nodeId=1adbae78-40fe-480d-803d-4d498919ae63, locMapped=false, expiryPlc=null,
transferExpiryPlc=false, flags=0, partUpdateCntr=0, serReadVer=null,
xidVer=GridCacheVersion [topVer=179672005, order=1568192005565,
nodeOrder=1, super=IgniteTxAdapter [xidVer=GridCacheVersion
[topVer=179672005, order=1568192005565, nodeOrder=1], writeVer=null,
implicit=false, loc=true, threadId=125, startTime=1568192016081,
nodeId=9e00ae45-4084-4f29-949f-c19c933f4299, startVer=GridCacheVersion
[topVer=179672005, order=1568192005565, nodeOrder=1], endVer=null,
isolation=REPEATABLE_READ, concurrency=PESSIMISTIC, timeout=0,
sysInvalidate=false, sys=true, plc=5, commitVer=null, finalizing=NONE,
invalidParts=null, state=ROLLED_BACK, timedOut=false,
topVer=AffinityTopologyVersion [topVer=4, minorTopVer=1], duration=60ms,
onePhaseCommit=false], size=1
{code}
For example:
# Negative time: cacheOperationsTime=-41943785508,
# Huge times: rollbackTime=41943785512
was:
After implementing ticket https://ggsystems.atlassian.net/browse/GG-21272 we
have transaction dumps in the logs.
there are some issues with information in these dumps:
{code:java}
[11:53:36,154][INFO][snapshot-scheduler-restats-#69][GridNearTxLocal]
Transaction time dump [startTime=11:53:36.081, totalTime=65, systemTime=3,
userTime=62, cacheOperationsTime=-41943785508, rollbackTime=41943785512,
tx=GridNearTxLocal [mappings=IgniteTxMappingsImpl [], nearLocallyMapped=false,
colocatedLocallyMapped=false, needCheckBackup=null, hasRemoteLocks=true,
trackTimeout=false, systemTime=3953576, systemStartTime=0, prepareStartTime=0,
prepareTime=0, commitOrRollbackStartTime=0,
commitOrRollbackTime=41943785512318555,
txDumpsThrottling=org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager$TxDumpsThrottling@760d8025,
lb=null, thread=snapshot-scheduler-restats-#69, mappings=IgniteTxMappingsImpl
[], super=GridDhtTxLocalAdapter [nearOnOriginatingNode=false,
nearNodes=KeySetView [], dhtNodes=KeySetView [], explicitLock=false,
super=IgniteTxLocalAdapter [completedBase=null, sndTransformedVals=false,
depEnabled=false, txState=IgniteTxStateImpl [activeCacheIds=[-2100569601],
recovery=false, txMap=HashSet [IgniteTxEntry [key=KeyCacheObjectImpl [part=2,
val=SnapshotScheduleKey [id=_SCHEDULES_], hasValBytes=true],
cacheId=-2100569601, txKey=IgniteTxKey [key=KeyCacheObjectImpl [part=2,
val=SnapshotScheduleKey [id=_SCHEDULES_], hasValBytes=true],
cacheId=-2100569601], val=[op=READ, val=null], prevVal=[op=NOOP, val=null],
oldVal=[op=NOOP, val=null], entryProcessorsCol=null, ttl=-1,
conflictExpireTime=-1, conflictVer=null, explicitVer=null, dhtVer=null,
filters=null, filtersPassed=false, filtersSet=true, entry=GridCacheMapEntry
[jira] [Commented] (IGNITE-12054) Upgrade Spark module to 2.4
[ https://issues.apache.org/jira/browse/IGNITE-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928509#comment-16928509 ] Nikolay Izhikov commented on IGNITE-12054: -- OK, Let's try it. [~zaleslaw] Can you start the discussion on dev-list? > Upgrade Spark module to 2.4 > --- > > Key: IGNITE-12054 > URL: https://issues.apache.org/jira/browse/IGNITE-12054 > Project: Ignite > Issue Type: Task > Components: spark >Affects Versions: 2.7.5 >Reporter: Denis Magda >Assignee: Nikolay Izhikov >Priority: Blocker > Fix For: 2.8 > > > Users can't use APIs that are already available in Spark 2.4: > https://stackoverflow.com/questions/57392143/persisting-spark-dataframe-to-ignite > Let's upgrade Spark from 2.3 to 2.4 until we extract the Spark Integration as > a separate module that can support multiple Spark versions. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (IGNITE-10364) .NET: FailureHandlerTest should be reworked
[
https://issues.apache.org/jira/browse/IGNITE-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pavel Tupitsyn updated IGNITE-10364:
Summary: .NET: FailureHandlerTest should be reworked (was: .Net:
FailureHandlerTest should be reworked)
> .NET: FailureHandlerTest should be reworked
> ---
>
> Key: IGNITE-10364
> URL: https://issues.apache.org/jira/browse/IGNITE-10364
> Project: Ignite
> Issue Type: Test
> Components: platforms
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Priority: Minor
> Labels: .NET
>
> Currently, {{FailureHandlerTest}} uses a broken {{CacheStoreFactory}} in
> order to trigger the execution of {{FailureHandler}} when a cache with the
> given factory is created. https://issues.apache.org/jira/browse/IGNITE-8640
> provides a fix that initiates rollback procedure in that case and so, does
> not trigger {{FailureHandler}}
> So, the test should use another approach to test {{FailureHandler}}. It seems
> {{IoomFailureHandlerTest}} can be used as a starting point.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Assigned] (IGNITE-10364) .NET: FailureHandlerTest should be reworked
[
https://issues.apache.org/jira/browse/IGNITE-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pavel Tupitsyn reassigned IGNITE-10364:
---
Assignee: Pavel Tupitsyn
> .NET: FailureHandlerTest should be reworked
> ---
>
> Key: IGNITE-10364
> URL: https://issues.apache.org/jira/browse/IGNITE-10364
> Project: Ignite
> Issue Type: Test
> Components: platforms
>Affects Versions: 2.7
>Reporter: Vyacheslav Koptilin
>Assignee: Pavel Tupitsyn
>Priority: Minor
> Labels: .NET
>
> Currently, {{FailureHandlerTest}} uses a broken {{CacheStoreFactory}} in
> order to trigger the execution of {{FailureHandler}} when a cache with the
> given factory is created. https://issues.apache.org/jira/browse/IGNITE-8640
> provides a fix that initiates rollback procedure in that case and so, does
> not trigger {{FailureHandler}}
> So, the test should use another approach to test {{FailureHandler}}. It seems
> {{IoomFailureHandlerTest}} can be used as a starting point.
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (IGNITE-12167) Move resetting of BPlusTree.pageHndWrapper to GridAbstractTest
[
https://issues.apache.org/jira/browse/IGNITE-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denis Chudov updated IGNITE-12167:
--
Summary: Move resetting of BPlusTree.pageHndWrapper to GridAbstractTest
(was: H2TreeCorruptedTreeExceptionTest doesn't clear custom
BPlusTree.pageHndWrapper in after test)
> Move resetting of BPlusTree.pageHndWrapper to GridAbstractTest
> --
>
> Key: IGNITE-12167
> URL: https://issues.apache.org/jira/browse/IGNITE-12167
> Project: Ignite
> Issue Type: Improvement
>Reporter: Denis Chudov
>Assignee: Denis Chudov
>Priority: Major
>
> We should move logic for clearing custom pageHndWrapperin
> {{afterTestsStopped()}} in {{GridCommonAbstractTest}} or {{GridAbstractTest
> to ensure that we will not have problems in any tests which set custom
> wrapper}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (IGNITE-12167) H2TreeCorruptedTreeExceptionTest doesn't clear custom BPlusTree.pageHndWrapper in after test
[
https://issues.apache.org/jira/browse/IGNITE-12167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Denis Chudov updated IGNITE-12167:
--
Summary: H2TreeCorruptedTreeExceptionTest doesn't clear custom
BPlusTree.pageHndWrapper in after test (was: I think we should add logic for
clearing custom pageHndWrapper in afterTestsStopped() in GridCommonAbstractTest
or GridAbstractTest https://ggtc.gridgain.com/viewLog.html?buildId=2364333)
> H2TreeCorruptedTreeExceptionTest doesn't clear custom
> BPlusTree.pageHndWrapper in after test
>
>
> Key: IGNITE-12167
> URL: https://issues.apache.org/jira/browse/IGNITE-12167
> Project: Ignite
> Issue Type: Improvement
>Reporter: Denis Chudov
>Assignee: Denis Chudov
>Priority: Major
>
> We should move logic for clearing custom pageHndWrapperin
> {{afterTestsStopped()}} in {{GridCommonAbstractTest}} or {{GridAbstractTest
> to ensure that we will not have problems in any tests which set custom
> wrapper}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (IGNITE-12167) I think we should add logic for clearing custom pageHndWrapper in afterTestsStopped() in GridCommonAbstractTest or GridAbstractTest https://ggtc.gridgain.com/viewLog.ht
Denis Chudov created IGNITE-12167:
-
Summary: I think we should add logic for clearing custom
pageHndWrapper in afterTestsStopped() in GridCommonAbstractTest or
GridAbstractTest https://ggtc.gridgain.com/viewLog.html?buildId=2364333
Key: IGNITE-12167
URL: https://issues.apache.org/jira/browse/IGNITE-12167
Project: Ignite
Issue Type: Improvement
Reporter: Denis Chudov
Assignee: Denis Chudov
We should move logic for clearing custom pageHndWrapperin
{{afterTestsStopped()}} in {{GridCommonAbstractTest}} or {{GridAbstractTest to
ensure that we will not have problems in any tests which set custom wrapper}}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-12027) NPE on try to read the MinimumNumberOfPartitionCopies metric.
[
https://issues.apache.org/jira/browse/IGNITE-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928439#comment-16928439
]
Ignite TC Bot commented on IGNITE-12027:
{panel:title=Branch: [pull/6738/head] Base: [master] : No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=457buildTypeId=IgniteTests24Java8_RunAll]
> NPE on try to read the MinimumNumberOfPartitionCopies metric.
> -
>
> Key: IGNITE-12027
> URL: https://issues.apache.org/jira/browse/IGNITE-12027
> Project: Ignite
> Issue Type: Bug
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
> Labels: IEP-35
> Fix For: 2.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> NPE on try to read the MinimumNumberOfPartitionCopies metric before node
> starts.
> Details:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.ignite.internal.processors.cache.CacheGroupMetricsImpl.numberOfPartitionCopies(CacheGroupMetricsImpl.java:218)
> at
> org.apache.ignite.internal.processors.cache.CacheGroupMetricsImpl.getMinimumNumberOfPartitionCopies(CacheGroupMetricsImpl.java:232)
> at
> org.apache.ignite.internal.util.lang.GridFunc.lambda$nonThrowableSupplier$2(GridFunc.java:3302)
> at
> org.apache.ignite.internal.processors.metric.impl.IntGauge.value(IntGauge.java:45)
> at
> org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi.lambda$null$5(OpenCensusMetricExporterSpi.java:152)
> at java.lang.Iterable.forEach(Iterable.java:75)
> at
> org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi.lambda$export$6(OpenCensusMetricExporterSpi.java:141)
> at java.lang.Iterable.forEach(Iterable.java:75)
> at
> org.apache.ignite.spi.metric.opencensus.OpenCensusMetricExporterSpi.export(OpenCensusMetricExporterSpi.java:137)
> at
> org.apache.ignite.internal.processors.metric.PushMetricsExporterAdapter.lambda$spiStart$0(PushMetricsExporterAdapter.java:57)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> Reason: {{GridDhtPartitionFullMap partFullMap =
> ctx.topology().partitionMap(false);}} is null.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Created] (IGNITE-12166) .NET: ExecutableTest fails with PathTooLong error
Pavel Tupitsyn created IGNITE-12166: --- Summary: .NET: ExecutableTest fails with PathTooLong error Key: IGNITE-12166 URL: https://issues.apache.org/jira/browse/IGNITE-12166 Project: Ignite Issue Type: Bug Components: platforms Reporter: Pavel Tupitsyn Assignee: Pavel Tupitsyn When repo root path is long enough, it causes ExecutableTests to fail - classpath exceeds Win32 limit of 32767 characters. If fact, we don't need to pass classpath explicitly to IgniteProcess. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (IGNITE-12166) .NET: ExecutableTest fails with PathTooLong error
[ https://issues.apache.org/jira/browse/IGNITE-12166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Tupitsyn updated IGNITE-12166: Ignite Flags: (was: Docs Required,Release Notes Required) > .NET: ExecutableTest fails with PathTooLong error > - > > Key: IGNITE-12166 > URL: https://issues.apache.org/jira/browse/IGNITE-12166 > Project: Ignite > Issue Type: Bug > Components: platforms >Reporter: Pavel Tupitsyn >Assignee: Pavel Tupitsyn >Priority: Major > Labels: .NET > > When repo root path is long enough, it causes ExecutableTests to fail - > classpath exceeds Win32 limit of 32767 characters. If fact, we don't need to > pass classpath explicitly to IgniteProcess. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-11094) Add SSL support for ignite zookeeper SPI
[ https://issues.apache.org/jira/browse/IGNITE-11094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928391#comment-16928391 ] Pavel Kovalenko commented on IGNITE-11094: -- [~SomeFire] I've several minor concerns about the change and left comments in PR. Please resolve them. > Add SSL support for ignite zookeeper SPI > > > Key: IGNITE-11094 > URL: https://issues.apache.org/jira/browse/IGNITE-11094 > Project: Ignite > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Sergey Kozlov >Assignee: Ryabov Dmitrii >Priority: Major > Fix For: 2.8 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > ZK 3.5.4-beta is already supporting SSL [1]. We should add SSL support to ZK > server connections if Zookeeper SPI used. > 1. > https://cwiki.apache.org/confluence/display/ZOOKEEPER/ZooKeeper+SSL+User+Guide -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (IGNITE-12147) Thin client: Partitions response doesn't contain caches for which affinity awareness is not applicable
[ https://issues.apache.org/jira/browse/IGNITE-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928357#comment-16928357 ] Pavel Tupitsyn commented on IGNITE-12147: - [~alex_pl] thanks, looks good to me now. > Thin client: Partitions response doesn't contain caches for which affinity > awareness is not applicable > -- > > Key: IGNITE-12147 > URL: https://issues.apache.org/jira/browse/IGNITE-12147 > Project: Ignite > Issue Type: Bug > Components: thin client >Reporter: Aleksey Plekhanov >Assignee: Aleksey Plekhanov >Priority: Major > Labels: iep-23 > Time Spent: 0.5h > Remaining Estimate: 0h > > Partitions response never contains caches for which affinity awareness is not > applicable (unlike specified by the protocol) even if information for these > caches was explicitly requested. > .NET thin client also fails while processing messages for caches without > partitions information. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Assigned] (IGNITE-12032) Server node prints exception when ODBC driver disconnects
[
https://issues.apache.org/jira/browse/IGNITE-12032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lev Agafonov reassigned IGNITE-12032:
-
Assignee: Lev Agafonov
> Server node prints exception when ODBC driver disconnects
> -
>
> Key: IGNITE-12032
> URL: https://issues.apache.org/jira/browse/IGNITE-12032
> Project: Ignite
> Issue Type: Bug
> Components: odbc
>Affects Versions: 2.7.5
>Reporter: Evgenii Zhuravlev
>Assignee: Lev Agafonov
>Priority: Major
> Labels: newbie, usability
> Fix For: 2.8
>
>
> Whenever a process using ODBC clients is finished, it's printing in the
> node logs this exception:
> {code:java}
> *[07:45:19,559][SEVERE][grid-nio-worker-client-listener-1-#30][ClientListenerProcessor]
>
> Failed to process selector key [s
> es=GridSelectorNioSessionImpl [worker=ByteBufferNioClientWorker
> [readBuf=java.nio.HeapByteBuffer[pos=0 lim=8192 cap=8192
> ], super=AbstractNioClientWorker [idx=1, bytesRcvd=0, bytesSent=0,
> bytesRcvd0=0, bytesSent0=0, select=true, super=GridWo
> rker [name=grid-nio-worker-client-listener-1, igniteInstanceName=null,
> finished=false, heartbeatTs=1564289118230, hashCo
> de=1829856117, interrupted=false,
> runner=grid-nio-worker-client-listener-1-#30]]], writeBuf=null,
> readBuf=null, inRecove
> ry=null, outRecovery=null, super=GridNioSessionImpl
> [locAddr=/0:0:0:0:0:0:0:1:10800, rmtAddr=/0:0:0:0:0:0:0:1:63697, cre
> ateTime=1564289116225, closeTime=0, bytesSent=1346, bytesRcvd=588,
> bytesSent0=0, bytesRcvd0=0, sndSchedTime=156428911623
> 5, lastSndTime=1564289116235, lastRcvTime=1564289116235, readsPaused=false,
> filterChain=FilterChain[filters=[GridNioAsyn
> cNotifyFilter, GridNioCodecFilter [parser=ClientListenerBufferedParser,
> directMode=false]], accepted=true, markedForClos
> e=false]]]
> java.io.IOException: An existing connection was forcibly closed by the
> remote host
> at sun.nio.ch.SocketDispatcher.read0(Native Method)
> at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43)
> at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
> at sun.nio.ch.IOUtil.read(IOUtil.java:197)
> at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$ByteBufferNioClientWorker.processRead(GridNioServer.java:11
>
> 04)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNi
>
> oServer.java:2389)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:215
>
> 6)
> at
> org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1797)
>
> at
> org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
> at java.lang.Thread.run(Thread.java:748)*
> {code}
> It's absolutely normal behavior when ODBC client disconnects from the node,
> so, we shouldn't print exception in the log. We should replace it with
> something like INFO message about ODBC client disconnection.
> Thread from user list:
> http://apache-ignite-users.70518.x6.nabble.com/exceptions-in-Ignite-node-when-a-thin-client-process-ends-td28970.html
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (IGNITE-12032) Server node prints exception when ODBC driver disconnects
[
https://issues.apache.org/jira/browse/IGNITE-12032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928286#comment-16928286
]
Lev Agafonov commented on IGNITE-12032:
---
Denis, thank you for helping me :)
I go deeper and could also reproduce exactly same stack trace against JDBC thin
client.
The test:
{code:java}
import java.sql._
import org.scalatest.{FunSuite, Matchers}
class JdbcTest extends FunSuite with Matchers {
test("Jdbc incorrect session close test") {
val igniteHost = "*.*.*.*"
val ignitePort = "10800"
Class.forName("org.apache.ignite.IgniteJdbcThinDriver")
val t = new Thread() {
override def run() = {
val conn =
DriverManager.getConnection(s"jdbc:ignite:thin://${igniteHost}:${ignitePort}")
//conn.close()
}
}
t.start()
Thread.sleep(100)
t.interrupt()
}
}{code}
The stack trace:
{code:java}
[12-Sep-2019
09:18:13][ERROR][grid-nio-worker-client-listener-0-#29][ClientListenerProcessor]
Failed to process selector key [ses=GridSelectorNioSessionImpl
[worker=ByteBufferNioClientWorker [readBuf=java.nio.HeapByteBuffer[pos=0
lim=8192 cap=8192], super=AbstractNioClientWorker [idx=0, bytesRcvd=0,
bytesSent=0, bytesRcvd0=0, bytesSent0=0, select=true, super=GridWorker
[name=grid-nio-worker-client-listener-0, igniteInstanceName=null,
finished=false, heartbeatTs=1568269092688, hashCode=1630725146,
interrupted=false, runner=grid-nio-worker-client-listener-0-#29]]],
writeBuf=null, readBuf=null, inRecovery=null, outRecovery=null,
closeSocket=true, super=GridNioSessionImpl [locAddr=/*.*.*.*:10800,
rmtAddr=/*.*.*.*:59186, createTime=1568269092688, closeTime=0, bytesSent=0,
bytesRcvd=0, bytesSent0=0, bytesRcvd0=0, sndSchedTime=1568269092688,
lastSndTime=1568269092688, lastRcvTime=1568269092688, readsPaused=false,
filterChain=FilterChain[filters=[GridNioAsyncNotifyFilter, GridNioCodecFilter
[parser=ClientListenerBufferedParser, directMode=false]], accepted=true,
markedForClose=false]]]
java.io.IOException: An existing connection was forcibly closed by the remote
host
at sun.nio.ch.SocketDispatcher.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
at sun.nio.ch.IOUtil.read(IOUtil.java:197)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380)
at
org.apache.ignite.internal.util.nio.GridNioServer$ByteBufferNioClientWorker.processRead(GridNioServer.java:1120)
at
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.processSelectedKeysOptimized(GridNioServer.java:2407)
at
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.bodyInternal(GridNioServer.java:2174)
at
org.apache.ignite.internal.util.nio.GridNioServer$AbstractNioClientWorker.body(GridNioServer.java:1815)
at
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
at java.lang.Thread.run(Thread.java:748)
[12-Sep-2019 09:18:13][WARN
][grid-nio-worker-client-listener-0-#29][ClientListenerProcessor] Closing NIO
session because of unhandled exception [cls=class
o.a.i.i.util.nio.GridNioException, msg=An existing connection was forcibly
closed by the remote host]
{code}
So, my suggestion that this kind of problem doesn't related to Odbc module, but
to Core one.
If I do call conn.close() method - no errors are thrown in both JDBC and ODBC
connections.
I think it will be good enough to make a small patch, making things more clear
by changing current WARN message:
"Closing NIO session because of unhandled exception"
to something like
"Network connection lost, closing NIO connection. Please, check database
connection is closed in safe manner, by calling connection.close() method"
> Server node prints exception when ODBC driver disconnects
> -
>
> Key: IGNITE-12032
> URL: https://issues.apache.org/jira/browse/IGNITE-12032
> Project: Ignite
> Issue Type: Bug
> Components: odbc
>Affects Versions: 2.7.5
>Reporter: Evgenii Zhuravlev
>Priority: Major
> Labels: newbie, usability
> Fix For: 2.8
>
>
> Whenever a process using ODBC clients is finished, it's printing in the
> node logs this exception:
> {code:java}
> *[07:45:19,559][SEVERE][grid-nio-worker-client-listener-1-#30][ClientListenerProcessor]
>
> Failed to process selector key [s
> es=GridSelectorNioSessionImpl [worker=ByteBufferNioClientWorker
> [readBuf=java.nio.HeapByteBuffer[pos=0 lim=8192 cap=8192
> ], super=AbstractNioClientWorker [idx=1, bytesRcvd=0, bytesSent=0,
> bytesRcvd0=0, bytesSent0=0, select=true, super=GridWo
> rker [name=grid-nio-worker-client-listener-1, igniteInstanceName=null,
> finished=false,
[jira] [Commented] (IGNITE-11815) Get rid of GridTestUtils.retryAssert method.
[ https://issues.apache.org/jira/browse/IGNITE-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928281#comment-16928281 ] Diana Iakovleva commented on IGNITE-11815: -- [~amashenkov] I've updated PR, can you please take a look? > Get rid of GridTestUtils.retryAssert method. > > > Key: IGNITE-11815 > URL: https://issues.apache.org/jira/browse/IGNITE-11815 > Project: Ignite > Issue Type: Test >Reporter: Andrew Mashenkov >Assignee: Diana Iakovleva >Priority: Major > Labels: MakeTeamcityGreenAgain, newbie > Time Spent: 1.5h > Remaining Estimate: 0h > > For now we have GridTestUtils.retryAssert() method which runs a closure 'n' > times to check if some invariantes become ok, eventually. > This method catch assertion error (this looks like a very bad idea) and can > print them to log many times even if assertion is acceptable for the moment. > Also, it is possible to miss an assertion is not related to those ones that > closure checks (e.g. assertion error thrown from ignite internals). > Let's replace retryAssert with GridTestUtils.waitForCondition() usage to make > logs clearer and to avoid possible false positive results. -- This message was sent by Atlassian Jira (v8.3.2#803003)
