[jira] [Comment Edited] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062873#comment-17062873
]
Alexey edited comment on IGNITE-8152 at 3/19/20, 7:18 PM:
--
h4. [Taras
Ledkov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
could you help me.
I don’t understand what’s wrong. All my tests work and do not affect the
operation of other components of the application. Despite this, the TС shows
some problems. This is normal? or do I need to run the assembly with some
settings?
(I have done rebase, and I have actual repo)
Or I created a branch from an unstable version and get non-working tests of
other components
was (Author: aleksei_litsov):
h4. [Taras
Ledkov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
could you help me.
I don’t understand what’s wrong. All my tests work and do not affect the
operation of other components of the application. Despite this, the TС shows
some problems. This is normal? or do I need to run the assembly with some
settings?
(I have done rebase, and I have actual repo)
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Attachments: image-2020-03-19-16-01-42-979.png
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062873#comment-17062873
]
Alexey edited comment on IGNITE-8152 at 3/19/20, 7:10 PM:
--
h4. [Taras
Ledkov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
could you help me.
I don’t understand what’s wrong. All my tests work and do not affect the
operation of other components of the application. Despite this, the TС shows
some problems. This is normal? or do I need to run the assembly with some
settings?
(I have done rebase, and I have actual repo)
was (Author: aleksei_litsov):
h4. [Taras
Ledkov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
could you help me.
I don’t understand what’s wrong. All my tests work and do not affect the
operation of other components of the application. Despite this, the TС shows
some problems. This is normal? or do I need to run the assembly with some
settings?
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Attachments: image-2020-03-19-16-01-42-979.png
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062873#comment-17062873
]
Alexey commented on IGNITE-8152:
h4. [Taras
Ledkov|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
could you help me.
I don’t understand what’s wrong. All my tests work and do not affect the
operation of other components of the application. Despite this, the TС shows
some problems. This is normal? or do I need to run the assembly with some
settings?
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Attachments: image-2020-03-19-16-01-42-979.png
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062449#comment-17062449
]
Alexey edited comment on IGNITE-8152 at 3/19/20, 1:02 PM:
--
[~tledkov-gridgain], the code style has already been fixed. On TC tests passed
!image-2020-03-19-16-01-42-979.png|width=717,height=93!
was (Author: aleksei_litsov):
[~tledkov-gridgain], the code style has already been fixed. On TC tests passed
!image-2020-03-19-16-01-42-979.png!
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Attachments: image-2020-03-19-16-01-42-979.png
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062449#comment-17062449
]
Alexey edited comment on IGNITE-8152 at 3/19/20, 1:01 PM:
--
[~tledkov-gridgain], the code style has already been fixed. On TC tests passed
!image-2020-03-19-16-01-42-979.png!
was (Author: aleksei_litsov):
[~tledkov-gridgain], the code style has already been fixed. On TC tests passed
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Attachments: image-2020-03-19-16-01-42-979.png
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062449#comment-17062449
]
Alexey commented on IGNITE-8152:
[~tledkov-gridgain], the code style has already been fixed. On TC tests passed
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060731#comment-17060731
]
Alexey commented on IGNITE-8152:
[~amashenkov], I corrected everything
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058824#comment-17058824
]
Alexey commented on IGNITE-8152:
[~tledkov-gridgain], [~amashenkov]
I corrected the code for the ticket
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058651#comment-17058651
]
Alexey commented on IGNITE-8152:
[~amashenkov], thanks for the detailed answer. I will take a ticket for revision
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058164#comment-17058164
]
Alexey commented on IGNITE-8152:
[Taras|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=tledkov-gridgain],
thanks for the comments!
But if I correctly understood the current ticket, the user had the following
problem:
using construction \{ new SqlFieldsQuery ("some sql"). setSchema (""); }
the system throws an exception that "a scheme with an empty name cannot be
used".
And that an empty scheme is really - just a user error, and he wanted to use
the default scheme.
It is this problem that my patch solves - replacing "" to the default scheme.
Of course, I can add code that at the stage of creating the
scheme(SchemaManager#createSchema) will check the name of the scheme for
emptiness,
but it seems to me it's a different task and it is probably more correct to
create another ticket for this.
What do you think?
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexey reassigned IGNITE-8152:
--
Assignee: Alexey
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Assignee: Alexey
>Priority: Major
> Labels: newbie
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-8152) Forbid empty sql schema name
[
https://issues.apache.org/jira/browse/IGNITE-8152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056768#comment-17056768
]
Alexey commented on IGNITE-8152:
I am ready to take the IGNITE-8152 ticket to work
> Forbid empty sql schema name
>
>
> Key: IGNITE-8152
> URL: https://issues.apache.org/jira/browse/IGNITE-8152
> Project: Ignite
> Issue Type: Improvement
> Components: sql
>Reporter: Pavel Kuznetsov
>Priority: Major
> Labels: newbie
>
> Currently we allow empty schema name (quoted) in cache configuration
> org.apache.ignite.configuration.CacheConfiguration#setSqlSchema :
> {noformat}
> When sqlSchema is not specified, quoted cacheName is used instead.
> sqlSchema could not be an empty string. Has to be "\"\"" instead.
> Params:
> sqlSchema - Schema name for current cache according to SQL ANSI-99. Should
> not be null.
> {noformat}
> Specifying schema \"\" results in empty string schema name.
> No schema in sql query is treated as PUBLIC, but \"\" is regular schema name.
> It's better to disallow usage of \"\" schema
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (IGNITE-11843) [SQL] sqlline.sh trows NPE on invalid(inaccessible) JDBC URL on start
[ https://issues.apache.org/jira/browse/IGNITE-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052014#comment-17052014 ] Alexey commented on IGNITE-11843: - Is this issue still relevant? I am ready to take it to work. > [SQL] sqlline.sh trows NPE on invalid(inaccessible) JDBC URL on start > - > > Key: IGNITE-11843 > URL: https://issues.apache.org/jira/browse/IGNITE-11843 > Project: Ignite > Issue Type: Bug > Components: sql >Affects Versions: 2.7 >Reporter: Losevskoy Maxim >Priority: Minor > Labels: easyfix > Attachments: image-2019-05-11-23-29-21-399.png > > > Please see screenshot attached. > It would be preferable to see human-friendly message that URL is invalid/not > accessible -- This message was sent by Atlassian Jira (v8.3.4#803005)
