[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2018-04-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443814#comment-16443814
 ] 

ASF GitHub Bot commented on IGNITE-:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/2878


> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2018-04-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443813#comment-16443813
 ] 

Vladimir Ozerov commented on IGNITE-:
-

Pushed to master and 2.5 branches.

> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2018-04-10 Thread Aleksey Plekhanov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432176#comment-16432176
 ] 

Aleksey Plekhanov commented on IGNITE-:
---

[~NSAmelchev], I looked at your patch. Looks good to me.

> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Vladimir Ozerov
>Priority: Major
> Fix For: 2.5
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2018-01-19 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331965#comment-16331965
 ] 

Vladimir Ozerov commented on IGNITE-:
-

Moving to AI 2.5 due to scope freeze. Will review in the nearest time.

> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
> Fix For: 2.4
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2017-11-01 Thread Amelchev Nikita (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233791#comment-16233791
 ] 

Amelchev Nikita commented on IGNITE-:
-

[~vozerov], thank you for taking your time for the review, I have implemented 
read part symmetrical to the write-related part. Please, look at it again. 
[Tests|https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=projectOverview_Ignite20Tests=pull%2F2878%2Fhead]
 passed OK.

> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Security Level: Public(Viewable by anyone) 
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>Priority: Major
> Fix For: 2.4
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2017-10-30 Thread Vladimir Ozerov (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224466#comment-16224466
 ] 

Vladimir Ozerov commented on IGNITE-:
-

[~NSAmelchev], thank you for the patch. Write-related part looks good to me. 
However, it is not symmetrical to read part at the moment. We need to implement 
it as well, see
{{BinaryFieldImpl.readField}}.

> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Security Level: Public(Viewable by anyone) 
>  Components: binary
>Affects Versions: 2.2
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
> Fix For: 2.4
>
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (IGNITE-6666) BinaryObjectImpl.writeFieldByOrder method does not support TIME

2017-10-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/IGNITE-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209513#comment-16209513
 ] 

ASF GitHub Bot commented on IGNITE-:


GitHub user NSAmelchev opened a pull request:

https://github.com/apache/ignite/pull/2878

IGNITE-

Defined the variable totalLen for TIME type in method 
BinaryObjectImpl.writeFieldByOrder.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NSAmelchev/ignite ignite-

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/2878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2878


commit 727b47e704310cac7ae3cb4dc23a8153f48123d0
Author: NSAmelchev 
Date:   2017-10-18T15:09:52Z

add fix and test




> BinaryObjectImpl.writeFieldByOrder method does not support TIME
> ---
>
> Key: IGNITE-
> URL: https://issues.apache.org/jira/browse/IGNITE-
> Project: Ignite
>  Issue Type: Bug
>  Security Level: Public(Viewable by anyone) 
>  Components: binary
>Reporter: Amelchev Nikita
>Assignee: Amelchev Nikita
>
> The variable totalLen is not define for TIME in method 
> BinaryObjectImpl.writeFieldByOrder.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)