[jira] [Comment Edited] (IGNITE-12209) Transaction system view
[ https://issues.apache.org/jira/browse/IGNITE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940847#comment-16940847 ] Nikolay Izhikov edited comment on IGNITE-12209 at 9/30/19 10:49 AM: [~ascherbakov] > AFAIK call of the size can't fail. > There are absolutely no guarantee this would always work. Did you mean the execution of size can fail? Or we talking only about {{IgniteTxState#cacheIds}}? What kind of guarantees do you want to see? was (Author: nizhikov): > AFAIK call of the size can't fail. > There are absolutely no guarantee this would always work. Did you mean the execution of size can fail? Or we talking only about {{IgniteTxState#cacheIds}}? What kind of guarantees do you want to see? > Transaction system view > --- > > Key: IGNITE-12209 > URL: https://issues.apache.org/jira/browse/IGNITE-12209 > Project: Ignite > Issue Type: Sub-task >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > IGNITE-12145 finished > We should add transactions to the system views. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-12209) Transaction system view
[ https://issues.apache.org/jira/browse/IGNITE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940709#comment-16940709 ] Alexei Scherbakov edited comment on IGNITE-12209 at 9/30/19 7:37 AM: - [~nizhikov] Note what org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#allEntries and org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#cacheIds are unsynchronized and tx state can be concurrently updated if a transaction enlists keys in the moment of view producing. So current implementation is unsafe but probably will work somehow. I suggest to enclose methods in try .. catch(Throwable) to implement fallback in case something goes wrong. was (Author: ascherbakov): [~nizhikov] Note what org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#allEntries and org.apache.ignite.internal.processors.cache.transactions.IgniteTxState#cacheIds are unsynchronized and can be concurrently updated if a transaction enlists keys in the moment of view producing. So current implementation is unsafe but probably will work somehow. I suggest to enclose methods in try .. catch(Throwable) to implement fallback in case something goes wrong. > Transaction system view > --- > > Key: IGNITE-12209 > URL: https://issues.apache.org/jira/browse/IGNITE-12209 > Project: Ignite > Issue Type: Sub-task >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > IGNITE-12145 finished > We should add transactions to the system views. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (IGNITE-12209) Transaction system view
[ https://issues.apache.org/jira/browse/IGNITE-12209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939571#comment-16939571 ] Nikolay Izhikov edited comment on IGNITE-12209 at 9/27/19 4:03 PM: --- Hello, [~ascherbakov] Thanks for the review. WIll add properties, shortly. > Would it be possible to construct whole distributed transaction using SQL > joins (joining by parent and local node) ? For now, We export only local data in metrics and system views. So, the answer is no, I think. was (Author: nizhikov): Hello, [~ascherbakov] Thanks for the review. WIll add properties, shortly. > Would it be possible to construct whole distributed transaction using SQL > joins (joining by parent and local node) ? For now, We export only local data in metrics and system view. So, the answer is no, I think. > Transaction system view > --- > > Key: IGNITE-12209 > URL: https://issues.apache.org/jira/browse/IGNITE-12209 > Project: Ignite > Issue Type: Sub-task >Affects Versions: 2.7.6 >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Labels: IEP-35 > Fix For: 2.8 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > IGNITE-12145 finished > We should add transactions to the system views. -- This message was sent by Atlassian Jira (v8.3.4#803005)