[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276549#comment-17276549 ] Yaroslav Molochkov commented on IGNITE-10973: - Will be done within IGNITE-10958 context > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Yaroslav Molochkov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906006#comment-16906006 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], I suppose we cannot proceed until the problem with .NET tests is fixed. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903869#comment-16903869 ] Ivan Fedotov commented on IGNITE-10973: --- Seems that the .net problem is the last one. I brought the full context of the problem in the conversation. The problem is more general, JUnit migration looks like a consequence, not a cause. [1] http://apache-ignite-developers.2346864.n4.nabble.com/Test-naming-on-TC-JUnit-5-tp42750p42810.html > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898289#comment-16898289 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], good news. Am I getting it right that the PR will be ready when a problem with .NET tests is solved? > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16897268#comment-16897268 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin] I delivered information about migration to the community. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892556#comment-16892556 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], I suppose that we should fix .NET tests somehow. Apparently now we are ready to start massive migration to junit5. And so we should announce it to dev-list to discuss a strategy for the massive migration. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891243#comment-16891243 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin] , According to Parametrized test - I added a new dependency in the last commit. We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is simplier than in the fourth version. Rule and ClassRule annotations can be replaced by Extension and ExtendWith respectively. According to .net tests: the reason for failures is the only one: "The filename or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath because other args are hardcoded. I compared the log files from my branch[2] and master[3]. For some reason, jvmClasspath contains all maven dependencies. Because of addition more dependencies to pom file, this string becomes too long for system .net function. I guess that it is not correct behavior of Classpath.cs#CreateClasspath function, because if we need to add some more dependencies to pom file, we faced this problem. Moreover, it is not jvmClasspath, it's the enumeration of all jat files. [1] https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148 [2] https://ci.ignite.apache.org/viewLog.html?buildId=4318302&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_PlatformNetLongRunning [3] https://ci.ignite.apache.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=4381131&_focus=53179 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883868#comment-16883868 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], by the way, do you have any idea what is wrong with .NET tests? It seems that the same tests do not fail in master. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[
https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883842#comment-16883842
]
Ivan Pavlukhin commented on IGNITE-10973:
-
[~ivanan.fed], so, it seems that different names are caused by
{{surefire-junit47}} dependency. And actually I do not see a reason against
using it as we have been using junit 4.11 for a while. And yes, I guess
{{@UseTechnicalNames}} can be related to junit5 tests only (examples here).
So, I suppose we should return to dev-list announcing at least following:
1. First junit5 tests are going to appear in master.
2. Change in test report naming will obsolete TC bot history.
By the way, what is the plan for dealing with junit4 {{@Parameterized}} and
{{@Rule}}. I suppose that we already have them used in several places.
> Migrate example module tests from Junit 4 to 5
> --
>
> Key: IGNITE-10973
> URL: https://issues.apache.org/jira/browse/IGNITE-10973
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
> Labels: iep-30
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For more information refer parent task.
> Migrate from Junit 4 to 5 in the example module.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881322#comment-16881322 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin], I checked all blockers on TC bot. Apart from .Net block, the reason for all other blockers is "History for base branch is absent". Moreover, I made an experiment with @UseTechnicalNames annotation (look on the last two commits [1]) - it does not help, the name for TC still does not correspond to the previous name. So, from TC bot clear that all test from TC marked as blockers because of different name in parentheses and this is the only problem with naming. [1] https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/6606/head&action=Latest > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[
https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877108#comment-16877108
]
Ivan Pavlukhin commented on IGNITE-10973:
-
[~ivanan.fed], I examined surefire-reports and I see that running tests with
{{JUnitPlatform}} uses different naming style in report. Some more info could
be seen in {{UseTechnicalNames}} annotation javadoc. We need to be sure that
there will be no problems with such naming.
> Migrate example module tests from Junit 4 to 5
> --
>
> Key: IGNITE-10973
> URL: https://issues.apache.org/jira/browse/IGNITE-10973
> Project: Ignite
> Issue Type: Sub-task
>Reporter: Ivan Fedotov
>Assignee: Ivan Fedotov
>Priority: Major
> Labels: iep-30
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For more information refer parent task.
> Migrate from Junit 4 to 5 in the example module.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876385#comment-16876385 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin] , part of the name in parentheses means path. In the case, where names are different in the version before path consists from "path to suite: path to test" and in the version after just "path to test". I tried to find the place in the code where it is constructed. It seems that TC took this path from JUnit and it does not configure inside Ignite. But maybe I am wrong and we can configure it from TC. [~ein] could you please clarify is it possible to configure test name in parentheses in TC? > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871123#comment-16871123 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], indeed it seems that test naming is slightly differently reported before and after your changes related to junit/surefire. I suppose you can run some tests locally and inspect a content of target/surefire-reports directory to see the changes in test naming. I think using old-style naming would simplify further steps. Also about ignores related to IGNITE-711. I think it worth starting a discussion on dev-list about removing referred examples at all as the ticket seems too outdated. It hints that there is no need for it in practice. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869496#comment-16869496 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin], I tried to re-run multiple times, but the situation remains the same. Bot says that history is absent for the base branch. Can it be the case that bot is configured for the specific JUnit version (and it appears at least on some tests)? > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865513#comment-16865513 ] Ivan Pavlukhin commented on IGNITE-10973: - [~ivanan.fed], yes TC bot needs several runs to accumulate statistics for unknown tests. Such behavior can be observed when some test class moves to another package. It is very likely that merging your branch with fresh master will help here. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863955#comment-16863955 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin], Hi! In general I managed with migration examples module to JUnit 5. What I did: * added JUnit5 dependencies to parent/pom.xml. JUnit4 still works without any changes: junit-vintage allows us to use the previous version. * added junit47 provider to use the JUnit version in the project >= 4.7 * changed suite runner: from Suite.class to JUnitPlatform.class * in examples module changed annotations and uncommented ignored tests However, TC bot shows as blocker those tests which for some reasons do not have history on master branch [1]. I checked logs and tests have failures because of functionality. Moreover, they fail on master branch locally for the same reasons. But TC history for them is empty and they are not marked as ignored in code. Can be reason in TC/TC bot infrastucture, what do you think? [1] [https://mtcga.gridgain.com/pr.html?serverId=apache&suiteId=IgniteTests24Java8_RunAll&branchForTc=pull/6606/head&action=Latest] > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Labels: iep-30 > Time Spent: 0.5h > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749672#comment-16749672 ] Ivan Fedotov commented on IGNITE-10973: --- (i) It seems that @Runwith(Suite.class) annotation support is via JUnitPlatform Runner, but at that moment it is not executed directly on the JUnit Platform [1]. Practically that means that reporting in an IDE, particularly in IntelliJ IDEA, is not full. So, I decided to leave testsuites classes with such annotation on JUnit4. [1] https://stackoverflow.com/questions/50565724/are-test-suites-considered-deprecated-in-junit5 > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > For more information refer parent task. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10973) Migrate example module tests from Junit 4 to 5
[ https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746070#comment-16746070 ] Ivan Fedotov commented on IGNITE-10973: --- [~Pavlukhin], yes, thank you for the remark. The name was corrected. > Migrate example module tests from Junit 4 to 5 > -- > > Key: IGNITE-10973 > URL: https://issues.apache.org/jira/browse/IGNITE-10973 > Project: Ignite > Issue Type: Sub-task >Reporter: Ivan Fedotov >Assignee: Ivan Fedotov >Priority: Major > > For more information refer parent task for more details. > Migrate from Junit 4 to 5 in the example module. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
