[jira] [Commented] (IGNITE-11035) Web console: Implemement improvements for query page controller.
[
https://issues.apache.org/jira/browse/IGNITE-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801540#comment-16801540
]
Pavel Konstantinov commented on IGNITE-11035:
-
Re-tested on the master
> Web console: Implemement improvements for query page controller.
>
>
> Key: IGNITE-11035
> URL: https://issues.apache.org/jira/browse/IGNITE-11035
> Project: Ignite
> Issue Type: Improvement
> Components: wizards
>Reporter: Vasiliy Sisko
>Assignee: Andrey Novikov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 5h 35m
> Remaining Estimate: 0h
>
> # Implement processing of query result task without one level recursion.
> # Explicit serialization to JSON of Paragraph object. Possible
> {{Paragraph.prototype.toJSON should be implemented.}}
> # {{Try to use RXJS operator chain instead of direct usage of subscription
> object.}}
> # {{On query cancel task unlock UI in Promise.prototype.finally.}}
> # {{Check initialization of queryId and resultNodeId on execute of refresh
> in auto refresh mode.}}
> # {{Some paragraph manipulation methods should be moved into Paragraph
> class: _initQueryResult}}{{{color:#00}_, _showLoading._
> {color}}}{{{color:#00}Check other methods with paragraph as
> argument.{color}}}
> # {{{color:#00}Check clearing of data in _initQueryResult method.
> {color}}}{{{color:#00}Try to not use direct calling of grid
> API{color}}}{{{color:#00}. Possible we should show
> “{color}}}{{{color:#00}Query execution{color}}}{{{color:#00}” stub
> {color}}}{{{color:#00}instead.{color}}}
> # {{{color:#00}Remove “beforeunload” listener on leave of Queries
> page.{color}}}
> # {{{color:#00}Possible we should cancel queries when client session is
> over.{color}}}
> # {{{color:#00}Add docs for return values of queries task in agent
> manager. F.e:{color}}}
> {code:java}
> /*
> @returns {Promise}
> */{code}
> # Confirm on leaving of Queries page when running queries exist:
> {code:java}
> You have running queries. Are you sure you want to cancel them?
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11035) Web console: Implemement improvements for query page controller.
[
https://issues.apache.org/jira/browse/IGNITE-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796173#comment-16796173
]
Alexey Kuznetsov commented on IGNITE-11035:
---
Merged to master.
> Web console: Implemement improvements for query page controller.
>
>
> Key: IGNITE-11035
> URL: https://issues.apache.org/jira/browse/IGNITE-11035
> Project: Ignite
> Issue Type: Improvement
> Components: wizards
>Reporter: Vasiliy Sisko
>Assignee: Andrey Novikov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 5h 35m
> Remaining Estimate: 0h
>
> # Implement processing of query result task without one level recursion.
> # Explicit serialization to JSON of Paragraph object. Possible
> {{Paragraph.prototype.toJSON should be implemented.}}
> # {{Try to use RXJS operator chain instead of direct usage of subscription
> object.}}
> # {{On query cancel task unlock UI in Promise.prototype.finally.}}
> # {{Check initialization of queryId and resultNodeId on execute of refresh
> in auto refresh mode.}}
> # {{Some paragraph manipulation methods should be moved into Paragraph
> class: _initQueryResult}}{{{color:#00}_, _showLoading._
> {color}}}{{{color:#00}Check other methods with paragraph as
> argument.{color}}}
> # {{{color:#00}Check clearing of data in _initQueryResult method.
> {color}}}{{{color:#00}Try to not use direct calling of grid
> API{color}}}{{{color:#00}. Possible we should show
> “{color}}}{{{color:#00}Query execution{color}}}{{{color:#00}” stub
> {color}}}{{{color:#00}instead.{color}}}
> # {{{color:#00}Remove “beforeunload” listener on leave of Queries
> page.{color}}}
> # {{{color:#00}Possible we should cancel queries when client session is
> over.{color}}}
> # {{{color:#00}Add docs for return values of queries task in agent
> manager. F.e:{color}}}
> {code:java}
> /*
> @returns {Promise}
> */{code}
> # Confirm on leaving of Queries page when running queries exist:
> {code:java}
> You have running queries. Are you sure you want to cancel them?
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11035) Web console: Implemement improvements for query page controller.
[
https://issues.apache.org/jira/browse/IGNITE-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755948#comment-16755948
]
Vasiliy Sisko commented on IGNITE-11035:
Implemented confirmation and query cancellation on cluster change and remove of
paragraph.
> Web console: Implemement improvements for query page controller.
>
>
> Key: IGNITE-11035
> URL: https://issues.apache.org/jira/browse/IGNITE-11035
> Project: Ignite
> Issue Type: Improvement
>Reporter: Vasiliy Sisko
>Assignee: Pavel Konstantinov
>Priority: Major
> Time Spent: 25m
> Remaining Estimate: 0h
>
> # Implement processing of query result task without one level recursion.
> # Explicit serialization to JSON of Paragraph object. Possible
> {{Paragraph.prototype.toJSON should be implemented.}}
> # {{Try to use RXJS operator chain instead of direct usage of subscription
> object.}}
> # {{On query cancel task unlock UI in Promise.prototype.finally.}}
> # {{Check initialization of queryId and resultNodeId on execute of refresh
> in auto refresh mode.}}
> # {{Some paragraph manipulation methods should be moved into Paragraph
> class: _initQueryResult}}{{{color:#00}_, _showLoading._
> {color}}}{{{color:#00}Check other methods with paragraph as
> argument.{color}}}
> # {{{color:#00}Check clearing of data in _initQueryResult method.
> {color}}}{{{color:#00}Try to not use direct calling of grid
> API{color}}}{{{color:#00}. Possible we should show
> “{color}}}{{{color:#00}Query execution{color}}}{{{color:#00}” stub
> {color}}}{{{color:#00}instead.{color}}}
> # {{{color:#00}Remove “beforeunload” listener on leave of Queries
> page.{color}}}
> # {{{color:#00}Possible we should cancel queries when client session is
> over.{color}}}
> # {{{color:#00}Add docs for return values of queries task in agent
> manager. F.e:{color}}}
> {code:java}
> /*
> @returns {Promise}
> */{code}
> # Confirm on leaving of Queries page when running queries exist:
> {code:java}
> You have running queries. Are you sure you want to cancel them?
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11035) Web console: Implemement improvements for query page controller.
[
https://issues.apache.org/jira/browse/IGNITE-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753681#comment-16753681
]
Vasiliy Sisko commented on IGNITE-11035:
Implemented 1-8, 10-11.
Please test query execution and cancellation.
9 possible should be implemented after IGNITE-5617. Now grid does not
possibility to find all linked to session queries. Failed to stop queries in
case of browser crash.
> Web console: Implemement improvements for query page controller.
>
>
> Key: IGNITE-11035
> URL: https://issues.apache.org/jira/browse/IGNITE-11035
> Project: Ignite
> Issue Type: Improvement
>Reporter: Vasiliy Sisko
>Assignee: Vasiliy Sisko
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> # Implement processing of query result task without one level recursion.
> # Explicit serialization to JSON of Paragraph object. Possible
> {{Paragraph.prototype.toJSON should be implemented.}}
> # {{Try to use RXJS operator chain instead of direct usage of subscription
> object.}}
> # {{On query cancel task unlock UI in Promise.prototype.finally.}}
> # {{Check initialization of queryId and resultNodeId on execute of refresh
> in auto refresh mode.}}
> # {{Some paragraph manipulation methods should be moved into Paragraph
> class: _initQueryResult}}{{{color:#00}_, _showLoading._
> {color}}}{{{color:#00}Check other methods with paragraph as
> argument.{color}}}
> # {{{color:#00}Check clearing of data in _initQueryResult method.
> {color}}}{{{color:#00}Try to not use direct calling of grid
> API{color}}}{{{color:#00}. Possible we should show
> “{color}}}{{{color:#00}Query execution{color}}}{{{color:#00}” stub
> {color}}}{{{color:#00}instead.{color}}}
> # {{{color:#00}Remove “beforeunload” listener on leave of Queries
> page.{color}}}
> # {{{color:#00}Possible we should cancel queries when client session is
> over.{color}}}
> # {{{color:#00}Add docs for return values of queries task in agent
> manager. F.e:{color}}}
> {code:java}
> /*
> @returns {Promise}
> */{code}
> # Confirm on leaving of Queries page when running queries exist:
> {code:java}
> You have running queries. Are you sure you want to cancel them?
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
