[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811210#comment-16811210
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3500912buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809388#comment-16809388
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Platform .NET (Core Linux)*{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3500883]]
* dll: IgniteConfigurationTest.TestAllConfigurationProperties - 0,0% fails in
last 453 master runs.
{color:#d04437}PDS (Indexing){color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3500876]]
* IgnitePdsWithIndexingCoreTestSuite:
IgniteWalRecoveryTest.testRecoveryLargeNoCheckpoint - 0,0% fails in last 325
master runs.
{color:#d04437}Cache 5{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3500864]]
* IgniteCacheTestSuite5:
IgniteCachePartitionLossPolicySelfTest.testReadOnlySafeWithPersistence[ATOMIC]
- 0,0% fails in last 206 master runs.
{color:#d04437}Platform C++ (Linux Clang){color} [[tests 0 TIMEOUT , Exit Code
, Failure on metric |https://ci.ignite.apache.org/viewLog.html?buildId=3500842]]
{color:#d04437}Thin client: PHP{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3500846]]
{color:#d04437}Thin client: Python{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3500889]]
{color:#d04437}_Javadoc_{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3500847]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3500912buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809240#comment-16809240
]
Pavel Kuznetsov commented on IGNITE-11226:
--
[~vozerov] Ok I've updated patch according to your comments
p2: Thanks, I forgot to update method signatures in the interface, fixed that.
Actually, in the methods themselves, we don't throw any exceptions, we rely on
the validation performed in the parser, which already sets
{{IgniteQueryErrorCode}} s. Should we catch them in the indexing and re-throw
with some other code?
p3: hm. Ok, I switched to {{IgniteCheckedException}} it means we hide original
reason (which is thrown by h2) from user. Is it ok?
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804385#comment-16804385
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3434609buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803473#comment-16803473
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}MVCC Cache{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3434540]]
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3434609buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803186#comment-16803186 ] Pavel Kuznetsov commented on IGNITE-11226: -- 1. Done 2. JDBC spec says nothing about prepared statement metadatas (result set and parameters) that contain multiple sql statements separated by ";" (script). H2 returns metadata of the first sql statement of the script. PostgreSql returns all the meta about all the parameters found in the script. (Thanks for checking) Mysql doesn't support multiple SELECT statements for the PreparedStatement and throws parsing error in this case. DML is allowed, returned meta about all the parameters. As we discussed, final point: - result set metadata for the multistatements and dml is null - parameters metadata about all the parameters of the multistatetment should be returned. added implementation notes to the PreparedStatemet implementations. > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797192#comment-16797192
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: No blockers
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3358281buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796965#comment-16796965 ] Pavel Kuznetsov commented on IGNITE-11226: -- Fixed comments. Added test cases. Failover tests failed due to timeout. [~vozerov] would you please take a look at the patch? > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796745#comment-16796745
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache (Failover) 2{color} [[tests
6|https://ci.ignite.apache.org/viewLog.html?buildId=3358222]]
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineUpCachePutAllFailoverTest.testPutAllFailover - 0,0% fails
in last 405 master runs.
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineUpCachePutAllFailoverTest.testPutAllFailoverPessimisticTx
- 0,0% fails in last 405 master runs.
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineDownCachePutAllFailoverTest.testPutAllFailoverAsync -
0,0% fails in last 405 master runs.
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineDownCachePutAllFailoverTest.testPutAllFailover - 0,0%
fails in last 405 master runs.
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineDownCachePutAllFailoverTest.testPutAllFailoverPessimisticTx
- 0,0% fails in last 405 master runs.
* IgniteCacheFailoverTestSuite2:
IgniteChangingBaselineUpCachePutAllFailoverTest.testPutAllFailoverAsync - 0,0%
fails in last 405 master runs.
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3358281buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794936#comment-16794936 ] Pavel Kuznetsov commented on IGNITE-11226: -- to be confident scheduled re-run of mvcc queries https://ci.ignite.apache.org/viewQueued.html?itemId=3343473 > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794923#comment-16794923 ] Pavel Kuznetsov commented on IGNITE-11226: -- [~vozerov] there are troubles with bot visa. Visa can be viewed at https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/6258/head=Latest 1) Inspections log tells about JobStealingCollisionSpi.java - out of the scope (https://ci.ignite.apache.org/viewLog.html?buildId=3339821) 2) MVCC Queries Failed due to timeout https://ci.ignite.apache.org/viewLog.html?buildId=3339776 3) PHP client tests failed due to auth troubles : https://ci.ignite.apache.org/viewLog.html?buildId=3339777 > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794610#comment-16794610 ] Pavel Kuznetsov commented on IGNITE-11226: -- rerun : https://ci.ignite.apache.org/viewQueued.html?itemId=3339843=queuedBuildOverviewTab > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Fix For: 2.8 > > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792602#comment-16792602
]
Ignite TC Bot commented on IGNITE-11226:
{panel:title=-- Run :: All: Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}PDS (Indexing){color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3307570]]
{color:#d04437}MVCC Cache 7{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3307598]]
{color:#d04437}Cache (Full API){color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=3307550]]
{color:#d04437}Platform C++ (Win x64 | Release){color} [[tests 1
BuildFailureOnMessage
|https://ci.ignite.apache.org/viewLog.html?buildId=3307531]]
* IgniteOdbcTest: QueriesTestSuite: TestParamsNum - 0,6% fails in last 500
master runs.
{color:#d04437}_Javadoc_{color} [[tests 0 BuildFailureOnMessage
|https://ci.ignite.apache.org/viewLog.html?buildId=3307541]]
{color:#d04437}Continuous Query 2{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3307501]]
* IgniteCacheQuerySelfTestSuite4:
CacheContinuousQueryAsyncFailoverTxReplicatedSelfTest.testRebalance - 0,0%
fails in last 313 master runs.
{color:#d04437}Activate / Deactivate Cluster{color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=3307495]]
* IgniteStandByClusterSuite: IgniteNoParrallelClusterIsAllowedTest.testSimple -
0,0% fails in last 320 master runs.
{panel}
[TeamCity *-- Run :: All*
Results|https://ci.ignite.apache.org/viewLog.html?buildId=3307606buildTypeId=IgniteTests24Java8_RunAll]
> SQL: Remove GridQueryIndexing.prepareNativeStatement
>
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792494#comment-16792494 ] Pavel Kuznetsov commented on IGNITE-11226: -- new failures from results are not repoducible locally and don't seem to be related to the patch > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16792079#comment-16792079 ] Pavel Kuznetsov commented on IGNITE-11226: -- scheduled runall: https://ci.ignite.apache.org/viewQueued.html?itemId=3307606 > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-11226) SQL: Remove GridQueryIndexing.prepareNativeStatement
[ https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790543#comment-16790543 ] Pavel Kuznetsov commented on IGNITE-11226: -- [~vozerov] Ready for the prelementary review! > SQL: Remove GridQueryIndexing.prepareNativeStatement > > > Key: IGNITE-11226 > URL: https://issues.apache.org/jira/browse/IGNITE-11226 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Vladimir Ozerov >Assignee: Pavel Kuznetsov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This method is the only leak of H2 internals to the outer code. Close > analysis of code reveals that the only reason we have it is *JDBC metadata*. > Need to create a method which will prepare metadata for a statement and > return it as a detached object. Most probably we already have all necessary > mechanics. This is more about refactoring. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
